Re: [PATCH v5 00/11] drm/fb-helper: Move modesetting code to drm_client

[Sam Ravnborg]

Hi Noralf.

> >   drm/fb-helper: Remove drm_fb_helper_crtc
> >   drm/fb-helper: Prepare to move out commit code
> >   drm/fb-helper: Move out commit code
> >   drm/fb-helper: Remove drm_fb_helper_connector
> 
> Patches 5-8 are still in need of review...
With the improved changelogs the remaining patches are all good to go
as far as I am concerned.
(Not the bootsplash hack - but thats kind of obvious)

Nice series!

Sam
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v5 00/11] drm/fb-helper: Move modesetting code to drm_client

[Noralf Trønnes]

Den 06.05.2019 20.01, skrev Noralf Trønnes:
> This moves the modesetting code from drm_fb_helper to drm_client so it
> can be shared by all internal clients.
> 
> Changes this time:
> - Use restore_fbdev_mode_force() in 
>   drm_fb_helper_restore_fbdev_mode_unlocked() to please igt tests. I'm not
>   currently motivated to learn igt so I have added a todo entry for this.
> - Rebase on drm-next (drm_fb_helper and drm_legacy patches)
> 
> Noralf.
> 
> Noralf Trønnes (11):
>   drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

>   drm/fb-helper: Avoid race with DRM userspace
>   drm/fb-helper: No need to cache rotation and sw_rotations
>   drm/fb-helper: Remove drm_fb_helper_crtc->{x,y,desired_mode}

Patches 2-4 applied, thanks for reviewing.

>   drm/fb-helper: Remove drm_fb_helper_crtc
>   drm/fb-helper: Prepare to move out commit code
>   drm/fb-helper: Move out commit code
>   drm/fb-helper: Remove drm_fb_helper_connector

Patches 5-8 are still in need of review...

Noralf.

>   drm/fb-helper: Prepare to move out modeset config code
>   drm/fb-helper: Move out modeset config code
>   drm/client: Hack: Add bootsplash example
> 
>  Documentation/gpu/drm-client.rst |3 +
>  Documentation/gpu/todo.rst   |   15 +
>  drivers/gpu/drm/Kconfig  |5 +
>  drivers/gpu/drm/Makefile |3 +-
>  drivers/gpu/drm/drm_atomic.c |  168 
>  drivers/gpu/drm/drm_atomic_helper.c  |  164 ---
>  drivers/gpu/drm/drm_auth.c   |   20 +
>  drivers/gpu/drm/drm_bootsplash.c |  358 +++
>  drivers/gpu/drm/drm_client.c |   17 +-
>  drivers/gpu/drm/drm_client_modeset.c | 1086 
>  drivers/gpu/drm/drm_crtc_internal.h  |5 +
>  drivers/gpu/drm/drm_drv.c|4 +
>  drivers/gpu/drm/drm_fb_helper.c  | 1392 +++---
>  drivers/gpu/drm/drm_internal.h   |2 +
>  include/drm/drm_atomic_helper.h  |4 -
>  include/drm/drm_client.h |   49 +
>  include/drm/drm_fb_helper.h  |  102 +-
>  17 files changed, 1876 insertions(+), 1521 deletions(-)
>  create mode 100644 drivers/gpu/drm/drm_bootsplash.c
>  create mode 100644 drivers/gpu/drm/drm_client_modeset.c
> 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v5 00/11] drm/fb-helper: Move modesetting code to drm_client

[Noralf Trønnes]

This moves the modesetting code from drm_fb_helper to drm_client so it
can be shared by all internal clients.

Changes this time:
- Use restore_fbdev_mode_force() in 
  drm_fb_helper_restore_fbdev_mode_unlocked() to please igt tests. I'm not
  currently motivated to learn igt so I have added a todo entry for this.
- Rebase on drm-next (drm_fb_helper and drm_legacy patches)

Noralf.

Noralf Trønnes (11):
  drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()
  drm/fb-helper: Avoid race with DRM userspace
  drm/fb-helper: No need to cache rotation and sw_rotations
  drm/fb-helper: Remove drm_fb_helper_crtc->{x,y,desired_mode}
  drm/fb-helper: Remove drm_fb_helper_crtc
  drm/fb-helper: Prepare to move out commit code
  drm/fb-helper: Move out commit code
  drm/fb-helper: Remove drm_fb_helper_connector
  drm/fb-helper: Prepare to move out modeset config code
  drm/fb-helper: Move out modeset config code
  drm/client: Hack: Add bootsplash example

 Documentation/gpu/drm-client.rst |3 +
 Documentation/gpu/todo.rst   |   15 +
 drivers/gpu/drm/Kconfig  |5 +
 drivers/gpu/drm/Makefile |3 +-
 drivers/gpu/drm/drm_atomic.c |  168 
 drivers/gpu/drm/drm_atomic_helper.c  |  164 ---
 drivers/gpu/drm/drm_auth.c   |   20 +
 drivers/gpu/drm/drm_bootsplash.c |  358 +++
 drivers/gpu/drm/drm_client.c |   17 +-
 drivers/gpu/drm/drm_client_modeset.c | 1086 
 drivers/gpu/drm/drm_crtc_internal.h  |5 +
 drivers/gpu/drm/drm_drv.c|4 +
 drivers/gpu/drm/drm_fb_helper.c  | 1392 +++---
 drivers/gpu/drm/drm_internal.h   |2 +
 include/drm/drm_atomic_helper.h  |4 -
 include/drm/drm_client.h |   49 +
 include/drm/drm_fb_helper.h  |  102 +-
 17 files changed, 1876 insertions(+), 1521 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_bootsplash.c
 create mode 100644 drivers/gpu/drm/drm_client_modeset.c

-- 
2.20.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel