Re: [PATCHv10 2/2] cec: document CEC_ADAP_G_CONNECTOR_INFO and capability

2019-08-28 Thread Hans Verkuil
On 8/28/19 9:27 AM, Dariusz Marcinkiewicz wrote:
> Hi.
> 
> Should this patch also have an explicit From tag?

Oops, sorry, it was lost at some point.

This is the list of all cec patches for drm:

https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=cec-drm

The first 5 patches are pushed (drm_dp_cec up to vc4), but the
drm_dp_cec/i915/vc4 patches were pushed too late for kernel 5.4 :-(

So my plan is to get the others in for 5.5. I'll merge the last
two patches that enable the API early in the 5.5 cycle in the media
tree (so right after v5.4-rc1 is released) and work to get the remaining
Acks for the other drm cec patches.

Regards,

Hans

> 
> On Fri, Aug 23, 2019 at 2:21 PM Hans Verkuil  wrote:
>>
>> Document the new CEC_ADAP_G_CONNECTOR_INFO ioctl and the new
>> CEC_CAP_CONNECTOR_INFO capability.
>>
>> Signed-off-by: Dariusz Marcinkiewicz 
>> Co-developed-by: Hans Verkuil 
>> [hverkuil-ci...@xs4all.nl: added CEC_CAP_CONNECTOR_INFO]
>> [hverkuil-ci...@xs4all.nl: added DQEVENT have_conn_info]
>> Signed-off-by: Hans Verkuil 
>> ---
> ...
> 



Re: [PATCHv10 2/2] cec: document CEC_ADAP_G_CONNECTOR_INFO and capability

2019-08-28 Thread Dariusz Marcinkiewicz
Hi.

Should this patch also have an explicit From tag?

On Fri, Aug 23, 2019 at 2:21 PM Hans Verkuil  wrote:
>
> Document the new CEC_ADAP_G_CONNECTOR_INFO ioctl and the new
> CEC_CAP_CONNECTOR_INFO capability.
>
> Signed-off-by: Dariusz Marcinkiewicz 
> Co-developed-by: Hans Verkuil 
> [hverkuil-ci...@xs4all.nl: added CEC_CAP_CONNECTOR_INFO]
> [hverkuil-ci...@xs4all.nl: added DQEVENT have_conn_info]
> Signed-off-by: Hans Verkuil 
> ---
...


[PATCHv10 2/2] cec: document CEC_ADAP_G_CONNECTOR_INFO and capability

2019-08-25 Thread Hans Verkuil
Document the new CEC_ADAP_G_CONNECTOR_INFO ioctl and the new
CEC_CAP_CONNECTOR_INFO capability.

Signed-off-by: Dariusz Marcinkiewicz 
Co-developed-by: Hans Verkuil 
[hverkuil-ci...@xs4all.nl: added CEC_CAP_CONNECTOR_INFO]
[hverkuil-ci...@xs4all.nl: added DQEVENT have_conn_info]
Signed-off-by: Hans Verkuil 
---
 Documentation/media/uapi/cec/cec-funcs.rst|   1 +
 .../media/uapi/cec/cec-ioc-adap-g-caps.rst|   6 +-
 .../uapi/cec/cec-ioc-adap-g-conn-info.rst | 105 ++
 .../media/uapi/cec/cec-ioc-dqevent.rst|   8 ++
 4 files changed, 119 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/media/uapi/cec/cec-ioc-adap-g-conn-info.rst

diff --git a/Documentation/media/uapi/cec/cec-funcs.rst 
b/Documentation/media/uapi/cec/cec-funcs.rst
index 620590b168c9..dc6da9c639a8 100644
--- a/Documentation/media/uapi/cec/cec-funcs.rst
+++ b/Documentation/media/uapi/cec/cec-funcs.rst
@@ -24,6 +24,7 @@ Function Reference
 cec-ioc-adap-g-caps
 cec-ioc-adap-g-log-addrs
 cec-ioc-adap-g-phys-addr
+cec-ioc-adap-g-conn-info
 cec-ioc-dqevent
 cec-ioc-g-mode
 cec-ioc-receive
diff --git a/Documentation/media/uapi/cec/cec-ioc-adap-g-caps.rst 
b/Documentation/media/uapi/cec/cec-ioc-adap-g-caps.rst
index 0c44f31a9b59..76761a98c312 100644
--- a/Documentation/media/uapi/cec/cec-ioc-adap-g-caps.rst
+++ b/Documentation/media/uapi/cec/cec-ioc-adap-g-caps.rst
@@ -135,8 +135,12 @@ returns the information to the application. The ioctl 
never fails.
   - The CEC hardware can monitor CEC pin changes from low to high voltage
 and vice versa. When in pin monitoring mode the application will
receive ``CEC_EVENT_PIN_CEC_LOW`` and ``CEC_EVENT_PIN_CEC_HIGH`` events.
+* .. _`CEC-CAP-CONNECTOR-INFO`:
 
-
+  - ``CEC_CAP_CONNECTOR_INFO``
+  - 0x0100
+  - If this capability is set, then :ref:`CEC_ADAP_G_CONNECTOR_INFO` can
+be used.
 
 Return Value
 
diff --git a/Documentation/media/uapi/cec/cec-ioc-adap-g-conn-info.rst 
b/Documentation/media/uapi/cec/cec-ioc-adap-g-conn-info.rst
new file mode 100644
index ..a21659d55c6b
--- /dev/null
+++ b/Documentation/media/uapi/cec/cec-ioc-adap-g-conn-info.rst
@@ -0,0 +1,105 @@
+.. SPDX-License-Identifier: GPL-2.0
+..
+.. Copyright 2019 Google LLC
+..
+.. _CEC_ADAP_G_CONNECTOR_INFO:
+
+***
+ioctl CEC_ADAP_G_CONNECTOR_INFO
+***
+
+Name
+
+
+CEC_ADAP_G_CONNECTOR_INFO - Query HDMI connector information
+
+Synopsis
+
+
+.. c:function:: int ioctl( int fd, CEC_ADAP_G_CONNECTOR_INFO, struct 
cec_connector_info *argp )
+:name: CEC_ADAP_G_CONNECTOR_INFO
+
+Arguments
+=
+
+``fd``
+File descriptor returned by :c:func:`open() `.
+
+``argp``
+
+
+Description
+===
+
+Using this ioctl an application can learn which HDMI connector this CEC
+device corresponds to. While calling this ioctl the application should
+provide a pointer to a cec_connector_info struct which will be populated
+by the kernel with the info provided by the adapter's driver. This ioctl
+is only available if the ``CEC_CAP_CONNECTOR_INFO`` capability is set.
+
+.. tabularcolumns:: |p{1.0cm}|p{4.4cm}|p{2.5cm}|p{9.6cm}|
+
+.. c:type:: cec_connector_info
+
+.. flat-table:: struct cec_connector_info
+:header-rows:  0
+:stub-columns: 0
+:widths:   1 1 1 8
+
+* - __u32
+  - ``type``
+  - The type of connector this adapter is associated with.
+* - union
+  - ``(anonymous)``
+  -
+* -
+  - ``struct cec_drm_connector_info``
+  - drm
+  - :ref:`cec-drm-connector-info`
+
+
+.. tabularcolumns:: |p{4.4cm}|p{2.5cm}|p{10.6cm}|
+
+.. _connector-type:
+
+.. flat-table:: Connector types
+:header-rows:  0
+:stub-columns: 0
+:widths:   3 1 8
+
+* .. _`CEC-CONNECTOR-TYPE-NO-CONNECTOR`:
+
+  - ``CEC_CONNECTOR_TYPE_NO_CONNECTOR``
+  - 0
+  - No connector is associated with the adapter/the information is not
+provided by the driver.
+* .. _`CEC-CONNECTOR-TYPE-DRM`:
+
+  - ``CEC_CONNECTOR_TYPE_DRM``
+  - 1
+  - Indicates that a DRM connector is associated with this adapter.
+Information about the connector can be found in
+   :ref:`cec-drm-connector-info`.
+
+.. tabularcolumns:: |p{4.4cm}|p{2.5cm}|p{10.6cm}|
+
+.. c:type:: cec_drm_connector_info
+
+.. _cec-drm-connector-info:
+
+.. flat-table:: struct cec_drm_connector_info
+:header-rows:  0
+:stub-columns: 0
+:widths:   3 1 8
+
+* .. _`CEC-DRM-CONNECTOR-TYPE-CARD-NO`:
+
+  - __u32
+  - ``card_no``
+  - DRM card number: the number from a card's path, e.g. 0 in case of
+/dev/card0.
+* .. _`CEC-DRM-CONNECTOR-TYPE-CONNECTOR_ID`:
+
+  - __u32
+  - ``connector_id``
+  - DRM connector ID.
diff --git a/Documentation/media/uapi/cec/cec-ioc-dqevent.rst 
b/Documentation/media/uapi/cec/cec-ioc-dqevent.rst
index 46a1c99a595e..5e21b1fbfc01 100644