Re: [RESEND FOR CI] i915: no need to check return value of debugfs_create functions

[Jani Nikula]

On Thu, 13 Jun 2019, Jani Nikula  wrote:
> From: Greg Kroah-Hartman 
>
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Jani Nikula 
> Cc: Joonas Lahtinen 
> Cc: Rodrigo Vivi 
> Cc: David Airlie 
> Cc: Daniel Vetter 
> Cc: intel-...@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Greg Kroah-Hartman 
> Signed-off-by: Jani Nikula 

And pushed to drm-intel-next-queued, thanks for the patch.

BR,
Jani.

> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 20 +++-
>  1 file changed, 7 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c 
> b/drivers/gpu/drm/i915/i915_debugfs.c
> index 323863504111..41386c86ea65 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -4442,23 +4442,17 @@ static const struct i915_debugfs_files {
>  int i915_debugfs_register(struct drm_i915_private *dev_priv)
>  {
>   struct drm_minor *minor = dev_priv->drm.primary;
> - struct dentry *ent;
>   int i;
>  
> - ent = debugfs_create_file("i915_forcewake_user", S_IRUSR,
> -   minor->debugfs_root, to_i915(minor->dev),
> -   _forcewake_fops);
> - if (!ent)
> - return -ENOMEM;
> + debugfs_create_file("i915_forcewake_user", S_IRUSR, minor->debugfs_root,
> + to_i915(minor->dev), _forcewake_fops);
>  
>   for (i = 0; i < ARRAY_SIZE(i915_debugfs_files); i++) {
> - ent = debugfs_create_file(i915_debugfs_files[i].name,
> -   S_IRUGO | S_IWUSR,
> -   minor->debugfs_root,
> -   to_i915(minor->dev),
> -   i915_debugfs_files[i].fops);
> - if (!ent)
> - return -ENOMEM;
> + debugfs_create_file(i915_debugfs_files[i].name,
> + S_IRUGO | S_IWUSR,
> + minor->debugfs_root,
> + to_i915(minor->dev),
> + i915_debugfs_files[i].fops);
>   }
>  
>   return drm_debugfs_create_files(i915_debugfs_list,

-- 
Jani Nikula, Intel Open Source Graphics Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[RESEND FOR CI] i915: no need to check return value of debugfs_create functions

[Jani Nikula]

From: Greg Kroah-Hartman 

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Jani Nikula 
Cc: Joonas Lahtinen 
Cc: Rodrigo Vivi 
Cc: David Airlie 
Cc: Daniel Vetter 
Cc: intel-...@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Jani Nikula 
---
 drivers/gpu/drm/i915/i915_debugfs.c | 20 +++-
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c 
b/drivers/gpu/drm/i915/i915_debugfs.c
index 323863504111..41386c86ea65 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -4442,23 +4442,17 @@ static const struct i915_debugfs_files {
 int i915_debugfs_register(struct drm_i915_private *dev_priv)
 {
struct drm_minor *minor = dev_priv->drm.primary;
-   struct dentry *ent;
int i;
 
-   ent = debugfs_create_file("i915_forcewake_user", S_IRUSR,
- minor->debugfs_root, to_i915(minor->dev),
- _forcewake_fops);
-   if (!ent)
-   return -ENOMEM;
+   debugfs_create_file("i915_forcewake_user", S_IRUSR, minor->debugfs_root,
+   to_i915(minor->dev), _forcewake_fops);
 
for (i = 0; i < ARRAY_SIZE(i915_debugfs_files); i++) {
-   ent = debugfs_create_file(i915_debugfs_files[i].name,
- S_IRUGO | S_IWUSR,
- minor->debugfs_root,
- to_i915(minor->dev),
- i915_debugfs_files[i].fops);
-   if (!ent)
-   return -ENOMEM;
+   debugfs_create_file(i915_debugfs_files[i].name,
+   S_IRUGO | S_IWUSR,
+   minor->debugfs_root,
+   to_i915(minor->dev),
+   i915_debugfs_files[i].fops);
}
 
return drm_debugfs_create_files(i915_debugfs_list,
-- 
2.20.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel