Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses

2018-03-19 Thread Daniel Vetter
On Fri, Mar 16, 2018 at 05:29:02AM -0700, Joe Perches wrote: > On Fri, 2018-03-16 at 08:41 +0100, Daniel Vetter wrote: > > On Tue, Mar 13, 2018 at 03:02:15PM -0700, Joe Perches wrote: > > > drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary > > > arguments that can be removed by

Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses

2018-03-16 Thread Joe Perches
On Fri, 2018-03-16 at 08:41 +0100, Daniel Vetter wrote: > On Tue, Mar 13, 2018 at 03:02:15PM -0700, Joe Perches wrote: > > drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary > > arguments that can be removed by creating separate functins. > > > > Create specific functions for

Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses

2018-03-16 Thread Daniel Vetter
On Tue, Mar 13, 2018 at 03:02:15PM -0700, Joe Perches wrote: > drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary > arguments that can be removed by creating separate functins. > > Create specific functions for these calls to reduce x86/64 defconfig > size by ~20k. > > Modify

Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses

2018-03-15 Thread Joe Perches
On Thu, 2018-03-15 at 18:14 +0200, Ville Syrjälä wrote: > > There's no trade-off in this patch for faster/larger. > > This patch is simply smaller. Smaller is better. > > This feels a bit like saying pink is better than red because it's > more pink. Silly. If you can't say smaller total object

Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses

2018-03-15 Thread Ville Syrjälä
On Thu, Mar 15, 2018 at 08:44:05AM -0700, Joe Perches wrote: > On Thu, 2018-03-15 at 17:37 +0200, Ville Syrjälä wrote: > > On Thu, Mar 15, 2018 at 08:17:53AM -0700, Joe Perches wrote: > > > On Thu, 2018-03-15 at 17:05 +0200, Ville Syrjälä wrote: > > > > On Thu, Mar 15, 2018 at 03:04:52PM +0100,

Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses

2018-03-15 Thread Joe Perches
On Thu, 2018-03-15 at 17:37 +0200, Ville Syrjälä wrote: > On Thu, Mar 15, 2018 at 08:17:53AM -0700, Joe Perches wrote: > > On Thu, 2018-03-15 at 17:05 +0200, Ville Syrjälä wrote: > > > On Thu, Mar 15, 2018 at 03:04:52PM +0100, Maarten Lankhorst wrote: > > > > Op 15-03-18 om 14:30 schreef Ville

Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses

2018-03-15 Thread Ville Syrjälä
On Thu, Mar 15, 2018 at 08:17:53AM -0700, Joe Perches wrote: > On Thu, 2018-03-15 at 17:05 +0200, Ville Syrjälä wrote: > > On Thu, Mar 15, 2018 at 03:04:52PM +0100, Maarten Lankhorst wrote: > > > Op 15-03-18 om 14:30 schreef Ville Syrjälä: > > > > On Tue, Mar 13, 2018 at 03:02:15PM -0700, Joe

Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses

2018-03-15 Thread Joe Perches
On Thu, 2018-03-15 at 17:05 +0200, Ville Syrjälä wrote: > On Thu, Mar 15, 2018 at 03:04:52PM +0100, Maarten Lankhorst wrote: > > Op 15-03-18 om 14:30 schreef Ville Syrjälä: > > > On Tue, Mar 13, 2018 at 03:02:15PM -0700, Joe Perches wrote: > > > > drm_printk is used for both DRM_ERROR and

Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses

2018-03-15 Thread Ville Syrjälä
On Thu, Mar 15, 2018 at 03:04:52PM +0100, Maarten Lankhorst wrote: > Op 15-03-18 om 14:30 schreef Ville Syrjälä: > > On Tue, Mar 13, 2018 at 03:02:15PM -0700, Joe Perches wrote: > >> drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary > >> arguments that can be removed by creating

Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses

2018-03-15 Thread Joe Perches
On Thu, 2018-03-15 at 14:22 +0100, Maarten Lankhorst wrote: > Op 13-03-18 om 23:02 schreef Joe Perches: > > drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary > > arguments that can be removed by creating separate functins. > > > > Create specific functions for these calls to

Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses

2018-03-15 Thread Maarten Lankhorst
Op 15-03-18 om 14:30 schreef Ville Syrjälä: > On Tue, Mar 13, 2018 at 03:02:15PM -0700, Joe Perches wrote: >> drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary >> arguments that can be removed by creating separate functins. >> >> Create specific functions for these calls to

Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses

2018-03-15 Thread Ville Syrjälä
On Tue, Mar 13, 2018 at 03:02:15PM -0700, Joe Perches wrote: > drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary > arguments that can be removed by creating separate functins. > > Create specific functions for these calls to reduce x86/64 defconfig > size by ~20k. > > Modify

Re: [PATCH] drm: Reduce object size of DRM_ERROR and DRM_DEBUG uses

2018-03-15 Thread Maarten Lankhorst
Op 13-03-18 om 23:02 schreef Joe Perches: > drm_printk is used for both DRM_ERROR and DRM_DEBUG with unnecessary > arguments that can be removed by creating separate functins. > > Create specific functions for these calls to reduce x86/64 defconfig > size by ~20k. > > Modify the existing macros to