Re: [PATCH v2 4/6] drm/fourcc: Pass the format_info pointer to drm_format_plane_cpp
On Sun, May 12, 2019 at 07:30:54PM +0200, Maxime Ripard wrote: > Hi Ville, > > On Fri, May 10, 2019 at 07:00:31PM +0300, Ville Syrjälä wrote: > > On Fri, May 10, 2019 at 01:08:49PM +0200, Maxime Ripard wrote: > > > So far, the drm_format_plane_cpp function was operating on the format's > > > fourcc and was doing a lookup to retrieve the drm_format_info structure > > > and > > > return the cpp. > > > > > > However, this is inefficient since in most cases, we will have the > > > drm_format_info pointer already available so we shouldn't have to perform > > > a > > > new lookup. Some drm_fourcc functions also already operate on the > > > drm_format_info pointer for that reason, so the API is quite inconsistent > > > there. > > > > > > Let's follow the latter pattern and remove the extra lookup while being a > > > bit more consistent. In order to be extra consistent, also rename that > > > function to drm_format_info_plane_cpp and to a static function in the > > > header to match the current policy. > > > > Is there any point keeping the function at all? > > It's just info->cpp[i] no? > > You're right, we can remove it. > > Do you want this to be done in that patch or a subsequent one? I don't mind either way. -- Ville Syrjälä Intel
Re: [PATCH v2 4/6] drm/fourcc: Pass the format_info pointer to drm_format_plane_cpp
Hi Ville, On Fri, May 10, 2019 at 07:00:31PM +0300, Ville Syrjälä wrote: > On Fri, May 10, 2019 at 01:08:49PM +0200, Maxime Ripard wrote: > > So far, the drm_format_plane_cpp function was operating on the format's > > fourcc and was doing a lookup to retrieve the drm_format_info structure and > > return the cpp. > > > > However, this is inefficient since in most cases, we will have the > > drm_format_info pointer already available so we shouldn't have to perform a > > new lookup. Some drm_fourcc functions also already operate on the > > drm_format_info pointer for that reason, so the API is quite inconsistent > > there. > > > > Let's follow the latter pattern and remove the extra lookup while being a > > bit more consistent. In order to be extra consistent, also rename that > > function to drm_format_info_plane_cpp and to a static function in the > > header to match the current policy. > > Is there any point keeping the function at all? > It's just info->cpp[i] no? You're right, we can remove it. Do you want this to be done in that patch or a subsequent one? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Re: [PATCH v2 4/6] drm/fourcc: Pass the format_info pointer to drm_format_plane_cpp
On Fri, May 10, 2019 at 01:08:49PM +0200, Maxime Ripard wrote: > So far, the drm_format_plane_cpp function was operating on the format's > fourcc and was doing a lookup to retrieve the drm_format_info structure and > return the cpp. > > However, this is inefficient since in most cases, we will have the > drm_format_info pointer already available so we shouldn't have to perform a > new lookup. Some drm_fourcc functions also already operate on the > drm_format_info pointer for that reason, so the API is quite inconsistent > there. > > Let's follow the latter pattern and remove the extra lookup while being a > bit more consistent. In order to be extra consistent, also rename that > function to drm_format_info_plane_cpp and to a static function in the > header to match the current policy. Is there any point keeping the function at all? It's just info->cpp[i] no? -- Ville Syrjälä Intel ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
