Re: [PATCH v2 7/8] dt-bindings: media: renesas, vsp1: Convert binding to YAML

2020-07-13 Thread Rob Herring
On Sun, 21 Jun 2020 03:47:33 +0300, Laurent Pinchart wrote:
> Convert the Renesas R-Car VSP1 text binding to YAML.
> 
> Signed-off-by: Laurent Pinchart 
> Reviewed-by: Geert Uytterhoeven 
> ---
> Changes since v1:
> 
> - Simplify comments on compatible strings
> - Update MAINTAINERS
> ---
>  .../bindings/media/renesas,vsp1.txt   | 30 ---
>  .../bindings/media/renesas,vsp1.yaml  | 83 +++
>  MAINTAINERS   |  2 +-
>  3 files changed, 84 insertions(+), 31 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.txt
>  create mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> 

Reviewed-by: Rob Herring 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [PATCH v2 7/8] dt-bindings: media: renesas, vsp1: Convert binding to YAML

2020-07-01 Thread Niklas Söderlund
Hi Laurent,

Thanks for your patch.

On 2020-06-21 03:47:33 +0300, Laurent Pinchart wrote:
> Convert the Renesas R-Car VSP1 text binding to YAML.
> 
> Signed-off-by: Laurent Pinchart 
> Reviewed-by: Geert Uytterhoeven 

Reviewed-by: Niklas Söderlund 

> ---
> Changes since v1:
> 
> - Simplify comments on compatible strings
> - Update MAINTAINERS
> ---
>  .../bindings/media/renesas,vsp1.txt   | 30 ---
>  .../bindings/media/renesas,vsp1.yaml  | 83 +++
>  MAINTAINERS   |  2 +-
>  3 files changed, 84 insertions(+), 31 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.txt
>  create mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.txt 
> b/Documentation/devicetree/bindings/media/renesas,vsp1.txt
> deleted file mode 100644
> index cd5a955b2ea0..
> --- a/Documentation/devicetree/bindings/media/renesas,vsp1.txt
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -* Renesas VSP Video Processing Engine
> -
> -The VSP is a video processing engine that supports up-/down-scaling, alpha
> -blending, color space conversion and various other image processing features.
> -It can be found in the Renesas R-Car Gen2, R-Car Gen3, RZ/G1, and RZ/G2 SoCs.
> -
> -Required properties:
> -
> -  - compatible: Must contain one of the following values
> -- "renesas,vsp1" for the R-Car Gen2 and RZ/G1 VSP1
> -- "renesas,vsp2" for the R-Car Gen3 and RZ/G2 VSP2
> -
> -  - reg: Base address and length of the registers block for the VSP.
> -  - interrupts: VSP interrupt specifier.
> -  - clocks: A phandle + clock-specifier pair for the VSP functional clock.
> -
> -Optional properties:
> -
> -  - renesas,fcp: A phandle referencing the FCP that handles memory accesses
> - for the VSP. Not needed on Gen2, mandatory on Gen3.
> -
> -
> -Example: R8A7790 (R-Car H2) VSP1-S node
> -
> - vsp@fe928000 {
> - compatible = "renesas,vsp1";
> - reg = <0 0xfe928000 0 0x8000>;
> - interrupts = <0 267 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <_clks R8A7790_CLK_VSP1_S>;
> - };
> diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml 
> b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> new file mode 100644
> index ..65e8ee61ce90
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> @@ -0,0 +1,83 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/renesas,vsp1.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas VSP Video Processing Engine
> +
> +maintainers:
> +  - Laurent Pinchart 
> +
> +description:
> +  The VSP is a video processing engine that supports up-/down-scaling, alpha
> +  blending, color space conversion and various other image processing 
> features.
> +  It can be found in the Renesas R-Car Gen2, R-Car Gen3, RZ/G1, and RZ/G2 
> SoCs.
> +
> +properties:
> +  compatible:
> +enum:
> +  - renesas,vsp1 # R-Car Gen2 and RZ/G1
> +  - renesas,vsp2 # R-Car Gen3 and RZ/G2
> +
> +  reg:
> +maxItems: 1
> +
> +  interrupts:
> +maxItems: 1
> +
> +  clocks:
> +maxItems: 1
> +
> +  renesas,fcp:
> +$ref: /schemas/types.yaml#/definitions/phandle
> +description:
> +  A phandle referencing the FCP that handles memory accesses for the VSP.
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +
> +additionalProperties: false
> +
> +if:
> +  properties:
> +compatible:
> +  items:
> +- const: renesas,vsp1
> +then:
> +  properties:
> +renesas,fcp: false
> +else:
> +  required:
> +- renesas,fcp
> +
> +examples:
> +  # R8A7790 (R-Car H2) VSP1-S
> +  - |
> +#include 
> +#include 
> +
> +vsp@fe928000 {
> +compatible = "renesas,vsp1";
> +reg = <0xfe928000 0x8000>;
> +interrupts = ;
> +clocks = < CPG_MOD 131>;
> +};
> +
> +  # R8A77951 (R-Car H3) VSP2-BC
> +  - |
> +#include 
> +#include 
> +
> +vsp@fe92 {
> +compatible = "renesas,vsp2";
> +reg = <0xfe92 0x8000>;
> +interrupts = ;
> +clocks = < CPG_MOD 624>;
> +
> +renesas,fcp = <>;
> +};
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7383dfa510a3..22e079cc3e3f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10730,7 +10730,7 @@ L:linux-me...@vger.kernel.org
>  L:   linux-renesas-...@vger.kernel.org
>  S:   Supported
>  T:   git git://linuxtv.org/media_tree.git
> -F:   Documentation/devicetree/bindings/media/renesas,vsp1.txt
> +F:   Documentation/devicetree/bindings/media/renesas,vsp1.yaml
>  F:   drivers/media/platform/vsp1/
>  
>  MEDIA DRIVERS FOR ST STV0910 DEMODULATOR ICs
> -- 
> Regards,
> 
> Laurent Pinchart
> 

-- 
Regards,
Niklas Söderlund