Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-10-10 Thread Noralf Trønnes 


Den 09.10.2019 15.31, skrev Maxime Ripard:
> On Wed, Oct 09, 2019 at 02:48:20PM +0200, Noralf Trønnes wrote:
>> Den 09.10.2019 12.45, skrev Daniel Vetter:
>>> On Tue, Oct 01, 2019 at 04:07:38PM +0200, Noralf Trønnes wrote:
 Hi drm-misc maintainers,

 I have just applied a patch to drm-misc-next that as it turns out should
 have been applied to -fixes for this -rc cycle.

 Should I cherry pick it to drm-misc-next-fixes?
>>>
>>> Yup, cherry pick and reference the commit that's already in -next (in case
>>> it creates conflicts down the road that reference makes the mess easier to
>>> understand).
>>>
>>
>> I remembered that Maxime just sent out a fixes pull and the subject says
>> drm-misc-fixes. The prevous one he sent out was -next-fixes.
>> So it looks like I should cherry pick to drm-misc-fixes for it to show
>> up in 5.4?
> 
> drm-misc-next-fixes is the branch where we gather fixes supposed to be
> applied on top of drm-misc-next during the merge window. If you have
> something targeting the current release, it should be drm-misc-fixes
> indeed.

Thanks, it's applied now.

Noralf.

> 
> Maxime
> 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-10-09 Thread Maxime Ripard 
On Wed, Oct 09, 2019 at 02:48:20PM +0200, Noralf Trønnes wrote:
> Den 09.10.2019 12.45, skrev Daniel Vetter:
> > On Tue, Oct 01, 2019 at 04:07:38PM +0200, Noralf Trønnes wrote:
> >> Hi drm-misc maintainers,
> >>
> >> I have just applied a patch to drm-misc-next that as it turns out should
> >> have been applied to -fixes for this -rc cycle.
> >>
> >> Should I cherry pick it to drm-misc-next-fixes?
> >
> > Yup, cherry pick and reference the commit that's already in -next (in case
> > it creates conflicts down the road that reference makes the mess easier to
> > understand).
> >
>
> I remembered that Maxime just sent out a fixes pull and the subject says
> drm-misc-fixes. The prevous one he sent out was -next-fixes.
> So it looks like I should cherry pick to drm-misc-fixes for it to show
> up in 5.4?

drm-misc-next-fixes is the branch where we gather fixes supposed to be
applied on top of drm-misc-next during the merge window. If you have
something targeting the current release, it should be drm-misc-fixes
indeed.

Maxime


signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-10-09 Thread Noralf Trønnes 



Den 09.10.2019 12.45, skrev Daniel Vetter:
> On Tue, Oct 01, 2019 at 04:07:38PM +0200, Noralf Trønnes wrote:
>> Hi drm-misc maintainers,
>>
>> I have just applied a patch to drm-misc-next that as it turns out should
>> have been applied to -fixes for this -rc cycle.
>>
>> Should I cherry pick it to drm-misc-next-fixes?
> 
> Yup, cherry pick and reference the commit that's already in -next (in case
> it creates conflicts down the road that reference makes the mess easier to
> understand).
> 

I remembered that Maxime just sent out a fixes pull and the subject says
drm-misc-fixes. The prevous one he sent out was -next-fixes.
So it looks like I should cherry pick to drm-misc-fixes for it to show
up in 5.4?

Noralf.

>> (I know there's a flowchart in the docs but I've never really understood
>> it.)
> 
> Usually bugfixes for kernel releases should land in drm-misc-next-fixes or
> drm-misc-fixes. But cherry-picking over in case of mistakes is ok too.
> -Daniel
> 
>>
>> Noralf.
>>
>> Den 01.10.2019 15.45, skrev Jason Gunthorpe:
>>> On Tue, Oct 01, 2019 at 03:28:46PM +0200, Noralf Trønnes wrote:


 Den 01.10.2019 14.36, skrev Jason Gunthorpe:
> On Thu, Jul 25, 2019 at 12:51:30PM +0200, Noralf Trønnes wrote:
>> This makes the tiny drivers visible by default without having to enable a
>> knob.
>>
>> Signed-off-by: Noralf Trønnes 
>> Reviewed-by: Hans de Goede  to it once
>>  drivers/gpu/drm/Makefile|  2 +-
>>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++--
>>  2 files changed, 22 insertions(+), 17 deletions(-)
>
> Bisection says this patch (28c47e16ea2a19adb47fe2c182cbd61cb854237c)
> breaks kconfig stuff in v5.4-rc by creating circular
> dependencies. Could someone send a -rc patch to fix this please?
>
> THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with 
> definition...
> ...depends on FB_SSD1307 (defined at drivers/video/fbdev/Kconfig:2259), 
> with definition...
> ...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with 
> definition...
> ...depends on DRM_KMS_FB_HELPER (defined at drivers/gpu/drm/Kconfig:79), 
> with definition...
> ...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), 
> with definition...
> ...depends on TINYDRM_REPAPER (defined at 
> drivers/gpu/drm/tinydrm/Kconfig:51), with definition...
> ...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with 
> definition...
> ...depends on SENSORS_NPCM7XX (defined at drivers/hwmon/Kconfig:1285), 
> with definition...
> ...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with 
> definition...
> ...depends on THINKPAD_ACPI (defined at 
> drivers/platform/x86/Kconfig:484), with definition...
> ...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with 
> definition...
> ...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with 
> definition...
> ...depends on BACKLIGHT_CLASS_DEVICE (defined at 
> drivers/video/backlight/Kconfig:144), with definition...
> ...depends again on THINKPAD_ACPI (defined at 
> drivers/platform/x86/Kconfig:484)
>

 Would this commit fix this by any chance:

 drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER
 https://cgit.freedesktop.org/drm/drm-misc/commit/?id=dfef959803c728c616ad29b008cd91b3446a993a
>>>
>>> Yes, thank you, can someone send this to -rc to unbreak 5.4?
>>>
>>> Jason
>>>
>

Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-10-09 Thread Daniel Vetter 
On Tue, Oct 01, 2019 at 04:07:38PM +0200, Noralf Trønnes wrote:
> Hi drm-misc maintainers,
> 
> I have just applied a patch to drm-misc-next that as it turns out should
> have been applied to -fixes for this -rc cycle.
> 
> Should I cherry pick it to drm-misc-next-fixes?

Yup, cherry pick and reference the commit that's already in -next (in case
it creates conflicts down the road that reference makes the mess easier to
understand).

> (I know there's a flowchart in the docs but I've never really understood
> it.)

Usually bugfixes for kernel releases should land in drm-misc-next-fixes or
drm-misc-fixes. But cherry-picking over in case of mistakes is ok too.
-Daniel

> 
> Noralf.
> 
> Den 01.10.2019 15.45, skrev Jason Gunthorpe:
> > On Tue, Oct 01, 2019 at 03:28:46PM +0200, Noralf Trønnes wrote:
> >>
> >>
> >> Den 01.10.2019 14.36, skrev Jason Gunthorpe:
> >>> On Thu, Jul 25, 2019 at 12:51:30PM +0200, Noralf Trønnes wrote:
>  This makes the tiny drivers visible by default without having to enable a
>  knob.
> 
>  Signed-off-by: Noralf Trønnes 
>  Reviewed-by: Hans de Goede  to it once
>   drivers/gpu/drm/Makefile|  2 +-
>   drivers/gpu/drm/tinydrm/Kconfig | 37 +++--
>   2 files changed, 22 insertions(+), 17 deletions(-)
> >>>
> >>> Bisection says this patch (28c47e16ea2a19adb47fe2c182cbd61cb854237c)
> >>> breaks kconfig stuff in v5.4-rc by creating circular
> >>> dependencies. Could someone send a -rc patch to fix this please?
> >>>
> >>> THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with 
> >>> definition...
> >>> ...depends on FB_SSD1307 (defined at drivers/video/fbdev/Kconfig:2259), 
> >>> with definition...
> >>> ...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with 
> >>> definition...
> >>> ...depends on DRM_KMS_FB_HELPER (defined at drivers/gpu/drm/Kconfig:79), 
> >>> with definition...
> >>> ...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), 
> >>> with definition...
> >>> ...depends on TINYDRM_REPAPER (defined at 
> >>> drivers/gpu/drm/tinydrm/Kconfig:51), with definition...
> >>> ...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with 
> >>> definition...
> >>> ...depends on SENSORS_NPCM7XX (defined at drivers/hwmon/Kconfig:1285), 
> >>> with definition...
> >>> ...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with 
> >>> definition...
> >>> ...depends on THINKPAD_ACPI (defined at 
> >>> drivers/platform/x86/Kconfig:484), with definition...
> >>> ...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with 
> >>> definition...
> >>> ...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with 
> >>> definition...
> >>> ...depends on BACKLIGHT_CLASS_DEVICE (defined at 
> >>> drivers/video/backlight/Kconfig:144), with definition...
> >>> ...depends again on THINKPAD_ACPI (defined at 
> >>> drivers/platform/x86/Kconfig:484)
> >>>
> >>
> >> Would this commit fix this by any chance:
> >>
> >> drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER
> >> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=dfef959803c728c616ad29b008cd91b3446a993a
> > 
> > Yes, thank you, can someone send this to -rc to unbreak 5.4?
> > 
> > Jason
> > 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-10-01 Thread Noralf Trønnes 
Hi drm-misc maintainers,

I have just applied a patch to drm-misc-next that as it turns out should
have been applied to -fixes for this -rc cycle.

Should I cherry pick it to drm-misc-next-fixes?
(I know there's a flowchart in the docs but I've never really understood
it.)

Noralf.

Den 01.10.2019 15.45, skrev Jason Gunthorpe:
> On Tue, Oct 01, 2019 at 03:28:46PM +0200, Noralf Trønnes wrote:
>>
>>
>> Den 01.10.2019 14.36, skrev Jason Gunthorpe:
>>> On Thu, Jul 25, 2019 at 12:51:30PM +0200, Noralf Trønnes wrote:
 This makes the tiny drivers visible by default without having to enable a
 knob.

 Signed-off-by: Noralf Trønnes 
 Reviewed-by: Hans de Goede  to it once
  drivers/gpu/drm/Makefile|  2 +-
  drivers/gpu/drm/tinydrm/Kconfig | 37 +++--
  2 files changed, 22 insertions(+), 17 deletions(-)
>>>
>>> Bisection says this patch (28c47e16ea2a19adb47fe2c182cbd61cb854237c)
>>> breaks kconfig stuff in v5.4-rc by creating circular
>>> dependencies. Could someone send a -rc patch to fix this please?
>>>
>>> THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with 
>>> definition...
>>> ...depends on FB_SSD1307 (defined at drivers/video/fbdev/Kconfig:2259), 
>>> with definition...
>>> ...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with 
>>> definition...
>>> ...depends on DRM_KMS_FB_HELPER (defined at drivers/gpu/drm/Kconfig:79), 
>>> with definition...
>>> ...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), with 
>>> definition...
>>> ...depends on TINYDRM_REPAPER (defined at 
>>> drivers/gpu/drm/tinydrm/Kconfig:51), with definition...
>>> ...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with 
>>> definition...
>>> ...depends on SENSORS_NPCM7XX (defined at drivers/hwmon/Kconfig:1285), with 
>>> definition...
>>> ...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with definition...
>>> ...depends on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), 
>>> with definition...
>>> ...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with 
>>> definition...
>>> ...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with 
>>> definition...
>>> ...depends on BACKLIGHT_CLASS_DEVICE (defined at 
>>> drivers/video/backlight/Kconfig:144), with definition...
>>> ...depends again on THINKPAD_ACPI (defined at 
>>> drivers/platform/x86/Kconfig:484)
>>>
>>
>> Would this commit fix this by any chance:
>>
>> drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER
>> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=dfef959803c728c616ad29b008cd91b3446a993a
> 
> Yes, thank you, can someone send this to -rc to unbreak 5.4?
> 
> Jason
>

Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-10-01 Thread Jason Gunthorpe 
On Tue, Oct 01, 2019 at 03:28:46PM +0200, Noralf Trønnes wrote:
> 
> 
> Den 01.10.2019 14.36, skrev Jason Gunthorpe:
> > On Thu, Jul 25, 2019 at 12:51:30PM +0200, Noralf Trønnes wrote:
> >> This makes the tiny drivers visible by default without having to enable a
> >> knob.
> >>
> >> Signed-off-by: Noralf Trønnes 
> >> Reviewed-by: Hans de Goede  to it once
> >>  drivers/gpu/drm/Makefile|  2 +-
> >>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++--
> >>  2 files changed, 22 insertions(+), 17 deletions(-)
> > 
> > Bisection says this patch (28c47e16ea2a19adb47fe2c182cbd61cb854237c)
> > breaks kconfig stuff in v5.4-rc by creating circular
> > dependencies. Could someone send a -rc patch to fix this please?
> > 
> > THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with 
> > definition...
> > ...depends on FB_SSD1307 (defined at drivers/video/fbdev/Kconfig:2259), 
> > with definition...
> > ...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with 
> > definition...
> > ...depends on DRM_KMS_FB_HELPER (defined at drivers/gpu/drm/Kconfig:79), 
> > with definition...
> > ...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), with 
> > definition...
> > ...depends on TINYDRM_REPAPER (defined at 
> > drivers/gpu/drm/tinydrm/Kconfig:51), with definition...
> > ...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with 
> > definition...
> > ...depends on SENSORS_NPCM7XX (defined at drivers/hwmon/Kconfig:1285), with 
> > definition...
> > ...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with definition...
> > ...depends on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), 
> > with definition...
> > ...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with 
> > definition...
> > ...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with 
> > definition...
> > ...depends on BACKLIGHT_CLASS_DEVICE (defined at 
> > drivers/video/backlight/Kconfig:144), with definition...
> > ...depends again on THINKPAD_ACPI (defined at 
> > drivers/platform/x86/Kconfig:484)
> > 
> 
> Would this commit fix this by any chance:
> 
> drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER
> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=dfef959803c728c616ad29b008cd91b3446a993a

Yes, thank you, can someone send this to -rc to unbreak 5.4?

Jason

Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-10-01 Thread Noralf Trønnes 


Den 01.10.2019 14.36, skrev Jason Gunthorpe:
> On Thu, Jul 25, 2019 at 12:51:30PM +0200, Noralf Trønnes wrote:
>> This makes the tiny drivers visible by default without having to enable a
>> knob.
>>
>> Signed-off-by: Noralf Trønnes 
>> Reviewed-by: Hans de Goede  to it once
>> ---
>>  drivers/gpu/drm/Makefile|  2 +-
>>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++--
>>  2 files changed, 22 insertions(+), 17 deletions(-)
> 
> Bisection says this patch (28c47e16ea2a19adb47fe2c182cbd61cb854237c)
> breaks kconfig stuff in v5.4-rc by creating circular
> dependencies. Could someone send a -rc patch to fix this please?
> 
> THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with 
> definition...
> ...depends on FB_SSD1307 (defined at drivers/video/fbdev/Kconfig:2259), with 
> definition...
> ...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with 
> definition...
> ...depends on DRM_KMS_FB_HELPER (defined at drivers/gpu/drm/Kconfig:79), with 
> definition...
> ...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), with 
> definition...
> ...depends on TINYDRM_REPAPER (defined at 
> drivers/gpu/drm/tinydrm/Kconfig:51), with definition...
> ...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with 
> definition...
> ...depends on SENSORS_NPCM7XX (defined at drivers/hwmon/Kconfig:1285), with 
> definition...
> ...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with definition...
> ...depends on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), 
> with definition...
> ...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with 
> definition...
> ...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with 
> definition...
> ...depends on BACKLIGHT_CLASS_DEVICE (defined at 
> drivers/video/backlight/Kconfig:144), with definition...
> ...depends again on THINKPAD_ACPI (defined at 
> drivers/platform/x86/Kconfig:484)
> 

Would this commit fix this by any chance:

drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=dfef959803c728c616ad29b008cd91b3446a993a

Noralf.

> Full output:
> 
> kconfiglib.KconfigError: 
> Dependency loop
> ===
> 
> THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with 
> definition...
> 
> config THINKPAD_ACPI
>   tristate "ThinkPad ACPI Laptop Extras"
>   select HWMON
>   select NVRAM
>   select NEW_LEDS
>   select LEDS_CLASS
>   select LEDS_TRIGGERS
>   select LEDS_TRIGGER_AUDIO
>   depends on ACPI && ACPI_BATTERY && INPUT && (RFKILL || RFKILL = n) && 
> (ACPI_VIDEO || ACPI_VIDEO = n) && BACKLIGHT_CLASS_DEVICE && 
> X86_PLATFORM_DEVICES && X86
>   help
> This is a driver for the IBM and Lenovo ThinkPad laptops. It adds
> support for Fn-Fx key combinations, Bluetooth control, video
> output switching, ThinkLight control, UltraBay eject and more.
> For more information about this driver see
>  and
>  .
> 
> This driver was formerly known as ibm-acpi.
> 
> Extra functionality will be available if the rfkill (CONFIG_RFKILL)
> and/or ALSA (CONFIG_SND) subsystems are available in the kernel.
> Note that if you want ThinkPad-ACPI to be built-in instead of
> modular, ALSA and rfkill will also have to be built-in.
> 
> If you have an IBM or Lenovo ThinkPad laptop, say Y or M here.
> 
> ...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with 
> definition...
> 
> config ACPI_VIDEO
>   tristate "Video"
>   select THERMAL
>   depends on X86 && BACKLIGHT_CLASS_DEVICE && INPUT && ACPI
>   help
> This driver implements the ACPI Extensions For Display Adapters
> for integrated graphics devices on motherboard, as specified in
> ACPI 2.0 Specification, Appendix B.  This supports basic operations
> such as defining the video POST device, retrieving EDID information,
> and setting up a video output.
> 
> To compile this driver as a module, choose M here:
> the module will be called video.
> 
> (select-related dependencies: (DRM_NOUVEAU && ACPI && X86 && 
> BACKLIGHT_CLASS_DEVICE && INPUT && DRM && PCI && MMU && HAS_IOMEM) || 
> (DRM_NOUVEAU && ACPI && X86 && DRM && PCI && MMU && HAS_IOMEM) || (DRM_I915 
> && ACPI && DRM && X86 && PCI && HAS_IOMEM) || (DRM_GMA500 && ACPI && DRM && 
> PCI && X86 && MMU && HAS_IOMEM) || (ACER_WMI && ACPI && ACPI && 
> BACKLIGHT_CLASS_DEVICE && SERIO_I8042 && INPUT && (RFKILL || RFKILL = n) && 
> ACPI_WMI && X86_PLATFORM_DEVICES && X86))
> 
> ...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with 
> definition...
> 
> config ACER_WMI
>   tristate "Acer WMI Laptop Extras"
>   select LEDS_CLASS
>   select NEW_LEDS
>   select INPUT_SPARSEKMAP
>   select ACPI_VIDEO if ACPI

Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-10-01 Thread Jason Gunthorpe 
On Thu, Jul 25, 2019 at 12:51:30PM +0200, Noralf Trønnes wrote:
> This makes the tiny drivers visible by default without having to enable a
> knob.
> 
> Signed-off-by: Noralf Trønnes 
> Reviewed-by: Hans de Goede  to it once
> ---
>  drivers/gpu/drm/Makefile|  2 +-
>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++--
>  2 files changed, 22 insertions(+), 17 deletions(-)

Bisection says this patch (28c47e16ea2a19adb47fe2c182cbd61cb854237c)
breaks kconfig stuff in v5.4-rc by creating circular
dependencies. Could someone send a -rc patch to fix this please?

THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
...depends on FB_SSD1307 (defined at drivers/video/fbdev/Kconfig:2259), with 
definition...
...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with definition...
...depends on DRM_KMS_FB_HELPER (defined at drivers/gpu/drm/Kconfig:79), with 
definition...
...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), with 
definition...
...depends on TINYDRM_REPAPER (defined at drivers/gpu/drm/tinydrm/Kconfig:51), 
with definition...
...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with definition...
...depends on SENSORS_NPCM7XX (defined at drivers/hwmon/Kconfig:1285), with 
definition...
...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with definition...
...depends on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with 
definition...
...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with 
definition...
...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with 
definition...
...depends on BACKLIGHT_CLASS_DEVICE (defined at 
drivers/video/backlight/Kconfig:144), with definition...
...depends again on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484)

Full output:

kconfiglib.KconfigError: 
Dependency loop
===

THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...

config THINKPAD_ACPI
tristate "ThinkPad ACPI Laptop Extras"
select HWMON
select NVRAM
select NEW_LEDS
select LEDS_CLASS
select LEDS_TRIGGERS
select LEDS_TRIGGER_AUDIO
depends on ACPI && ACPI_BATTERY && INPUT && (RFKILL || RFKILL = n) && 
(ACPI_VIDEO || ACPI_VIDEO = n) && BACKLIGHT_CLASS_DEVICE && 
X86_PLATFORM_DEVICES && X86
help
  This is a driver for the IBM and Lenovo ThinkPad laptops. It adds
  support for Fn-Fx key combinations, Bluetooth control, video
  output switching, ThinkLight control, UltraBay eject and more.
  For more information about this driver see
   and
   .
  
  This driver was formerly known as ibm-acpi.
  
  Extra functionality will be available if the rfkill (CONFIG_RFKILL)
  and/or ALSA (CONFIG_SND) subsystems are available in the kernel.
  Note that if you want ThinkPad-ACPI to be built-in instead of
  modular, ALSA and rfkill will also have to be built-in.
  
  If you have an IBM or Lenovo ThinkPad laptop, say Y or M here.

...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with 
definition...

config ACPI_VIDEO
tristate "Video"
select THERMAL
depends on X86 && BACKLIGHT_CLASS_DEVICE && INPUT && ACPI
help
  This driver implements the ACPI Extensions For Display Adapters
  for integrated graphics devices on motherboard, as specified in
  ACPI 2.0 Specification, Appendix B.  This supports basic operations
  such as defining the video POST device, retrieving EDID information,
  and setting up a video output.
  
  To compile this driver as a module, choose M here:
  the module will be called video.

(select-related dependencies: (DRM_NOUVEAU && ACPI && X86 && 
BACKLIGHT_CLASS_DEVICE && INPUT && DRM && PCI && MMU && HAS_IOMEM) || 
(DRM_NOUVEAU && ACPI && X86 && DRM && PCI && MMU && HAS_IOMEM) || (DRM_I915 && 
ACPI && DRM && X86 && PCI && HAS_IOMEM) || (DRM_GMA500 && ACPI && DRM && PCI && 
X86 && MMU && HAS_IOMEM) || (ACER_WMI && ACPI && ACPI && BACKLIGHT_CLASS_DEVICE 
&& SERIO_I8042 && INPUT && (RFKILL || RFKILL = n) && ACPI_WMI && 
X86_PLATFORM_DEVICES && X86))

...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with 
definition...

config ACER_WMI
tristate "Acer WMI Laptop Extras"
select LEDS_CLASS
select NEW_LEDS
select INPUT_SPARSEKMAP
select ACPI_VIDEO if ACPI
depends on ACPI && BACKLIGHT_CLASS_DEVICE && SERIO_I8042 && INPUT && 
(RFKILL || RFKILL = n) && ACPI_WMI && X86_PLATFORM_DEVICES && X86
help
  This is a driver for newer Acer (and Wistron) laptops. It adds
  wireless radio and bluetooth control, and on some laptops,
  exposes the mail LED and LCD backlight.
  
  If you have an ACPI-WMI compatible

Re: [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-07-30 Thread Emil Velikov 
On 2019/07/30, Noralf Trønnes wrote:
> 
> 
> Den 30.07.2019 15.53, skrev Emil Velikov:
> > On 2019/07/25, Noralf Trønnes wrote:
> >> This makes the tiny drivers visible by default without having to enable a
> >> knob.
> >>
> >> Signed-off-by: Noralf Trønnes 
> >> ---
> >>  drivers/gpu/drm/Makefile|  2 +-
> >>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++--
> >>  2 files changed, 22 insertions(+), 17 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> >> index 98c732f925c7..0b30afa7524d 100644
> >> --- a/drivers/gpu/drm/Makefile
> >> +++ b/drivers/gpu/drm/Makefile
> >> @@ -112,7 +112,7 @@ obj-$(CONFIG_DRM_ARCPGU)+= arc/
> >>  obj-y += hisilicon/
> >>  obj-$(CONFIG_DRM_ZTE) += zte/
> >>  obj-$(CONFIG_DRM_MXSFB)   += mxsfb/
> >> -obj-$(CONFIG_DRM_TINYDRM) += tinydrm/
> >> +obj-y += tinydrm/
> >>  obj-$(CONFIG_DRM_PL111) += pl111/
> >>  obj-$(CONFIG_DRM_TVE200) += tve200/
> >>  obj-$(CONFIG_DRM_XEN) += xen/
> >> diff --git a/drivers/gpu/drm/tinydrm/Kconfig 
> >> b/drivers/gpu/drm/tinydrm/Kconfig
> >> index 42b06f4f8989..f8c9a0e71dde 100644
> >> --- a/drivers/gpu/drm/tinydrm/Kconfig
> >> +++ b/drivers/gpu/drm/tinydrm/Kconfig
> >> @@ -1,16 +1,9 @@
> >>  # SPDX-License-Identifier: GPL-2.0-only
> >> -menuconfig DRM_TINYDRM
> >> -  tristate "Support for simple displays"
> >> -  depends on DRM
> >> -  select DRM_KMS_HELPER
> >> -  select DRM_KMS_CMA_HELPER
> >> -  help
> >> -Choose this option if you have a tinydrm supported display.
> >> -If M is selected the module will be called tinydrm.
> >> -
> > Fwiw I would have gone with Han's idea of making this hidden. That has a
> > number of advantages, even if we don't have a separate tinydrm.ko:
> >  - the tinydrm code is not build when there are no users
> 
> The thing is, there is no tinydrm code anymore, it's all been put into
> various core helpers. The folder does only contain regular DRM drivers.
> The only thing special about them is that they fit into one source file.

Right, I saw your series killing tinydrm.ko [1] and missed see the
mipi-dbi.c move with commit 174102f4de230a1bf85e6ef2f8c83e50b3ba22c9

Thanks for the awesome work.
Emil

[1] https://patchwork.freedesktop.org/series/63811/
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-07-30 Thread Noralf Trønnes 


Den 30.07.2019 15.53, skrev Emil Velikov:
> On 2019/07/25, Noralf Trønnes wrote:
>> This makes the tiny drivers visible by default without having to enable a
>> knob.
>>
>> Signed-off-by: Noralf Trønnes 
>> ---
>>  drivers/gpu/drm/Makefile|  2 +-
>>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++--
>>  2 files changed, 22 insertions(+), 17 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
>> index 98c732f925c7..0b30afa7524d 100644
>> --- a/drivers/gpu/drm/Makefile
>> +++ b/drivers/gpu/drm/Makefile
>> @@ -112,7 +112,7 @@ obj-$(CONFIG_DRM_ARCPGU)+= arc/
>>  obj-y   += hisilicon/
>>  obj-$(CONFIG_DRM_ZTE)   += zte/
>>  obj-$(CONFIG_DRM_MXSFB) += mxsfb/
>> -obj-$(CONFIG_DRM_TINYDRM) += tinydrm/
>> +obj-y   += tinydrm/
>>  obj-$(CONFIG_DRM_PL111) += pl111/
>>  obj-$(CONFIG_DRM_TVE200) += tve200/
>>  obj-$(CONFIG_DRM_XEN) += xen/
>> diff --git a/drivers/gpu/drm/tinydrm/Kconfig 
>> b/drivers/gpu/drm/tinydrm/Kconfig
>> index 42b06f4f8989..f8c9a0e71dde 100644
>> --- a/drivers/gpu/drm/tinydrm/Kconfig
>> +++ b/drivers/gpu/drm/tinydrm/Kconfig
>> @@ -1,16 +1,9 @@
>>  # SPDX-License-Identifier: GPL-2.0-only
>> -menuconfig DRM_TINYDRM
>> -tristate "Support for simple displays"
>> -depends on DRM
>> -select DRM_KMS_HELPER
>> -select DRM_KMS_CMA_HELPER
>> -help
>> -  Choose this option if you have a tinydrm supported display.
>> -  If M is selected the module will be called tinydrm.
>> -
> Fwiw I would have gone with Han's idea of making this hidden. That has a
> number of advantages, even if we don't have a separate tinydrm.ko:
>  - the tinydrm code is not build when there are no users

The thing is, there is no tinydrm code anymore, it's all been put into
various core helpers. The folder does only contain regular DRM drivers.
The only thing special about them is that they fit into one source file.

Noralf.

>  - the tinydrm dependencies are contained within itself, instead of
> updating 5-10 individual drivers
> 
> That said, I won't get in the way if people like this approach ;-)
> 
> HTH
> -Emil
> 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-07-30 Thread Emil Velikov 
On 2019/07/25, Noralf Trønnes wrote:
> This makes the tiny drivers visible by default without having to enable a
> knob.
> 
> Signed-off-by: Noralf Trønnes 
> ---
>  drivers/gpu/drm/Makefile|  2 +-
>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++--
>  2 files changed, 22 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> index 98c732f925c7..0b30afa7524d 100644
> --- a/drivers/gpu/drm/Makefile
> +++ b/drivers/gpu/drm/Makefile
> @@ -112,7 +112,7 @@ obj-$(CONFIG_DRM_ARCPGU)+= arc/
>  obj-y+= hisilicon/
>  obj-$(CONFIG_DRM_ZTE)+= zte/
>  obj-$(CONFIG_DRM_MXSFB)  += mxsfb/
> -obj-$(CONFIG_DRM_TINYDRM) += tinydrm/
> +obj-y+= tinydrm/
>  obj-$(CONFIG_DRM_PL111) += pl111/
>  obj-$(CONFIG_DRM_TVE200) += tve200/
>  obj-$(CONFIG_DRM_XEN) += xen/
> diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tinydrm/Kconfig
> index 42b06f4f8989..f8c9a0e71dde 100644
> --- a/drivers/gpu/drm/tinydrm/Kconfig
> +++ b/drivers/gpu/drm/tinydrm/Kconfig
> @@ -1,16 +1,9 @@
>  # SPDX-License-Identifier: GPL-2.0-only
> -menuconfig DRM_TINYDRM
> - tristate "Support for simple displays"
> - depends on DRM
> - select DRM_KMS_HELPER
> - select DRM_KMS_CMA_HELPER
> - help
> -   Choose this option if you have a tinydrm supported display.
> -   If M is selected the module will be called tinydrm.
> -
Fwiw I would have gone with Han's idea of making this hidden. That has a
number of advantages, even if we don't have a separate tinydrm.ko:
 - the tinydrm code is not build when there are no users
 - the tinydrm dependencies are contained within itself, instead of
updating 5-10 individual drivers

That said, I won't get in the way if people like this approach ;-)

HTH
-Emil
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-07-30 Thread Hans de Goede 

Hi,

On 30-07-19 15:34, Noralf Trønnes wrote:



Den 30.07.2019 15.19, skrev Hans de Goede:

Hi,

On 25-07-19 12:51, Noralf Trønnes wrote:

This makes the tiny drivers visible by default without having to enable a
knob.

Signed-off-by: Noralf Trønnes 
---
   drivers/gpu/drm/Makefile    |  2 +-
   drivers/gpu/drm/tinydrm/Kconfig | 37 +++--
   2 files changed, 22 insertions(+), 17 deletions(-)

diff --git a/drivers/gpu/drm/tinydrm/Kconfig
b/drivers/gpu/drm/tinydrm/Kconfig
index 42b06f4f8989..f8c9a0e71dde 100644
--- a/drivers/gpu/drm/tinydrm/Kconfig
+++ b/drivers/gpu/drm/tinydrm/Kconfig
@@ -1,16 +1,9 @@
   # SPDX-License-Identifier: GPL-2.0-only
-menuconfig DRM_TINYDRM
-    tristate "Support for simple displays"
-    depends on DRM
-    select DRM_KMS_HELPER
-    select DRM_KMS_CMA_HELPER
-    help
-  Choose this option if you have a tinydrm supported display.
-  If M is selected the module will be called tinydrm.
-
   config TINYDRM_HX8357D
   tristate "DRM support for HX8357D display panels"
-    depends on DRM_TINYDRM && SPI
+    depends on DRM && SPI
+    select DRM_KMS_HELPER
+    select DRM_KMS_CMA_HELPER
   select DRM_MIPI_DBI
   select BACKLIGHT_CLASS_DEVICE
   help




drivers/gpu/drm/tinydrm/Makefile has:

obj-$(CONFIG_DRM_TINYDRM)   += core/

And AFAIK at least most of the drivers under drivers/gpu/drm/tinydrm
actually need the tinydrm-core.



This is gone in current drm-misc-next.
It went away with:
drm/tinydrm: Remove tinydrm.ko
https://patchwork.freedesktop.org/series/63811/


Ah I see.

Regards,

Hans

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-07-30 Thread Noralf Trønnes 


Den 30.07.2019 15.19, skrev Hans de Goede:
> Hi,
> 
> On 25-07-19 12:51, Noralf Trønnes wrote:
>> This makes the tiny drivers visible by default without having to enable a
>> knob.
>>
>> Signed-off-by: Noralf Trønnes 
>> ---
>>   drivers/gpu/drm/Makefile    |  2 +-
>>   drivers/gpu/drm/tinydrm/Kconfig | 37 +++--
>>   2 files changed, 22 insertions(+), 17 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/tinydrm/Kconfig
>> b/drivers/gpu/drm/tinydrm/Kconfig
>> index 42b06f4f8989..f8c9a0e71dde 100644
>> --- a/drivers/gpu/drm/tinydrm/Kconfig
>> +++ b/drivers/gpu/drm/tinydrm/Kconfig
>> @@ -1,16 +1,9 @@
>>   # SPDX-License-Identifier: GPL-2.0-only
>> -menuconfig DRM_TINYDRM
>> -    tristate "Support for simple displays"
>> -    depends on DRM
>> -    select DRM_KMS_HELPER
>> -    select DRM_KMS_CMA_HELPER
>> -    help
>> -  Choose this option if you have a tinydrm supported display.
>> -  If M is selected the module will be called tinydrm.
>> -
>>   config TINYDRM_HX8357D
>>   tristate "DRM support for HX8357D display panels"
>> -    depends on DRM_TINYDRM && SPI
>> +    depends on DRM && SPI
>> +    select DRM_KMS_HELPER
>> +    select DRM_KMS_CMA_HELPER
>>   select DRM_MIPI_DBI
>>   select BACKLIGHT_CLASS_DEVICE
>>   help
> 
> 
> 
> drivers/gpu/drm/tinydrm/Makefile has:
> 
> obj-$(CONFIG_DRM_TINYDRM)   += core/
> 
> And AFAIK at least most of the drivers under drivers/gpu/drm/tinydrm
> actually need the tinydrm-core.
> 

This is gone in current drm-misc-next.
It went away with:
drm/tinydrm: Remove tinydrm.ko
https://patchwork.freedesktop.org/series/63811/

Noralf.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-07-30 Thread Hans de Goede 

Hi,

On 25-07-19 12:51, Noralf Trønnes wrote:

This makes the tiny drivers visible by default without having to enable a
knob.

Signed-off-by: Noralf Trønnes 
---
  drivers/gpu/drm/Makefile|  2 +-
  drivers/gpu/drm/tinydrm/Kconfig | 37 +++--
  2 files changed, 22 insertions(+), 17 deletions(-)

diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tinydrm/Kconfig
index 42b06f4f8989..f8c9a0e71dde 100644
--- a/drivers/gpu/drm/tinydrm/Kconfig
+++ b/drivers/gpu/drm/tinydrm/Kconfig
@@ -1,16 +1,9 @@
  # SPDX-License-Identifier: GPL-2.0-only
-menuconfig DRM_TINYDRM
-   tristate "Support for simple displays"
-   depends on DRM
-   select DRM_KMS_HELPER
-   select DRM_KMS_CMA_HELPER
-   help
- Choose this option if you have a tinydrm supported display.
- If M is selected the module will be called tinydrm.
-
  config TINYDRM_HX8357D
tristate "DRM support for HX8357D display panels"
-   depends on DRM_TINYDRM && SPI
+   depends on DRM && SPI
+   select DRM_KMS_HELPER
+   select DRM_KMS_CMA_HELPER
select DRM_MIPI_DBI
select BACKLIGHT_CLASS_DEVICE
help




drivers/gpu/drm/tinydrm/Makefile has:

obj-$(CONFIG_DRM_TINYDRM)   += core/

And AFAIK at least most of the drivers under drivers/gpu/drm/tinydrm
actually need the tinydrm-core.

So instead you should make the config option a hidden one
and select it in all the drivers which need it, otherwise
things will no longer work after a clean build AFAICT.

Note that even though the config option now remains, this change:

> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> index 98c732f925c7..0b30afa7524d 100644
> --- a/drivers/gpu/drm/Makefile
> +++ b/drivers/gpu/drm/Makefile
> @@ -112,7 +112,7 @@ obj-$(CONFIG_DRM_ARCPGU)+= arc/
>   obj-y+= hisilicon/
>   obj-$(CONFIG_DRM_ZTE)+= zte/
>   obj-$(CONFIG_DRM_MXSFB)  += mxsfb/
> -obj-$(CONFIG_DRM_TINYDRM) += tinydrm/
> +obj-y += tinydrm/
>   obj-$(CONFIG_DRM_PL111) += pl111/
>   obj-$(CONFIG_DRM_TVE200) += tve200/
>   obj-$(CONFIG_DRM_XEN) += xen/

Is still necessary so that when other drivers which do not
depend on the tinydrm core and thus will not do:
select DRM_TINYDRM
will still get build.

Otherwise this series looks good to me and you can add my:

Reviewed-by: Hans de Goede  to it once
this is fixed.

Note that drivers/gpu/drm/cirrus is a single .c file tiny
driver now a days too, so it too could be moved to the new
tiny dir. I was actually planning on doing something similar
to this series once I got one more tiny driver upstream :)

Regards,

Hans
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-07-25 Thread Noralf Trønnes 
This makes the tiny drivers visible by default without having to enable a
knob.

Signed-off-by: Noralf Trønnes 
---
 drivers/gpu/drm/Makefile|  2 +-
 drivers/gpu/drm/tinydrm/Kconfig | 37 +++--
 2 files changed, 22 insertions(+), 17 deletions(-)

diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
index 98c732f925c7..0b30afa7524d 100644
--- a/drivers/gpu/drm/Makefile
+++ b/drivers/gpu/drm/Makefile
@@ -112,7 +112,7 @@ obj-$(CONFIG_DRM_ARCPGU)+= arc/
 obj-y  += hisilicon/
 obj-$(CONFIG_DRM_ZTE)  += zte/
 obj-$(CONFIG_DRM_MXSFB)+= mxsfb/
-obj-$(CONFIG_DRM_TINYDRM) += tinydrm/
+obj-y  += tinydrm/
 obj-$(CONFIG_DRM_PL111) += pl111/
 obj-$(CONFIG_DRM_TVE200) += tve200/
 obj-$(CONFIG_DRM_XEN) += xen/
diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tinydrm/Kconfig
index 42b06f4f8989..f8c9a0e71dde 100644
--- a/drivers/gpu/drm/tinydrm/Kconfig
+++ b/drivers/gpu/drm/tinydrm/Kconfig
@@ -1,16 +1,9 @@
 # SPDX-License-Identifier: GPL-2.0-only
-menuconfig DRM_TINYDRM
-   tristate "Support for simple displays"
-   depends on DRM
-   select DRM_KMS_HELPER
-   select DRM_KMS_CMA_HELPER
-   help
- Choose this option if you have a tinydrm supported display.
- If M is selected the module will be called tinydrm.
-
 config TINYDRM_HX8357D
tristate "DRM support for HX8357D display panels"
-   depends on DRM_TINYDRM && SPI
+   depends on DRM && SPI
+   select DRM_KMS_HELPER
+   select DRM_KMS_CMA_HELPER
select DRM_MIPI_DBI
select BACKLIGHT_CLASS_DEVICE
help
@@ -21,7 +14,9 @@ config TINYDRM_HX8357D
 
 config TINYDRM_ILI9225
tristate "DRM support for ILI9225 display panels"
-   depends on DRM_TINYDRM && SPI
+   depends on DRM && SPI
+   select DRM_KMS_HELPER
+   select DRM_KMS_CMA_HELPER
select DRM_MIPI_DBI
help
  DRM driver for the following Ilitek ILI9225 panels:
@@ -31,7 +26,9 @@ config TINYDRM_ILI9225
 
 config TINYDRM_ILI9341
tristate "DRM support for ILI9341 display panels"
-   depends on DRM_TINYDRM && SPI
+   depends on DRM && SPI
+   select DRM_KMS_HELPER
+   select DRM_KMS_CMA_HELPER
select DRM_MIPI_DBI
select BACKLIGHT_CLASS_DEVICE
help
@@ -42,7 +39,9 @@ config TINYDRM_ILI9341
 
 config TINYDRM_MI0283QT
tristate "DRM support for MI0283QT"
-   depends on DRM_TINYDRM && SPI
+   depends on DRM && SPI
+   select DRM_KMS_HELPER
+   select DRM_KMS_CMA_HELPER
select DRM_MIPI_DBI
select BACKLIGHT_CLASS_DEVICE
help
@@ -51,7 +50,9 @@ config TINYDRM_MI0283QT
 
 config TINYDRM_REPAPER
tristate "DRM support for Pervasive Displays RePaper panels (V231)"
-   depends on DRM_TINYDRM && SPI
+   depends on DRM && SPI
+   select DRM_KMS_HELPER
+   select DRM_KMS_CMA_HELPER
depends on THERMAL || !THERMAL
help
  DRM driver for the following Pervasive Displays panels:
@@ -64,7 +65,9 @@ config TINYDRM_REPAPER
 
 config TINYDRM_ST7586
tristate "DRM support for Sitronix ST7586 display panels"
-   depends on DRM_TINYDRM && SPI
+   depends on DRM && SPI
+   select DRM_KMS_HELPER
+   select DRM_KMS_CMA_HELPER
select DRM_MIPI_DBI
help
  DRM driver for the following Sitronix ST7586 panels:
@@ -74,7 +77,9 @@ config TINYDRM_ST7586
 
 config TINYDRM_ST7735R
tristate "DRM support for Sitronix ST7735R display panels"
-   depends on DRM_TINYDRM && SPI
+   depends on DRM && SPI
+   select DRM_KMS_HELPER
+   select DRM_KMS_CMA_HELPER
select DRM_MIPI_DBI
select BACKLIGHT_CLASS_DEVICE
help
-- 
2.20.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel