[Bug 90439] [LLVM] Xonotic render green (bisected)

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90439

smoki  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #14 from smoki  ---

 Patches mainlined. Closing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 90439] [LLVM] Xonotic render green (bisected)

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90439

--- Comment #13 from smoki  ---
(In reply to Tom Stellard from comment #12)
> Can you try this branch:
> http://cgit.freedesktop.org/~tstellar/llvm/log/?h=vinterp-fix

 Works fine, apps render fine and no piglit regression.

 With that mainlined, this one and bug 89034 can be marked as fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 90439] [LLVM] Xonotic render green (bisected)

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90439

--- Comment #12 from Tom Stellard  ---
Can you try this branch:
http://cgit.freedesktop.org/~tstellar/llvm/log/?h=vinterp-fix

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 90439] [LLVM] Xonotic render green (bisected)

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90439

--- Comment #11 from smoki  ---
(In reply to Michel Dänzer from comment #10)
> Created attachment 115965 [details] [review]
> Make sure v_interp_p1_f32 doesn't use the source register as destination
> 
> Does this proof-of-concept LLVM patch fix the problem?

 Bingo! That seems fixed everyting.

 On top of that also i can enable SubRegLiveness without a problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 90439] [LLVM] Xonotic render green (bisected)

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90439

--- Comment #10 from Michel Dänzer  ---
Created attachment 115965
  --> https://bugs.freedesktop.org/attachment.cgi?id=115965=edit
Make sure v_interp_p1_f32 doesn't use the source register as destination

Does this proof-of-concept LLVM patch fix the problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 90439] [LLVM] Xonotic render green (bisected)

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90439

--- Comment #9 from smoki  ---
Created attachment 115963
  --> https://bugs.freedesktop.org/attachment.cgi?id=115963=edit
fail


 fail on svn237140 attachment

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 90439] [LLVM] Xonotic render green (bisected)

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90439

--- Comment #8 from smoki  ---
Created attachment 115962
  --> https://bugs.freedesktop.org/attachment.cgi?id=115962=edit
pass

 Hi Tom, good and bad diff taken from glsl-fs-abs-03 test.

121,125c121,125
< v_interp_p1_f32 v4, v0, 2, 0, [m0]   ; C8100200
< v_interp_p2_f32 v4, [v4], v1, 2, 0, [m0] ; C8110201
< v_cvt_pkrtz_f16_f32_e64 v0, |v2|, |v3|   ; D25E0300 00020702
< v_cvt_pkrtz_f16_f32_e64 v1, |v4|, 1.0; D25E0101 0001E504
< exp 15, 0, 1, 1, 1, v0, v1, v0, v1   ; F8001C0F 01000100
---
>   v_interp_p1_f32 v0, v0, 2, 0, [m0]   ; C8000200
>   v_interp_p2_f32 v0, [v0], v1, 2, 0, [m0] ; C8010201
>   v_cvt_pkrtz_f16_f32_e64 v1, |v2|, |v3|   ; D25E0301 00020702
>   v_cvt_pkrtz_f16_f32_e64 v0, |v0|, 1.0; D25E0100 0001E500
>   exp 15, 0, 1, 1, 1, v1, v0, v1, v0   ; F8001C0F 00010001
130c130
< VGPRS: 8
---
> VGPRS: 4

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 90439] [LLVM] Xonotic render green (bisected)

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90439

--- Comment #7 from Tom Stellard  ---
Could you get good and bad dumps from the glsl-fs-abs-03 test ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 90439] [LLVM] Xonotic render green (bisected)

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90439

smoki  changed:

   What|Removed |Added

   Severity|normal  |critical

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 90439] [LLVM] Xonotic render green (bisected)

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90439

--- Comment #6 from smoki  ---
 Uploaded piglit comparison within these llvm commits

https://dl.dropboxusercontent.com/u/74553632/bug90439.tar.bz2

 So basicaly the same ~130 piglits fail, just like in bug 89034 if i enable
sub-reg liveness.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 90439] [LLVM] Xonotic render green (bisected)

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90439

--- Comment #5 from smoki  ---
Created attachment 115764
  --> https://bugs.freedesktop.org/attachment.cgi?id=115764=edit
piglit-bad

 and bad with r237140

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 90439] [LLVM] Xonotic render green (bisected)

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90439

--- Comment #4 from smoki  ---
Created attachment 115763
  --> https://bugs.freedesktop.org/attachment.cgi?id=115763=edit
piglit-good

 Yes, example output is from:

 R600_DEBUG=ps,vs,gs ./bin/copy-pixels -samples=8 -auto

 on r237139

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 90439] [LLVM] Xonotic render green (bisected)

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90439

--- Comment #3 from Michel Dänzer  ---
You said on IRC that the same commit also broke some piglit tests. If so,
please attach the good and bad R600_DEBUG=ps,vs,gs output for one of those.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 90439] [LLVM] Xonotic render green (bisected)

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90439

Michel Dänzer  changed:

   What|Removed |Added

Summary|Xonotic render green|[LLVM] Xonotic render green
   |(bisected)  |(bisected)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: