Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

Hi Bjorn Thanks for the comments. I will upload a new patch for this which will be dependent on https://patchwork.kernel.org/patch/10377537/ series. This series registers the backlight device we need. Thanks Abhinav On 2018-04-18 21:42, Bjorn Andersson wrote: On Wed 18 Apr 21:23 PDT

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

On Wed 18 Apr 21:23 PDT 2018, abhin...@codeaurora.org wrote: > Hi Bjorn > Hi Abhinav, > Thanks very much for the detailed response. > You're welcome. > Yes, we decided that userspace hardcoding this node name is not a > strong enough reason to register as another backlight device. > > Had

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

On Tue 17 Apr 17:04 PDT 2018, abhin...@codeaurora.org wrote: > Hi Bjorn > > Apologies if the prev reply wasnt clear. > > Hope this one is. > Much better, now we can discuss the actual issues :) > reply inline. > > On 2018-04-17 14:29, Bjorn Andersson wrote: > > On Tue 17 Apr 11:21 PDT 2018,

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

On Tue 17 Apr 17:42 PDT 2018, abhin...@codeaurora.org wrote: > Adding another point. > > On 2018-04-17 17:04, abhin...@codeaurora.org wrote: > > Hi Bjorn > > > > Apologies if the prev reply wasnt clear. > > > > Hope this one is. > > > > reply inline. > > > > On 2018-04-17 14:29, Bjorn

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

Hi Bjorn Thanks very much for the detailed response. Yes, we decided that userspace hardcoding this node name is not a strong enough reason to register as another backlight device. Had one follow up question though. The QC WLED driver, drivers/leds/leds-qpnp-wled.c is not registering

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

Thanks Daniel and Sean for your comments. Yes, the magic and algorithm is in userspace. After this discussion, it seems like the complexity of the userspace having to figure out which device node to use and to scale the backlight accordingly is not a strong enough reason to handle this in the

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

On Wed, Apr 18, 2018 at 11:52:18AM +0100, Daniel Thompson wrote: > On Tue, Apr 17, 2018 at 05:42:04PM -0700, abhin...@codeaurora.org wrote: > > Adding another point. > > > > On 2018-04-17 17:04, abhin...@codeaurora.org wrote: > > > Hi Bjorn > > > > > > Apologies if the prev reply wasnt clear. >

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

On Tue, Apr 17, 2018 at 05:04:56PM -0700, abhin...@codeaurora.org wrote: > Hi Bjorn > > Apologies if the prev reply wasnt clear. > > Hope this one is. > > reply inline. > > On 2018-04-17 14:29, Bjorn Andersson wrote: > > On Tue 17 Apr 11:21 PDT 2018, abhin...@codeaurora.org wrote: > > > On

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

On Tue, Apr 17, 2018 at 05:42:04PM -0700, abhin...@codeaurora.org wrote: > Adding another point. > > On 2018-04-17 17:04, abhin...@codeaurora.org wrote: > > Hi Bjorn > > > > Apologies if the prev reply wasnt clear. > > > > Hope this one is. > > > > reply inline. > > > > On 2018-04-17 14:29,

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

On Tue 17 Apr 11:21 PDT 2018, abhin...@codeaurora.org wrote: > On 2018-04-16 23:13, Bjorn Andersson wrote: [..] > > If the panel isn't actually a piece of backlight hardware then it should > > not register a backlight device. Why do you need your own sysfs? > > > > Regards, > > Bjorn > [Abhinav]

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

Testing my responsde On 04/17/2018 11:21 AM, abhin...@codeaurora.org wrote: Hi Bjorn Thanks for the comments. Reply inline. On 2018-04-16 23:13, Bjorn Andersson wrote: On Mon 16 Apr 15:45 PDT 2018, abhin...@codeaurora.org wrote: Hi Bjorn Thanks for the review. Reply inline. On

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

Adding another point. On 2018-04-17 17:04, abhin...@codeaurora.org wrote: Hi Bjorn Apologies if the prev reply wasnt clear. Hope this one is. reply inline. On 2018-04-17 14:29, Bjorn Andersson wrote: On Tue 17 Apr 11:21 PDT 2018, abhin...@codeaurora.org wrote: On 2018-04-16 23:13, Bjorn

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

Hi Bjorn Apologies if the prev reply wasnt clear. Hope this one is. reply inline. On 2018-04-17 14:29, Bjorn Andersson wrote: On Tue 17 Apr 11:21 PDT 2018, abhin...@codeaurora.org wrote: On 2018-04-16 23:13, Bjorn Andersson wrote: [..] > If the panel isn't actually a piece of backlight

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

Hi Bjorn Thanks for the comments. Reply inline. On 2018-04-16 23:13, Bjorn Andersson wrote: On Mon 16 Apr 15:45 PDT 2018, abhin...@codeaurora.org wrote: Hi Bjorn Thanks for the review. Reply inline. On 2018-04-16 09:41, Bjorn Andersson wrote: > On Sat 14 Apr 00:25 PDT 2018, Abhinav Kumar

Re: [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

On Sat 14 Apr 00:25 PDT 2018, Abhinav Kumar wrote: > Register truly panel as a backlight led device and > provide methods to control its backlight operation. > > Changes in v2: > - Removed redundant NULL checks > - Arranged headers alphabetically > - Formatting fixes The change log goes below

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

On Mon 16 Apr 15:45 PDT 2018, abhin...@codeaurora.org wrote: > Hi Bjorn > > Thanks for the review. > > Reply inline. > > On 2018-04-16 09:41, Bjorn Andersson wrote: > > On Sat 14 Apr 00:25 PDT 2018, Abhinav Kumar wrote: > > > > > Register truly panel as a backlight led device and > > >

Re: [Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

Hi Bjorn Thanks for the review. Reply inline. On 2018-04-16 09:41, Bjorn Andersson wrote: On Sat 14 Apr 00:25 PDT 2018, Abhinav Kumar wrote: Register truly panel as a backlight led device and provide methods to control its backlight operation. Changes in v2: - Removed redundant NULL checks

Re: [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

On Mon, Apr 16, 2018 at 12:41 PM Bjorn Andersson wrote: > On Sat 14 Apr 00:25 PDT 2018, Abhinav Kumar wrote: > > Register truly panel as a backlight led device and > > provide methods to control its backlight operation. > > > > Changes in v2: > > - Removed redundant

[DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

Register truly panel as a backlight led device and provide methods to control its backlight operation. Changes in v2: - Removed redundant NULL checks - Arranged headers alphabetically - Formatting fixes Signed-off-by: Abhinav Kumar ---