Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-17 Thread Ville Syrjälä
On Mon, Sep 16, 2013 at 06:48:53PM +0100, Damien Lespiau wrote: There are a few things to be flushed out if we want to allow multiple buffers stereo framebuffers: - What with drm_planes? what semantics do they follow, what is the hardware able to do with them? - How do we define which

Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-17 Thread Damien Lespiau
On Tue, Sep 17, 2013 at 11:20:46AM +0300, Ville Syrjälä wrote: +++ b/drivers/gpu/drm/drm_crtc.c @@ -2131,6 +2131,17 @@ int drm_mode_setcrtc(struct drm_device *dev, void *data, goto out; } + /* +* Do not allow the use of

Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-17 Thread Ville Syrjälä
On Tue, Sep 17, 2013 at 10:03:12AM +0100, Damien Lespiau wrote: On Tue, Sep 17, 2013 at 11:20:46AM +0300, Ville Syrjälä wrote: +++ b/drivers/gpu/drm/drm_crtc.c @@ -2131,6 +2131,17 @@ int drm_mode_setcrtc(struct drm_device *dev, void *data, goto out; }

Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-17 Thread Daniel Vetter
On Tue, Sep 17, 2013 at 12:54:09PM +0300, Ville Syrjälä wrote: On Tue, Sep 17, 2013 at 10:03:12AM +0100, Damien Lespiau wrote: On Tue, Sep 17, 2013 at 11:20:46AM +0300, Ville Syrjälä wrote: +++ b/drivers/gpu/drm/drm_crtc.c @@ -2131,6 +2131,17 @@ int drm_mode_setcrtc(struct drm_device

Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-17 Thread Ville Syrjälä
On Tue, Sep 17, 2013 at 12:37:48PM +0200, Daniel Vetter wrote: On Tue, Sep 17, 2013 at 12:54:09PM +0300, Ville Syrjälä wrote: On Tue, Sep 17, 2013 at 10:03:12AM +0100, Damien Lespiau wrote: On Tue, Sep 17, 2013 at 11:20:46AM +0300, Ville Syrjälä wrote: +++ b/drivers/gpu/drm/drm_crtc.c

Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-17 Thread Damien Lespiau
On Tue, Sep 17, 2013 at 12:37:48PM +0200, Daniel Vetter wrote: I guess we should start to check that. For 3d framebuffers with 2 separate buffer handles for each plane I think we need to add another flag to addfb2, e.g. #define DRM_MODE_FB_3D_2_FRAMES (11) /* separate left/right buffers,

Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-17 Thread Ville Syrjälä
On Tue, Sep 17, 2013 at 02:20:41PM +0100, Damien Lespiau wrote: On Tue, Sep 17, 2013 at 12:37:48PM +0200, Daniel Vetter wrote: I guess we should start to check that. For 3d framebuffers with 2 separate buffer handles for each plane I think we need to add another flag to addfb2, e.g.

Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-17 Thread Daniel Vetter
On Tue, Sep 17, 2013 at 3:20 PM, Damien Lespiau damien.lesp...@intel.com wrote: On Tue, Sep 17, 2013 at 12:37:48PM +0200, Daniel Vetter wrote: I guess we should start to check that. For 3d framebuffers with 2 separate buffer handles for each plane I think we need to add another flag to addfb2,

Re: [Intel-gfx] [PATCH 10/12] drm: Don't allow multiple buffers fb with stereo modes

2013-09-17 Thread Daniel Vetter
On Tue, Sep 17, 2013 at 1:02 PM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: But the problem is that addfb2 can't supply more than 4. So we need a new ioctl if we want to collect all that information inside a single drm_fb object. If we do add another ioctl then I think we should go at