[Intel-gfx] Design review request: DRM color manager

2014-05-15 Thread Sharma, Shashank
What I understood from the reviews comments from the experts, is having a central color management at DRM kernel layer is not a good idea, and we should create individual DRM properties for the color correction methods, and let the control be there in the user space level, where an atomic

[Intel-gfx] Design review request: DRM color manager

2014-05-15 Thread Thierry Reding
On Thu, May 15, 2014 at 10:52:38AM +0530, Sharma, Shashank wrote: [...] > Please note that the color correction methods changes per platform and > what's valid for one Intel platform may not be valid for other. So the > atomic modeset should have a clear idea of what is supported on which >

[Intel-gfx] Design review request: DRM color manager

2014-05-15 Thread Sharma, Shashank
; Korjani, Vikas Subject: Re: [Intel-gfx] Design review request: DRM color manager On Thu, May 15, 2014 at 10:52:38AM +0530, Sharma, Shashank wrote: [...] > Please note that the color correction methods changes per platform and > what's valid for one Intel platform may not be valid for oth

[Intel-gfx] Design review request: DRM color manager

2014-05-14 Thread Thierry Reding
On Tue, May 13, 2014 at 09:18:45AM +0530, Sharma, Shashank wrote: > Daniel, > Please find my comments inline. > > Regards > Shashank > On 5/12/2014 8:58 PM, Daniel Vetter wrote: > >On Mon, May 12, 2014 at 05:35:13PM +0530, Sharma, Shashank wrote: > >>Thanks for your time and the comments David. >

[Intel-gfx] Design review request: DRM color manager

2014-05-13 Thread Sharma, Shashank
Daniel, Please find my comments inline. Regards Shashank On 5/12/2014 8:58 PM, Daniel Vetter wrote: > On Mon, May 12, 2014 at 05:35:13PM +0530, Sharma, Shashank wrote: >> Thanks for your time and the comments David. >> please find mine inline. >> >> Regards >> Shashank >> On 5/12/2014 5:20 PM,

[Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread David Herrmann
Hi On Mon, May 12, 2014 at 5:28 PM, Daniel Vetter wrote: > Those are all just reasons for atomic modeset and maybe an atomic modeget > ioctl which transfers the entire blob of things. Maybe we should start > with the atomic modeget to get things rolling. Otoh you can always do that > in

[Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread Sharma, Shashank
Thanks for your time and the comments David. please find mine inline. Regards Shashank On 5/12/2014 5:20 PM, David Herrmann wrote: > Hi > > On Mon, May 12, 2014 at 12:26 PM, Sharma, Shashank > wrote: >> Benefits of using color manager: >> >> 1. Unique framework

[Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread Daniel Vetter
On Mon, May 12, 2014 at 05:35:13PM +0530, Sharma, Shashank wrote: > Thanks for your time and the comments David. > please find mine inline. > > Regards > Shashank > On 5/12/2014 5:20 PM, David Herrmann wrote: > >Hi > > > >On Mon, May 12, 2014 at 12:26 PM, Sharma, Shashank > > wrote: > >>Benefits

[Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread Sharma, Shashank
form of data. >> >> Benefits of this common interface: >> -- >> - Single interface for all color properties. No need to create multiple >>properties. >> - HW agonist. Its in hands of driver to register the properties. >>

[Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread David Herrmann
Hi On Mon, May 12, 2014 at 12:26 PM, Sharma, Shashank wrote: > Benefits of using color manager: > > 1. Unique framework for all the color correction properties, across all >DRM drivers, across various platforms. > 2. Only one set/get call for all kind of

[Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread Daniel Vetter
eset implementations. > > > > > Regards > Shashank > > On 5/7/2014 7:41 PM, Sharma, Shashank wrote: >> >> FYI >> >> >> -Original Message- >> From: Sharma, Shashank >> Sent: Tuesday, April 22, 2014 8:32 PM >>

[Intel-gfx] Design review request: DRM color manager

2014-04-22 Thread Daniel Vetter
On Tue, Apr 22, 2014 at 12:07:41PM +, Sharma, Shashank wrote: > Thanks again David, > Comments inline. Three things: - Please don't send out .pptx files to upstream/public mailing lists, that's just not how the upstream community works. - Please either fix up ms outlook to do proper