Re: [Nouveau] [PATCH 3/3] nouveau/gsp: add some basic registry entries.

2023-11-27 Thread Dave Airlie
On Tue, 28 Nov 2023 at 06:48, Timur Tabi wrote: > > On Tue, Oct 31, 2023 at 12:20 AM Dave Airlie wrote: > > rpc->size = sizeof(*rpc); > > - rpc->numEntries = 1; > > - rpc->entries[0].nameOffset = offsetof(typeof(*rpc), entries[1]); > > - rpc->entries[0].type = 1; > > -

Re: [Nouveau] [PATCH 3/3] nouveau/gsp: add some basic registry entries.

2023-11-27 Thread Timur Tabi
On Tue, Oct 31, 2023 at 12:20 AM Dave Airlie wrote: > rpc->size = sizeof(*rpc); > - rpc->numEntries = 1; > - rpc->entries[0].nameOffset = offsetof(typeof(*rpc), entries[1]); > - rpc->entries[0].type = 1; > - rpc->entries[0].data = 0; > -

Re: [Nouveau] [PATCH 3/3] nouveau/gsp: add some basic registry entries.

2023-11-07 Thread Timur Tabi
On Wed, 2023-11-08 at 04:54 +1000, Dave Airlie wrote: yes that is probably the right answer for this, if we want to reuse the structs that we get from the nvidia driver. ok, I'll submit a patch.

Re: [Nouveau] [PATCH 3/3] nouveau/gsp: add some basic registry entries.

2023-11-07 Thread Dave Airlie
On Wed, 8 Nov 2023 at 04:51, Timur Tabi wrote: > > On Tue, 2023-10-31 at 15:18 +1000, Dave Airlie wrote: > > + strings = (char *)>entries[NV_GSP_REG_NUM_ENTRIES]; > > > I get a UBSAN index-out-of-bounds error on boot at this line. > > [ 17.765746] nouveau :65:00.0: gsp: cmdq: wptr 1 > [

Re: [Nouveau] [PATCH 3/3] nouveau/gsp: add some basic registry entries.

2023-11-07 Thread Timur Tabi
On Tue, 2023-10-31 at 15:18 +1000, Dave Airlie wrote: + strings = (char *)>entries[NV_GSP_REG_NUM_ENTRIES]; I get a UBSAN index-out-of-bounds error on boot at this line. [ 17.765746] nouveau :65:00.0: gsp: cmdq: wptr 1 [ 17.765748]

Re: [Nouveau] [PATCH 3/3] nouveau/gsp: add some basic registry entries.

2023-10-31 Thread Timur Tabi
On Wed, 2023-11-01 at 05:29 +1000, Dave Airlie wrote: > > > > static const struct nv_gsp_registry_entries r535_registry_entries[] = { > >     { "RMSecBusResetEnable", 1 }, > >     { "RMForcePcieConfigSave", 1 }, > > }; > > > > #define NV_GSP_REG_NUM_ENTRIES

Re: [Nouveau] [PATCH 3/3] nouveau/gsp: add some basic registry entries.

2023-10-31 Thread Dave Airlie
On Wed, 1 Nov 2023 at 01:53, Timur Tabi wrote: > > On Tue, Oct 31, 2023 at 12:20 AM Dave Airlie wrote: > > +#define NV_GSP_REG_NUM_ENTRIES 2 > > + > > +static const struct nv_gsp_registry_entries > > r535_registry_entries[NV_GSP_REG_NUM_ENTRIES] = { > > + { "RMSecBusResetEnable", 1 }, > >

Re: [Nouveau] [PATCH 3/3] nouveau/gsp: add some basic registry entries.

2023-10-31 Thread Timur Tabi
On Tue, Oct 31, 2023 at 12:20 AM Dave Airlie wrote: > +#define NV_GSP_REG_NUM_ENTRIES 2 > + > +static const struct nv_gsp_registry_entries > r535_registry_entries[NV_GSP_REG_NUM_ENTRIES] = { > + { "RMSecBusResetEnable", 1 }, > + { "RMForcePcieConfigSave", 1 }, > +}; How about :