Re: [PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes

2019-08-01 Thread Wang, Kevin(Yang) 



From: amd-gfx  on behalf of Colin King 

Sent: Thursday, August 1, 2019 4:39 PM
To: Rex Zhu ; Quan, Evan ; Deucher, 
Alexander ; Koenig, Christian 
; Zhou, David(ChunMing) ; David 
Airlie ; Daniel Vetter ; 
amd-...@lists.freedesktop.org ; 
dri-devel@lists.freedesktop.org 
Cc: kernel-janit...@vger.kernel.org ; 
linux-ker...@vger.kernel.org 
Subject: [PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes

From: Colin Ian King 

There are a few spelling mistakes "unknow" -> "unknown" and
"enabeld" -> "enabled". Fix these.

Signed-off-by: Colin Ian King 
---
 drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c 
b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
index 13b2c8a60232..d029a99e600e 100644
--- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
@@ -39,7 +39,7 @@ static const char* __smu_message_names[] = {
 const char *smu_get_message_name(struct smu_context *smu, enum 
smu_message_type type)
 {
 if (type < 0 || type > SMU_MSG_MAX_COUNT)
-   return "unknow smu message";
+   return "unknown smu message";
 return __smu_message_names[type];
 }

@@ -52,7 +52,7 @@ static const char* __smu_feature_names[] = {
 const char *smu_get_feature_name(struct smu_context *smu, enum 
smu_feature_mask feature)
 {
 if (feature < 0 || feature > SMU_FEATURE_COUNT)
-   return "unknow smu feature";
+   return "unknown smu feature";
 return __smu_feature_names[feature];
 }

@@ -79,7 +79,7 @@ size_t smu_sys_get_pp_feature_mask(struct smu_context *smu, 
char *buf)
count++,
smu_get_feature_name(smu, i),
feature_index,
-  !!smu_feature_is_enabled(smu, i) ? "enabeld" : 
"disabled");
+  !!smu_feature_is_enabled(smu, i) ? "enabled" : 
"disabled");
 }

[kevin]:
thanks correct it.
Reviewed-by: Kevin Wang 

BR
Kevin

 failed:
--
2.20.1

___
amd-gfx mailing list
amd-...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes

2019-08-01 Thread Joe Perches 
On Thu, 2019-08-01 at 15:02 -0400, Alex Deucher wrote:
> Applied.  thanks!
> 
> Alex
> 
> On Thu, Aug 1, 2019 at 4:39 AM Colin King  wrote:
> > From: Colin Ian King 
> > 
> > There are a few spelling mistakes "unknow" -> "unknown" and
> > "enabeld" -> "enabled". Fix these.
[]
> > diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c 
> > b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
[]
> > @@ -39,7 +39,7 @@ static const char* __smu_message_names[] = {
> >  const char *smu_get_message_name(struct smu_context *smu, enum 
> > smu_message_type type)
> >  {
> > if (type < 0 || type > SMU_MSG_MAX_COUNT)

This looks like an off-by-one test against
SMU_MSG_MAX_COUNT where type
should be >=

> > -   return "unknow smu message";
> > +   return "unknown smu message";
> > return __smu_message_names[type];
[]
> > @@ -52,7 +52,7 @@ static const char* __smu_feature_names[] = {
> >  const char *smu_get_feature_name(struct smu_context *smu, enum 
> > smu_feature_mask feature)
> >  {
> > if (feature < 0 || feature > SMU_FEATURE_COUNT)

here too

> > -   return "unknow smu feature";
> > +   return "unknown smu feature";
> > return __smu_feature_names[feature];

Perhaps instead it should be against ARRAY_SIZE(__smu_)

Also, the  __SMU_DUMMY_MAP macro is unnecessarily complex.

It might be better to have some direct
index and name struct like

struct enum_name {
int val;
const char *name;
};

And walk that.

Perhaps add a macro like

#define enum_map(e)
{.val = e, .name = #e}


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes

2019-08-01 Thread Alex Deucher 
Applied.  thanks!

Alex

On Thu, Aug 1, 2019 at 4:39 AM Colin King  wrote:
>
> From: Colin Ian King 
>
> There are a few spelling mistakes "unknow" -> "unknown" and
> "enabeld" -> "enabled". Fix these.
>
> Signed-off-by: Colin Ian King 
> ---
>  drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c 
> b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> index 13b2c8a60232..d029a99e600e 100644
> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> @@ -39,7 +39,7 @@ static const char* __smu_message_names[] = {
>  const char *smu_get_message_name(struct smu_context *smu, enum 
> smu_message_type type)
>  {
> if (type < 0 || type > SMU_MSG_MAX_COUNT)
> -   return "unknow smu message";
> +   return "unknown smu message";
> return __smu_message_names[type];
>  }
>
> @@ -52,7 +52,7 @@ static const char* __smu_feature_names[] = {
>  const char *smu_get_feature_name(struct smu_context *smu, enum 
> smu_feature_mask feature)
>  {
> if (feature < 0 || feature > SMU_FEATURE_COUNT)
> -   return "unknow smu feature";
> +   return "unknown smu feature";
> return __smu_feature_names[feature];
>  }
>
> @@ -79,7 +79,7 @@ size_t smu_sys_get_pp_feature_mask(struct smu_context *smu, 
> char *buf)
>count++,
>smu_get_feature_name(smu, i),
>feature_index,
> -  !!smu_feature_is_enabled(smu, i) ? "enabeld" : 
> "disabled");
> +  !!smu_feature_is_enabled(smu, i) ? "enabled" : 
> "disabled");
> }
>
>  failed:
> --
> 2.20.1
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes

2019-08-01 Thread walter harms 


Am 01.08.2019 10:39, schrieb Colin King:
> From: Colin Ian King 
> 
> There are a few spelling mistakes "unknow" -> "unknown" and
> "enabeld" -> "enabled". Fix these.
> 
> Signed-off-by: Colin Ian King 
> ---
>  drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c 
> b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> index 13b2c8a60232..d029a99e600e 100644
> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> @@ -39,7 +39,7 @@ static const char* __smu_message_names[] = {
>  const char *smu_get_message_name(struct smu_context *smu, enum 
> smu_message_type type)
>  {
>   if (type < 0 || type > SMU_MSG_MAX_COUNT)
> - return "unknow smu message";
> + return "unknown smu message";
>   return __smu_message_names[type];
>  }
>  
> @@ -52,7 +52,7 @@ static const char* __smu_feature_names[] = {
>  const char *smu_get_feature_name(struct smu_context *smu, enum 
> smu_feature_mask feature)
>  {
>   if (feature < 0 || feature > SMU_FEATURE_COUNT)
> - return "unknow smu feature";
> + return "unknown smu feature";
>   return __smu_feature_names[feature];
>  }
>  
> @@ -79,7 +79,7 @@ size_t smu_sys_get_pp_feature_mask(struct smu_context *smu, 
> char *buf)
>  count++,
>  smu_get_feature_name(smu, i),
>  feature_index,
> -!!smu_feature_is_enabled(smu, i) ? "enabeld" : 
> "disabled");
> +!!smu_feature_is_enabled(smu, i) ? "enabled" : 
> "disabled");

i am wondering,
is that !! really needed in front of smu_feature_is_enabled ?

re,
 wh

>   }
>  
>  failed:
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes

2019-08-01 Thread Colin King 
From: Colin Ian King 

There are a few spelling mistakes "unknow" -> "unknown" and
"enabeld" -> "enabled". Fix these.

Signed-off-by: Colin Ian King 
---
 drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c 
b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
index 13b2c8a60232..d029a99e600e 100644
--- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
@@ -39,7 +39,7 @@ static const char* __smu_message_names[] = {
 const char *smu_get_message_name(struct smu_context *smu, enum 
smu_message_type type)
 {
if (type < 0 || type > SMU_MSG_MAX_COUNT)
-   return "unknow smu message";
+   return "unknown smu message";
return __smu_message_names[type];
 }
 
@@ -52,7 +52,7 @@ static const char* __smu_feature_names[] = {
 const char *smu_get_feature_name(struct smu_context *smu, enum 
smu_feature_mask feature)
 {
if (feature < 0 || feature > SMU_FEATURE_COUNT)
-   return "unknow smu feature";
+   return "unknown smu feature";
return __smu_feature_names[feature];
 }
 
@@ -79,7 +79,7 @@ size_t smu_sys_get_pp_feature_mask(struct smu_context *smu, 
char *buf)
   count++,
   smu_get_feature_name(smu, i),
   feature_index,
-  !!smu_feature_is_enabled(smu, i) ? "enabeld" : 
"disabled");
+  !!smu_feature_is_enabled(smu, i) ? "enabled" : 
"disabled");
}
 
 failed:
-- 
2.20.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel