Re: [PATCH][drm-next] drm/panel: remove redundant assignment to val
On Sat, Aug 17, 2019 at 01:21:24PM +0100, Colin King wrote: > From: Colin Ian King > > Variable val is initialized to a value in a for-loop that is > never read and hence it is redundant. Remove it. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Thanks. Applied and pushed to drm-misc-next. Sam > --- > drivers/gpu/drm/panel/panel-tpo-td043mtea1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c > b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c > index 3b4f30c0fdae..84370562910f 100644 > --- a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c > +++ b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c > @@ -116,7 +116,7 @@ static void td043mtea1_write_gamma(struct > td043mtea1_panel *lcd) > td043mtea1_write(lcd, 0x13, val); > > /* gamma bits [7:0] */ > - for (val = i = 0; i < 12; i++) > + for (i = 0; i < 12; i++) > td043mtea1_write(lcd, 0x14 + i, gamma[i] & 0xff); > } > > -- > 2.20.1
[PATCH][drm-next] drm/panel: remove redundant assignment to val
From: Colin Ian King Variable val is initialized to a value in a for-loop that is never read and hence it is redundant. Remove it. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/gpu/drm/panel/panel-tpo-td043mtea1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c index 3b4f30c0fdae..84370562910f 100644 --- a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c +++ b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c @@ -116,7 +116,7 @@ static void td043mtea1_write_gamma(struct td043mtea1_panel *lcd) td043mtea1_write(lcd, 0x13, val); /* gamma bits [7:0] */ - for (val = i = 0; i < 12; i++) + for (i = 0; i < 12; i++) td043mtea1_write(lcd, 0x14 + i, gamma[i] & 0xff); } -- 2.20.1 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel