Re: [PATCH] ARM: dts: exynos: Add the OF graph between fimd and dsi

2017-06-11 Thread Krzysztof Kozlowski 
On Fri, Jun 09, 2017 at 11:59:33AM +0900, Hoegeun Kwon wrote:
> It should be connected to OF graph between fimd and dsi.
> Add the OF graph between fimd and dsi.

I need more explanation why this is needed. What happens without this?
What issue is fixed here?

What about Exynos5250 and Exynos5420? I think we do not have a board in
mainline using FIMD but maybe this should be added just for correct
hardware description?


Best regards,
Krzysztof

> 
> Signed-off-by: Hoegeun Kwon 
> ---
>  arch/arm/boot/dts/exynos3250.dtsi | 26 ++
>  arch/arm/boot/dts/exynos4.dtsi| 26 ++
>  2 files changed, 52 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi 
> b/arch/arm/boot/dts/exynos3250.dtsi
> index 590ee44..22d523f 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -311,6 +311,19 @@
>   iommus = <_fimd0>;
>   samsung,sysreg = <_reg>;
>   status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + fimd_to_dsi: endpoint {
> + remote-endpoint =
> + <_to_fimd>;
> + };
> + };
> + };
>   };
>  
>   dsi_0: dsi@11C8 {
> @@ -326,6 +339,19 @@
>   #address-cells = <1>;
>   #size-cells = <0>;
>   status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + dsi_to_fimd: endpoint {
> + remote-endpoint =
> + <_to_dsi>;
> + };
> + };
> + };
>   };
>  
>   sysmmu_fimd0: sysmmu@11E2 {
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 497a947..773d392 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -193,6 +193,19 @@
>   status = "disabled";
>   #address-cells = <1>;
>   #size-cells = <0>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + dsi_to_fimd: endpoint {
> + remote-endpoint =
> + <_to_dsi>;
> + };
> + };
> + };
>   };
>  
>   camera {
> @@ -715,6 +728,19 @@
>   iommus = <_fimd0>;
>   samsung,sysreg = <_reg>;
>   status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + fimd_to_dsi: endpoint {
> + remote-endpoint =
> + <_to_fimd>;
> + };
> + };
> + };
>   };
>  
>   tmu: tmu@100C {
> -- 
> 1.9.1
> 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] ARM: dts: exynos: Add the OF graph between fimd and dsi

2017-06-09 Thread Hoegeun Kwon 

On 06/09/2017 04:27 PM, Krzysztof Kozlowski wrote:

On Fri, Jun 09, 2017 at 11:59:33AM +0900, Hoegeun Kwon wrote:

It should be connected to OF graph between fimd and dsi.
Add the OF graph between fimd and dsi.

I need more explanation why this is needed. What happens without this?
What issue is fixed here?

What about Exynos5250 and Exynos5420? I think we do not have a board in
mainline using FIMD but maybe this should be added just for correct
hardware description?


Thank you for your review.

I'm sorry, this patch is wrong.
Please ignore this patch. :)

Best regards,
Hoegeun




Best regards,
Krzysztof


Signed-off-by: Hoegeun Kwon 
---
  arch/arm/boot/dts/exynos3250.dtsi | 26 ++
  arch/arm/boot/dts/exynos4.dtsi| 26 ++
  2 files changed, 52 insertions(+)

diff --git a/arch/arm/boot/dts/exynos3250.dtsi 
b/arch/arm/boot/dts/exynos3250.dtsi
index 590ee44..22d523f 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts/exynos3250.dtsi
@@ -311,6 +311,19 @@
iommus = <_fimd0>;
samsung,sysreg = <_reg>;
status = "disabled";
+
+   ports {
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   port@0 {
+   reg = <0>;
+   fimd_to_dsi: endpoint {
+   remote-endpoint =
+   <_to_fimd>;
+   };
+   };
+   };
};
  
  		dsi_0: dsi@11C8 {

@@ -326,6 +339,19 @@
#address-cells = <1>;
#size-cells = <0>;
status = "disabled";
+
+   ports {
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   port@0 {
+   reg = <0>;
+   dsi_to_fimd: endpoint {
+   remote-endpoint =
+   <_to_dsi>;
+   };
+   };
+   };
};
  
  		sysmmu_fimd0: sysmmu@11E2 {

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 497a947..773d392 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -193,6 +193,19 @@
status = "disabled";
#address-cells = <1>;
#size-cells = <0>;
+
+   ports {
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   port@0 {
+   reg = <0>;
+   dsi_to_fimd: endpoint {
+   remote-endpoint =
+   <_to_dsi>;
+   };
+   };
+   };
};
  
  	camera {

@@ -715,6 +728,19 @@
iommus = <_fimd0>;
samsung,sysreg = <_reg>;
status = "disabled";
+
+   ports {
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   port@0 {
+   reg = <0>;
+   fimd_to_dsi: endpoint {
+   remote-endpoint =
+   <_to_fimd>;
+   };
+   };
+   };
};
  
  	tmu: tmu@100C {

--
1.9.1






___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] ARM: dts: exynos: Add the OF graph between fimd and dsi

2017-06-08 Thread Hoegeun Kwon 
It should be connected to OF graph between fimd and dsi.
Add the OF graph between fimd and dsi.

Signed-off-by: Hoegeun Kwon 
---
 arch/arm/boot/dts/exynos3250.dtsi | 26 ++
 arch/arm/boot/dts/exynos4.dtsi| 26 ++
 2 files changed, 52 insertions(+)

diff --git a/arch/arm/boot/dts/exynos3250.dtsi 
b/arch/arm/boot/dts/exynos3250.dtsi
index 590ee44..22d523f 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts/exynos3250.dtsi
@@ -311,6 +311,19 @@
iommus = <_fimd0>;
samsung,sysreg = <_reg>;
status = "disabled";
+
+   ports {
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   port@0 {
+   reg = <0>;
+   fimd_to_dsi: endpoint {
+   remote-endpoint =
+   <_to_fimd>;
+   };
+   };
+   };
};
 
dsi_0: dsi@11C8 {
@@ -326,6 +339,19 @@
#address-cells = <1>;
#size-cells = <0>;
status = "disabled";
+
+   ports {
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   port@0 {
+   reg = <0>;
+   dsi_to_fimd: endpoint {
+   remote-endpoint =
+   <_to_dsi>;
+   };
+   };
+   };
};
 
sysmmu_fimd0: sysmmu@11E2 {
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 497a947..773d392 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -193,6 +193,19 @@
status = "disabled";
#address-cells = <1>;
#size-cells = <0>;
+
+   ports {
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   port@0 {
+   reg = <0>;
+   dsi_to_fimd: endpoint {
+   remote-endpoint =
+   <_to_dsi>;
+   };
+   };
+   };
};
 
camera {
@@ -715,6 +728,19 @@
iommus = <_fimd0>;
samsung,sysreg = <_reg>;
status = "disabled";
+
+   ports {
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   port@0 {
+   reg = <0>;
+   fimd_to_dsi: endpoint {
+   remote-endpoint =
+   <_to_fimd>;
+   };
+   };
+   };
};
 
tmu: tmu@100C {
-- 
1.9.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel