Re: [PATCH] Fix failure of simpledrm probe when trying to grab FB from the EFI-based Framebuffer

2023-11-13 Thread Thomas Zimmermann
Hi Javier Am 12.11.23 um 11:35 schrieb Javier Martinez Canillas: Andrew Worsley writes: Hello Andrew, On Sat, 11 Nov 2023 at 20:10, Javier Martinez Canillas wrote: On Sat, 11 Nov 2023 at 15:30, Andrew Worsley wrote: The simpledrm.c does not call

Re: [PATCH] Fix failure of simpledrm probe when trying to grab FB from the EFI-based Framebuffer

2023-11-12 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: [...] > > Reported-by: Andrew Worsley > Signed-off-by: Javier Martinez Canillas > --- > drivers/of/platform.c | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > Forgot to include the header file and just pointed out by the robot, so

Re: [PATCH] Fix failure of simpledrm probe when trying to grab FB from the EFI-based Framebuffer

2023-11-12 Thread Javier Martinez Canillas
Andrew Worsley writes: Hello Andrew, > On Sat, 11 Nov 2023 at 20:10, Javier Martinez Canillas > wrote: >> > >> > On Sat, 11 Nov 2023 at 15:30, Andrew Worsley wrote: >> >> >> >>The simpledrm.c does not call aperture_remove_conflicting_devices() in >> >> it's probe >> >>function

Re: [PATCH] Fix failure of simpledrm probe when trying to grab FB from the EFI-based Framebuffer

2023-11-11 Thread Andrew Worsley
On Sat, 11 Nov 2023 at 20:10, Javier Martinez Canillas wrote: > > > On Sat, 11 Nov 2023 at 15:30, Andrew Worsley wrote: > >> > >>The simpledrm.c does not call aperture_remove_conflicting_devices() in > >> it's probe > >>function as the drivers/video/aperture.c documentation says it

Re: [PATCH] Fix failure of simpledrm probe when trying to grab FB from the EFI-based Framebuffer

2023-11-11 Thread Javier Martinez Canillas
Andrew Worsley writes: > It's inline - part of the email - not an attachment? > > I can see it in the copy that went to me... > > Andrew > > On Sat, 11 Nov 2023 at 15:30, Andrew Worsley wrote: >> >>The simpledrm.c does not call aperture_remove_conflicting_devices() in >> it's probe >>

Re: [PATCH] Fix failure of simpledrm probe when trying to grab FB from the EFI-based Framebuffer

2023-11-11 Thread Javier Martinez Canillas
Andrew Worsley writes: > It's inline - part of the email - not an attachment? > > I can see it in the copy that went to me... > I see it now as another thread. There is something weird with the threading since your first email was shown as first email in a thread with no subject. > Andrew > >

Re: [PATCH] Fix failure of simpledrm probe when trying to grab FB from the EFI-based Framebuffer

2023-11-11 Thread Andrew Worsley
It's inline - part of the email - not an attachment? I can see it in the copy that went to me... Andrew On Sat, 11 Nov 2023 at 15:30, Andrew Worsley wrote: > >The simpledrm.c does not call aperture_remove_conflicting_devices() in > it's probe >function as the drivers/video/aperture.c

[PATCH] Fix failure of simpledrm probe when trying to grab FB from the EFI-based Framebuffer

2023-11-11 Thread Andrew Worsley
The simpledrm.c does not call aperture_remove_conflicting_devices() in it's probe function as the drivers/video/aperture.c documentation says it should. Consequently it's request for the FB memory fails. ... [3.085302] simple-framebuffer bd58dc000.framebuffer: [drm] *ERROR* could