Re: [PATCH] drm/amd/amdgpu: introduce DRM_AMDGPU_WERROR

2023-05-30 Thread Ho, Kenny
[Public] Reviewed-by: Kenny Ho

Re: [PATCH] drm/amd/amdgpu: introduce DRM_AMDGPU_WERROR

2023-05-30 Thread Hamza Mahfooz
On 5/30/23 11:50, Ho, Kenny wrote: [Public] On 5/30/23 11:24, Hamza Mahfooz wrote: I am able to get clean builds with this enabled on GCC 11-13 and Clang 15, at least as of commit e786aef0869c ("drm/amd/display: remove unused definition") on amd-staging-drm-next. Did you try intentionally

Re: [PATCH] drm/amd/amdgpu: introduce DRM_AMDGPU_WERROR

2023-05-30 Thread Ho, Kenny
[Public] On 5/30/23 11:24, Hamza Mahfooz wrote: > I am able to get clean builds with this enabled on GCC 11-13 and Clang > 15, at least as of commit e786aef0869c ("drm/amd/display: remove unused > definition") on amd-staging-drm-next. Did you try intentionally introducing a warning to see if the

Re: [PATCH] drm/amd/amdgpu: introduce DRM_AMDGPU_WERROR

2023-05-30 Thread Hamza Mahfooz
On 5/25/23 12:38, Hamza Mahfooz wrote: We want to do -Werror builds on our CI. However, non-amdgpu breakages have prevented us from doing so thus far. Also, there are a number of additional checks that we should enable, that the community cares about and are hidden behind -Wextra. So, define

[PATCH] drm/amd/amdgpu: introduce DRM_AMDGPU_WERROR

2023-05-25 Thread Hamza Mahfooz
We want to do -Werror builds on our CI. However, non-amdgpu breakages have prevented us from doing so thus far. Also, there are a number of additional checks that we should enable, that the community cares about and are hidden behind -Wextra. So, define DRM_AMDGPU_WERROR to only enable -Werror for