Re: [PATCH] drm/amd/display: Fix unsigned variable compared to less than zero

2019-11-11 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 11, 2019 at 2:44 PM Gustavo A. R. Silva wrote: > > > > On 11/11/19 11:46, Mikita Lipski wrote: > > > > Thanks for catching it! > > > > Glad to help out. :) > > > Reviewed-by: Mikita Lipski > > > > Thanks > -- > Gustavo > > > > > On 11.11.2019 12:25, Gustavo

Re: [PATCH] drm/amd/display: Fix unsigned variable compared to less than zero

2019-11-11 Thread Gustavo A. R. Silva
On 11/11/19 11:46, Mikita Lipski wrote: > > Thanks for catching it! > Glad to help out. :) > Reviewed-by: Mikita Lipski > Thanks -- Gustavo > > On 11.11.2019 12:25, Gustavo A. R. Silva wrote: >> Currenly, the error check below on variable*vcpi_slots*  is always >> false because it is a

[PATCH] drm/amd/display: Fix unsigned variable compared to less than zero

2019-11-11 Thread Gustavo A. R. Silva
Currenly, the error check below on variable *vcpi_slots* is always false because it is a uint64_t type variable, hence, the values this variable can hold are never less than zero: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: 4870 if (dm_new_connector_state->vcpi_slots < 0) { 4871

Re: [PATCH] drm/amd/display: Fix unsigned variable compared to less than zero

2019-11-11 Thread Mikita Lipski
Thanks for catching it! Reviewed-by: Mikita Lipski On 11.11.2019 12:25, Gustavo A. R. Silva wrote: Currenly, the error check below on variable*vcpi_slots* is always false because it is a uint64_t type variable, hence, the values this variable can hold are never less than zero: