RE: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
...@vger.kernel.org; Joshi, Mukul ; Paneer Selvam, Arunpravin ; Khatri, Sunil Subject: [PATCH] drm/amdgpu: cache in more vm fault information When an page fault interrupt is raised there is a lot more information that is useful for developers to analyse the pagefault. Add all such information

[PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Sunil Khatri
When an page fault interrupt is raised there is a lot more information that is useful for developers to analyse the pagefault. Add all such information in the last cached pagefault from an interrupt handler. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 9 +++--

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
As discussion we decided that we dont need the client id, srcid, pasid etc in page fault information dump. So this patch isnt needed anymore. So dropping this patch and will add the new information in the devcoredump for pagefault which is all available in existing structures. As discussed,

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 11:42 AM Khatri, Sunil wrote: > > > On 3/6/2024 9:59 PM, Alex Deucher wrote: > > On Wed, Mar 6, 2024 at 11:21 AM Khatri, Sunil wrote: > >> > >> On 3/6/2024 9:45 PM, Alex Deucher wrote: > >>> On Wed, Mar 6, 2024 at 11:06 AM Khatri, Sunil wrote: > On 3/6/2024 9:07 PM,

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 9:59 PM, Alex Deucher wrote: On Wed, Mar 6, 2024 at 11:21 AM Khatri, Sunil wrote: On 3/6/2024 9:45 PM, Alex Deucher wrote: On Wed, Mar 6, 2024 at 11:06 AM Khatri, Sunil wrote: On 3/6/2024 9:07 PM, Christian König wrote: Am 06.03.24 um 16:13 schrieb Khatri, Sunil: On

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 11:21 AM Khatri, Sunil wrote: > > > On 3/6/2024 9:45 PM, Alex Deucher wrote: > > On Wed, Mar 6, 2024 at 11:06 AM Khatri, Sunil wrote: > >> > >> On 3/6/2024 9:07 PM, Christian König wrote: > >>> Am 06.03.24 um 16:13 schrieb Khatri, Sunil: > On 3/6/2024 8:34 PM,

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 9:49 PM, Christian König wrote: Am 06.03.24 um 17:06 schrieb Khatri, Sunil: On 3/6/2024 9:07 PM, Christian König wrote: Am 06.03.24 um 16:13 schrieb Khatri, Sunil: On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 9:45 PM, Alex Deucher wrote: On Wed, Mar 6, 2024 at 11:06 AM Khatri, Sunil wrote: On 3/6/2024 9:07 PM, Christian König wrote: Am 06.03.24 um 16:13 schrieb Khatri, Sunil: On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6,

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Christian König
Am 06.03.24 um 17:06 schrieb Khatri, Sunil: On 3/6/2024 9:07 PM, Christian König wrote: Am 06.03.24 um 16:13 schrieb Khatri, Sunil: On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: On 3/6/2024 6:12

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 11:06 AM Khatri, Sunil wrote: > > > On 3/6/2024 9:07 PM, Christian König wrote: > > Am 06.03.24 um 16:13 schrieb Khatri, Sunil: > >> > >> On 3/6/2024 8:34 PM, Christian König wrote: > >>> Am 06.03.24 um 15:29 schrieb Alex Deucher: > On Wed, Mar 6, 2024 at 8:04 AM

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 9:07 PM, Christian König wrote: Am 06.03.24 um 16:13 schrieb Khatri, Sunil: On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: On 3/6/2024 6:12 PM, Christian König wrote: Am 06.03.24 um

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 9:19 PM, Alex Deucher wrote: On Wed, Mar 6, 2024 at 10:32 AM Alex Deucher wrote: On Wed, Mar 6, 2024 at 10:13 AM Khatri, Sunil wrote: On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote:

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 10:32 AM Alex Deucher wrote: > > On Wed, Mar 6, 2024 at 10:13 AM Khatri, Sunil wrote: > > > > > > On 3/6/2024 8:34 PM, Christian König wrote: > > > Am 06.03.24 um 15:29 schrieb Alex Deucher: > > >> On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: > > >>> > > >>> On

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Christian König
Am 06.03.24 um 16:13 schrieb Khatri, Sunil: On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: On 3/6/2024 6:12 PM, Christian König wrote: Am 06.03.24 um 11:40 schrieb Khatri, Sunil: On 3/6/2024 3:37

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 10:13 AM Khatri, Sunil wrote: > > > On 3/6/2024 8:34 PM, Christian König wrote: > > Am 06.03.24 um 15:29 schrieb Alex Deucher: > >> On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: > >>> > >>> On 3/6/2024 6:12 PM, Christian König wrote: > Am 06.03.24 um 11:40

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 8:34 PM, Christian König wrote: Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: On 3/6/2024 6:12 PM, Christian König wrote: Am 06.03.24 um 11:40 schrieb Khatri, Sunil: On 3/6/2024 3:37 PM, Christian König wrote: Am 06.03.24 um

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Christian König
Am 06.03.24 um 15:29 schrieb Alex Deucher: On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: On 3/6/2024 6:12 PM, Christian König wrote: Am 06.03.24 um 11:40 schrieb Khatri, Sunil: On 3/6/2024 3:37 PM, Christian König wrote: Am 06.03.24 um 10:04 schrieb Sunil Khatri: When an page fault

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Alex Deucher
On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote: > > > On 3/6/2024 6:12 PM, Christian König wrote: > > Am 06.03.24 um 11:40 schrieb Khatri, Sunil: > >> > >> On 3/6/2024 3:37 PM, Christian König wrote: > >>> Am 06.03.24 um 10:04 schrieb Sunil Khatri: > When an page fault interrupt is

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 6:12 PM, Christian König wrote: Am 06.03.24 um 11:40 schrieb Khatri, Sunil: On 3/6/2024 3:37 PM, Christian König wrote: Am 06.03.24 um 10:04 schrieb Sunil Khatri: When an  page fault interrupt is raised there is a lot more information that is useful for developers to analyse

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Christian König
Am 06.03.24 um 11:40 schrieb Khatri, Sunil: On 3/6/2024 3:37 PM, Christian König wrote: Am 06.03.24 um 10:04 schrieb Sunil Khatri: When an  page fault interrupt is raised there is a lot more information that is useful for developers to analyse the pagefault. Well actually those information

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Khatri, Sunil
On 3/6/2024 3:37 PM, Christian König wrote: Am 06.03.24 um 10:04 schrieb Sunil Khatri: When an  page fault interrupt is raised there is a lot more information that is useful for developers to analyse the pagefault. Well actually those information are not that interesting  because they are

Re: [PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Christian König
Am 06.03.24 um 10:04 schrieb Sunil Khatri: When an page fault interrupt is raised there is a lot more information that is useful for developers to analyse the pagefault. Well actually those information are not that interesting  because they are hw generation specific. You should probably

[PATCH] drm/amdgpu: cache in more vm fault information

2024-03-06 Thread Sunil Khatri
When an page fault interrupt is raised there is a lot more information that is useful for developers to analyse the pagefault. Add all such information in the last cached pagefault from an interrupt handler. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 9 +++--