Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-18 Thread Emil Velikov
On Wed, 17 Apr 2019 at 21:49, Dave Airlie wrote: > > On Thu, 18 Apr 2019 at 03:30, Koenig, Christian > wrote: > > > > Am 17.04.19 um 17:51 schrieb Emil Velikov: > > > Hi guys, > > > > > > On 2019/04/17, Daniel Vetter wrote: > > >> On Wed, Apr 17, 2019 at 02:46:06PM +0200, Christian König wrote: >

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-18 Thread Michel Dänzer
On 2019-04-18 12:35 p.m., Daniel Vetter wrote: > > - We've implemented rendernodes as a clean/new uapi years ago. git > says we've made them the default in 2014. > > - Lots of work happened to make render nodes the main thing. Despite > all that effort (well over 5 years, and a few more, initial

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-18 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 12:04 PM Michel Dänzer wrote: > > On 2019-04-18 11:46 a.m., Daniel Vetter wrote: > > On Thu, Apr 18, 2019 at 11:22 AM Michel Dänzer wrote: > >> On 2019-04-18 11:11 a.m., Daniel Vetter wrote: > >>> On Thu, Apr 18, 2019 at 10:52 AM Michel Dänzer wrote: > On 2019-04-18

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-18 Thread Michel Dänzer
On 2019-04-18 11:46 a.m., Daniel Vetter wrote: > On Thu, Apr 18, 2019 at 11:22 AM Michel Dänzer wrote: >> On 2019-04-18 11:11 a.m., Daniel Vetter wrote: >>> On Thu, Apr 18, 2019 at 10:52 AM Michel Dänzer wrote: On 2019-04-18 10:26 a.m., Daniel Vetter wrote: > > Ok correction: amd has

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-18 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 11:22 AM Michel Dänzer wrote: > > On 2019-04-18 11:11 a.m., Daniel Vetter wrote: > > On Thu, Apr 18, 2019 at 10:52 AM Michel Dänzer wrote: > >> On 2019-04-18 10:26 a.m., Daniel Vetter wrote: > >>> > >>> Ok correction: amd has stuck out in the past too, there was some vblan

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-18 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 10:56 AM Koenig, Christian wrote: > > Am 18.04.19 um 10:26 schrieb Daniel Vetter: > > On Thu, Apr 18, 2019 at 08:06:03AM +, Koenig, Christian wrote: > >> Am 18.04.19 um 08:46 schrieb Daniel Vetter: > >>> On Wed, Apr 17, 2019 at 7:30 PM Koenig, Christian > >>> wrote: >

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-18 Thread Michel Dänzer
On 2019-04-18 11:11 a.m., Daniel Vetter wrote: > On Thu, Apr 18, 2019 at 10:52 AM Michel Dänzer wrote: >> On 2019-04-18 10:26 a.m., Daniel Vetter wrote: >>> >>> Ok correction: amd has stuck out in the past too, there was some vblank vs >>> pageflip stuff where we needed to do some pretty clever tr

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-18 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 10:52 AM Michel Dänzer wrote: > > On 2019-04-18 10:26 a.m., Daniel Vetter wrote: > > > > Ok correction: amd has stuck out in the past too, there was some vblank vs > > pageflip stuff where we needed to do some pretty clever tricks to both > > have the new stricter semantics

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-18 Thread Koenig, Christian
Am 18.04.19 um 10:26 schrieb Daniel Vetter: > On Thu, Apr 18, 2019 at 08:06:03AM +, Koenig, Christian wrote: >> Am 18.04.19 um 08:46 schrieb Daniel Vetter: >>> On Wed, Apr 17, 2019 at 7:30 PM Koenig, Christian >>> wrote: Am 17.04.19 um 17:51 schrieb Emil Velikov: > Hi guys, >

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-18 Thread Michel Dänzer
On 2019-04-18 10:26 a.m., Daniel Vetter wrote: > > Ok correction: amd has stuck out in the past too, there was some vblank vs > pageflip stuff where we needed to do some pretty clever tricks to both > have the new stricter semantics for everyone, while keeping the amd ddx > happy still. This aint

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-18 Thread Daniel Vetter
On Thu, Apr 18, 2019 at 08:06:03AM +, Koenig, Christian wrote: > Am 18.04.19 um 08:46 schrieb Daniel Vetter: > > On Wed, Apr 17, 2019 at 7:30 PM Koenig, Christian > > wrote: > >> Am 17.04.19 um 17:51 schrieb Emil Velikov: > >>> Hi guys, > >>> > >>> On 2019/04/17, Daniel Vetter wrote: > On

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-18 Thread Koenig, Christian
Am 18.04.19 um 08:46 schrieb Daniel Vetter: > On Wed, Apr 17, 2019 at 7:30 PM Koenig, Christian > wrote: >> Am 17.04.19 um 17:51 schrieb Emil Velikov: >>> Hi guys, >>> >>> On 2019/04/17, Daniel Vetter wrote: On Wed, Apr 17, 2019 at 02:46:06PM +0200, Christian König wrote: > Am 17.04.19 um

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-18 Thread Emil Velikov
Hi guys, On 2019/04/17, Daniel Vetter wrote: > On Wed, Apr 17, 2019 at 02:46:06PM +0200, Christian König wrote: > > Am 17.04.19 um 14:35 schrieb Daniel Vetter: > > > On Wed, Apr 17, 2019 at 12:06:32PM +, Koenig, Christian wrote: > > > > Am 17.04.19 um 14:00 schrieb Daniel Vetter: > > > > > On

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-17 Thread Daniel Vetter
On Wed, Apr 17, 2019 at 7:30 PM Koenig, Christian wrote: > > Am 17.04.19 um 17:51 schrieb Emil Velikov: > > Hi guys, > > > > On 2019/04/17, Daniel Vetter wrote: > >> On Wed, Apr 17, 2019 at 02:46:06PM +0200, Christian König wrote: > >>> Am 17.04.19 um 14:35 schrieb Daniel Vetter: > On Wed, Ap

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-17 Thread Dave Airlie
On Thu, 18 Apr 2019 at 03:30, Koenig, Christian wrote: > > Am 17.04.19 um 17:51 schrieb Emil Velikov: > > Hi guys, > > > > On 2019/04/17, Daniel Vetter wrote: > >> On Wed, Apr 17, 2019 at 02:46:06PM +0200, Christian König wrote: > >>> Am 17.04.19 um 14:35 schrieb Daniel Vetter: > On Wed, Apr

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-17 Thread Koenig, Christian
Am 17.04.19 um 17:51 schrieb Emil Velikov: > Hi guys, > > On 2019/04/17, Daniel Vetter wrote: >> On Wed, Apr 17, 2019 at 02:46:06PM +0200, Christian König wrote: >>> Am 17.04.19 um 14:35 schrieb Daniel Vetter: On Wed, Apr 17, 2019 at 12:06:32PM +, Koenig, Christian wrote: > Am 17.04.19

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-17 Thread Daniel Vetter
On Wed, Apr 17, 2019 at 02:46:06PM +0200, Christian König wrote: > Am 17.04.19 um 14:35 schrieb Daniel Vetter: > > On Wed, Apr 17, 2019 at 12:06:32PM +, Koenig, Christian wrote: > > > Am 17.04.19 um 14:00 schrieb Daniel Vetter: > > > > On Wed, Apr 17, 2019 at 11:18:35AM +, Koenig, Christian

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-17 Thread Christian König
Am 17.04.19 um 14:35 schrieb Daniel Vetter: On Wed, Apr 17, 2019 at 12:06:32PM +, Koenig, Christian wrote: Am 17.04.19 um 14:00 schrieb Daniel Vetter: On Wed, Apr 17, 2019 at 11:18:35AM +, Koenig, Christian wrote: Am 17.04.19 um 13:06 schrieb Daniel Vetter: On Wed, Apr 17, 2019 at 12:

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-17 Thread Daniel Vetter
On Wed, Apr 17, 2019 at 12:06:32PM +, Koenig, Christian wrote: > Am 17.04.19 um 14:00 schrieb Daniel Vetter: > > On Wed, Apr 17, 2019 at 11:18:35AM +, Koenig, Christian wrote: > >> Am 17.04.19 um 13:06 schrieb Daniel Vetter: > >>> On Wed, Apr 17, 2019 at 12:29 PM Koenig, Christian > >>> wr

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-17 Thread Koenig, Christian
Am 17.04.19 um 14:00 schrieb Daniel Vetter: > On Wed, Apr 17, 2019 at 11:18:35AM +, Koenig, Christian wrote: >> Am 17.04.19 um 13:06 schrieb Daniel Vetter: >>> On Wed, Apr 17, 2019 at 12:29 PM Koenig, Christian >>> wrote: >>> [SNIP] >> Well, what you guys did here is a serious no-go. > Not rea

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-17 Thread Daniel Vetter
On Wed, Apr 17, 2019 at 11:18:35AM +, Koenig, Christian wrote: > Am 17.04.19 um 13:06 schrieb Daniel Vetter: > > On Wed, Apr 17, 2019 at 12:29 PM Koenig, Christian > > wrote: > >> Hi guys, > >> > >> well going back to the beginning once more because something doesn't fit > >> together here. >

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-17 Thread Koenig, Christian
Am 17.04.19 um 13:06 schrieb Daniel Vetter: > On Wed, Apr 17, 2019 at 12:29 PM Koenig, Christian > wrote: >> Hi guys, >> >> well going back to the beginning once more because something doesn't fit >> together here. >> >> I mean what exactly is the purpose of 8059add0478e "drm: allow render >> capa

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-17 Thread Daniel Vetter
On Wed, Apr 17, 2019 at 12:29 PM Koenig, Christian wrote: > > Hi guys, > > well going back to the beginning once more because something doesn't fit > together here. > > I mean what exactly is the purpose of 8059add0478e "drm: allow render > capable master with DRM_AUTH ioctls"? > > When I read the

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-17 Thread Koenig, Christian
Hi guys, well going back to the beginning once more because something doesn't fit together here. I mean what exactly is the purpose of 8059add0478e "drm: allow render capable master with DRM_AUTH ioctls"? When I read the code correctly the effect is that we ignore the DRM_AUTH flag when also

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-17 Thread Koenig, Christian
Am 17.04.19 um 10:10 schrieb Daniel Vetter: > On Wed, Apr 17, 2019 at 09:09:27AM +0200, Christian König wrote: >> Am 16.04.19 um 23:40 schrieb Andres Rodriguez: >>> After a recent commit, access to the DRM_AUTH ioctls become more >>> permissive. This resulted in a buggy check for drm_master capabil

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-17 Thread Daniel Vetter
On Wed, Apr 17, 2019 at 09:09:27AM +0200, Christian König wrote: > Am 16.04.19 um 23:40 schrieb Andres Rodriguez: > > After a recent commit, access to the DRM_AUTH ioctls become more > > permissive. This resulted in a buggy check for drm_master capabilities > > inside radv stop working. > > > > Th

Re: [PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-17 Thread Christian König
Am 16.04.19 um 23:40 schrieb Andres Rodriguez: After a recent commit, access to the DRM_AUTH ioctls become more permissive. This resulted in a buggy check for drm_master capabilities inside radv stop working. This commit adds a backwards compatibility workaround so that the radv drm_master check

[PATCH] drm/amdgpu: fix drm leases being broken on radv

2019-04-16 Thread Andres Rodriguez
After a recent commit, access to the DRM_AUTH ioctls become more permissive. This resulted in a buggy check for drm_master capabilities inside radv stop working. This commit adds a backwards compatibility workaround so that the radv drm_master check keeps working as previously expected. This fixe