Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
On Wed, Feb 23, 2022 at 4:19 AM Andre Przywara wrote:
>
> On Tue, 25 Jan 2022 12:37:38 +
> Liviu Dudau wrote:
>
> Hi,
>
> > On Mon, Jan 24, 2022 at 04:24:37PM +, carsten.haitz...@foss.arm.com
> > wrote:
> > > From: Carsten Haitzler
> > >
> > > Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
> > >
> > > Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
> > >
> > > Signed-off-by: Carsten Haitzler
> >
> > Acked-by: Liviu Dudau
> >
> > I will add Steven's reviewed-by as well when pushing it.
>
> Did this go anywhere? I see my .config just selecting HDLCD still failing
> with -rc5. Any chance this can be taken now, as this is a regression
> introduced with -rc1?
I thought Liviu was going to, but in any case I've now pushed it to
drm-misc-fixes.
Rob
Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
On Tue, 25 Jan 2022 12:37:38 +
Liviu Dudau wrote:
Hi,
> On Mon, Jan 24, 2022 at 04:24:37PM +, carsten.haitz...@foss.arm.com wrote:
> > From: Carsten Haitzler
> >
> > Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
> >
> > Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
> >
> > Signed-off-by: Carsten Haitzler
>
> Acked-by: Liviu Dudau
>
> I will add Steven's reviewed-by as well when pushing it.
Did this go anywhere? I see my .config just selecting HDLCD still failing
with -rc5. Any chance this can be taken now, as this is a regression
introduced with -rc1?
Cheers,
Andre
> > ---
> > drivers/gpu/drm/arm/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
> > index 58a242871b28..6e3f1d600541 100644
> > --- a/drivers/gpu/drm/arm/Kconfig
> > +++ b/drivers/gpu/drm/arm/Kconfig
> > @@ -6,6 +6,7 @@ config DRM_HDLCD
> > depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
> > depends on COMMON_CLK
> > select DRM_KMS_HELPER
> > + select DRM_GEM_CMA_HELPER
> > help
> > Choose this option if you have an ARM High Definition Colour LCD
> > controller.
> > --
> > 2.30.1
> >
>
Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
On Mon, Jan 24, 2022 at 04:24:37PM +, carsten.haitz...@foss.arm.com wrote:
> From: Carsten Haitzler
>
> Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
>
> Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
>
> Signed-off-by: Carsten Haitzler
Acked-by: Liviu Dudau
I will add Steven's reviewed-by as well when pushing it.
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
> index 58a242871b28..6e3f1d600541 100644
> --- a/drivers/gpu/drm/arm/Kconfig
> +++ b/drivers/gpu/drm/arm/Kconfig
> @@ -6,6 +6,7 @@ config DRM_HDLCD
> depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
> depends on COMMON_CLK
> select DRM_KMS_HELPER
> + select DRM_GEM_CMA_HELPER
> help
> Choose this option if you have an ARM High Definition Colour LCD
> controller.
> --
> 2.30.1
>
--
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---
¯\_(ツ)_/¯
Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
I sent an updated patch with the Fixes:
On 1/24/22 16:13, Steven Price wrote:
On 24/01/2022 15:13, carsten.haitz...@foss.arm.com wrote:
From: Carsten Haitzler
Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
Signed-off-by: Carsten Haitzler
To add the context, DRM_HDLCD used to select DRM_KMS_CMA_HELPER but that
was removed in commit 09717af7d13d ("drm: Remove
CONFIG_DRM_KMS_CMA_HELPER option"). DRM_KMS_CMA_HELPER would select
DRM_GEM_CMA_HELPER but that transitive dependency was lost and
apparently the fixup was missed in that commit.
So we need a:
Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
and with that...
Reviewed-by: Steven Price
Steve
---
drivers/gpu/drm/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
index 58a242871b28..6e3f1d600541 100644
--- a/drivers/gpu/drm/arm/Kconfig
+++ b/drivers/gpu/drm/arm/Kconfig
@@ -6,6 +6,7 @@ config DRM_HDLCD
depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
depends on COMMON_CLK
select DRM_KMS_HELPER
+ select DRM_GEM_CMA_HELPER
help
Choose this option if you have an ARM High Definition Colour LCD
controller.
[PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
From: Carsten Haitzler
Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
Signed-off-by: Carsten Haitzler
---
drivers/gpu/drm/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
index 58a242871b28..6e3f1d600541 100644
--- a/drivers/gpu/drm/arm/Kconfig
+++ b/drivers/gpu/drm/arm/Kconfig
@@ -6,6 +6,7 @@ config DRM_HDLCD
depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
depends on COMMON_CLK
select DRM_KMS_HELPER
+ select DRM_GEM_CMA_HELPER
help
Choose this option if you have an ARM High Definition Colour LCD
controller.
--
2.30.1
Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
On 24/01/2022 15:13, carsten.haitz...@foss.arm.com wrote:
> From: Carsten Haitzler
>
> Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
>
> Signed-off-by: Carsten Haitzler
To add the context, DRM_HDLCD used to select DRM_KMS_CMA_HELPER but that
was removed in commit 09717af7d13d ("drm: Remove
CONFIG_DRM_KMS_CMA_HELPER option"). DRM_KMS_CMA_HELPER would select
DRM_GEM_CMA_HELPER but that transitive dependency was lost and
apparently the fixup was missed in that commit.
So we need a:
Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
and with that...
Reviewed-by: Steven Price
Steve
> ---
> drivers/gpu/drm/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
> index 58a242871b28..6e3f1d600541 100644
> --- a/drivers/gpu/drm/arm/Kconfig
> +++ b/drivers/gpu/drm/arm/Kconfig
> @@ -6,6 +6,7 @@ config DRM_HDLCD
> depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
> depends on COMMON_CLK
> select DRM_KMS_HELPER
> + select DRM_GEM_CMA_HELPER
> help
> Choose this option if you have an ARM High Definition Colour LCD
> controller.
>
Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
Sorry - noise. Ignore this one. Following one is fixed. On 1/24/22 15:13, carsten.haitz...@foss.arm.com wrote: From: Carsten Haitzler Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too. Signed-off-by: Carsten Haitzler --- drivers/gpu/drm/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig index 58a242871b28..6e3f1d600541 100644 --- a/drivers/gpu/drm/arm/Kconfig +++ b/drivers/gpu/drm/arm/Kconfig @@ -6,6 +6,7 @@ config DRM_HDLCD depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST) depends on COMMON_CLK select DRM_KMS_HELPER + select DRM_GEM_CMA_HELPER help Choose this option if you have an ARM High Definition Colour LCD controller.
[PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
From: Carsten Haitzler Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too. Signed-off-by: Carsten Haitzler --- drivers/gpu/drm/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig index 58a242871b28..6e3f1d600541 100644 --- a/drivers/gpu/drm/arm/Kconfig +++ b/drivers/gpu/drm/arm/Kconfig @@ -6,6 +6,7 @@ config DRM_HDLCD depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST) depends on COMMON_CLK select DRM_KMS_HELPER + select DRM_GEM_CMA_HELPER help Choose this option if you have an ARM High Definition Colour LCD controller. -- 2.30.1
