Re: [PATCH] drm/crc-debugfs: User irqsafe spinlock in drm_crtc_add_crc_entry

2019-06-06 Thread Daniel Vetter
On Thu, Jun 06, 2019 at 10:27:23AM +0200, Benjamin Gaignard wrote: > Le jeu. 6 juin 2019 à 10:12, Ville Syrjälä > a écrit : > > > > On Wed, Jun 05, 2019 at 09:45:56PM +0200, Daniel Vetter wrote: > > > We can be called from any context, we need to be prepared. > > > > > > Noticed this while

Re: [PATCH] drm/crc-debugfs: User irqsafe spinlock in drm_crtc_add_crc_entry

2019-06-06 Thread Benjamin Gaignard
Le jeu. 6 juin 2019 à 10:12, Ville Syrjälä a écrit : > > On Wed, Jun 05, 2019 at 09:45:56PM +0200, Daniel Vetter wrote: > > We can be called from any context, we need to be prepared. > > > > Noticed this while hacking on vkms, which calls this function from a > > normal worker. Which really

Re: [PATCH] drm/crc-debugfs: User irqsafe spinlock in drm_crtc_add_crc_entry

2019-06-06 Thread Ville Syrjälä
On Wed, Jun 05, 2019 at 09:45:56PM +0200, Daniel Vetter wrote: > We can be called from any context, we need to be prepared. > > Noticed this while hacking on vkms, which calls this function from a > normal worker. Which really upsets lockdep. > > Cc: Rodrigo Siqueira > Cc: Tomeu Vizoso > Cc:

[PATCH] drm/crc-debugfs: User irqsafe spinlock in drm_crtc_add_crc_entry

2019-06-05 Thread Daniel Vetter
We can be called from any context, we need to be prepared. Noticed this while hacking on vkms, which calls this function from a normal worker. Which really upsets lockdep. Cc: Rodrigo Siqueira Cc: Tomeu Vizoso Cc: Emil Velikov Cc: Benjamin Gaignard Signed-off-by: Daniel Vetter ---