Re: [PATCH] drm/crtc: fix uninitialized variable use even harder

2024-02-13 Thread Dmitry Baryshkov
On Mon, 12 Feb 2024 13:55:34 -0800, Rob Clark wrote: > DRM_MODESET_LOCK_ALL_BEGIN() has a hidden trap-door (aka retry loop), > which means we can't rely too much on variable initializers. > > Applied to drm-misc-fixes, thanks! [1/1] drm/crtc: fix uninitialized variable use even harder

Re: [PATCH] drm/crtc: fix uninitialized variable use even harder

2024-02-13 Thread Dmitry Baryshkov
On Tue, 13 Feb 2024 at 15:50, Dmitry Baryshkov wrote: > > On Mon, 12 Feb 2024 at 23:55, Rob Clark wrote: > > > > From: Rob Clark > > > > DRM_MODESET_LOCK_ALL_BEGIN() has a hidden trap-door (aka retry loop), > > which means we can't rely too much on variable initializers. > > > > Fixes:

Re: [PATCH] drm/crtc: fix uninitialized variable use even harder

2024-02-13 Thread Daniel Vetter
On Mon, Feb 12, 2024 at 01:55:34PM -0800, Rob Clark wrote: > From: Rob Clark > > DRM_MODESET_LOCK_ALL_BEGIN() has a hidden trap-door (aka retry loop), > which means we can't rely too much on variable initializers. > > Fixes: 6e455f5dcdd1 ("drm/crtc: fix uninitialized variable use") >

Re: [PATCH] drm/crtc: fix uninitialized variable use even harder

2024-02-13 Thread Dmitry Baryshkov
On Mon, 12 Feb 2024 at 23:55, Rob Clark wrote: > > From: Rob Clark > > DRM_MODESET_LOCK_ALL_BEGIN() has a hidden trap-door (aka retry loop), > which means we can't rely too much on variable initializers. > > Fixes: 6e455f5dcdd1 ("drm/crtc: fix uninitialized variable use") > Signed-off-by: Rob

Re: [PATCH] drm/crtc: fix uninitialized variable use even harder

2024-02-12 Thread Abhinav Kumar
On 2/12/2024 1:55 PM, Rob Clark wrote: From: Rob Clark DRM_MODESET_LOCK_ALL_BEGIN() has a hidden trap-door (aka retry loop), which means we can't rely too much on variable initializers. Fixes: 6e455f5dcdd1 ("drm/crtc: fix uninitialized variable use") Signed-off-by: Rob Clark --- I have

Re: [PATCH] drm/crtc: fix uninitialized variable use even harder

2024-02-12 Thread Rob Clark
On Mon, Feb 12, 2024 at 1:55 PM Rob Clark wrote: > > From: Rob Clark > > DRM_MODESET_LOCK_ALL_BEGIN() has a hidden trap-door (aka retry loop), > which means we can't rely too much on variable initializers. > > Fixes: 6e455f5dcdd1 ("drm/crtc: fix uninitialized variable use") > Signed-off-by: Rob

[PATCH] drm/crtc: fix uninitialized variable use even harder

2024-02-12 Thread Rob Clark
From: Rob Clark DRM_MODESET_LOCK_ALL_BEGIN() has a hidden trap-door (aka retry loop), which means we can't rely too much on variable initializers. Fixes: 6e455f5dcdd1 ("drm/crtc: fix uninitialized variable use") Signed-off-by: Rob Clark --- I have mixed feelings about