Re: [PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing

2020-10-21 Thread Shawn Guo
On Mon, Oct 19, 2020 at 05:48:29PM +0200, Daniel Vetter wrote: > On Fri, Oct 16, 2020 at 07:46:41PM +0800, Shawn Guo wrote: > > Indeed! Adding drm_crtc_vblank_reset() into driver crtc reset hook > > removes the WARNING for me. Really appreciate your comments, Daniel! > > This should work automat

Re: [PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing

2020-10-19 Thread Daniel Vetter
On Fri, Oct 16, 2020 at 07:46:41PM +0800, Shawn Guo wrote: > On Fri, Oct 16, 2020 at 11:30:04AM +0200, Daniel Vetter wrote: > > On Fri, Oct 16, 2020 at 10:54 AM Shawn Guo wrote: > > > > > > On Fri, Oct 16, 2020 at 09:58:46AM +0200, Daniel Vetter wrote: > > > > On Fri, Oct 16, 2020 at 9:13 AM Shawn

Re: [PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing

2020-10-16 Thread Shawn Guo
On Fri, Oct 16, 2020 at 11:30:04AM +0200, Daniel Vetter wrote: > On Fri, Oct 16, 2020 at 10:54 AM Shawn Guo wrote: > > > > On Fri, Oct 16, 2020 at 09:58:46AM +0200, Daniel Vetter wrote: > > > On Fri, Oct 16, 2020 at 9:13 AM Shawn Guo wrote: > > > > > > > > Commit 5caa0feafcc6 ("drm/vblank: Lock d

Re: [PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing

2020-10-16 Thread Daniel Vetter
On Fri, Oct 16, 2020 at 10:54 AM Shawn Guo wrote: > > On Fri, Oct 16, 2020 at 09:58:46AM +0200, Daniel Vetter wrote: > > On Fri, Oct 16, 2020 at 9:13 AM Shawn Guo wrote: > > > > > > Commit 5caa0feafcc6 ("drm/vblank: Lock down vblank->hwmode more") added > > > WARN_ON_ONCE() for atomic drivers to

Re: [PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing

2020-10-16 Thread Shawn Guo
On Fri, Oct 16, 2020 at 09:58:46AM +0200, Daniel Vetter wrote: > On Fri, Oct 16, 2020 at 9:13 AM Shawn Guo wrote: > > > > Commit 5caa0feafcc6 ("drm/vblank: Lock down vblank->hwmode more") added > > WARN_ON_ONCE() for atomic drivers to warn the case that vsync is enabled > > before a mode has been

Re: [PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing

2020-10-16 Thread Daniel Vetter
On Fri, Oct 16, 2020 at 9:13 AM Shawn Guo wrote: > > Commit 5caa0feafcc6 ("drm/vblank: Lock down vblank->hwmode more") added > WARN_ON_ONCE() for atomic drivers to warn the case that vsync is enabled > before a mode has been set on CRTC. This happens sometimes during the > initial mode setting of

[PATCH] drm/drm_vblank: use drm_warn_once() to warn undefined mode timing

2020-10-16 Thread Shawn Guo
Commit 5caa0feafcc6 ("drm/vblank: Lock down vblank->hwmode more") added WARN_ON_ONCE() for atomic drivers to warn the case that vsync is enabled before a mode has been set on CRTC. This happens sometimes during the initial mode setting of a CRTC. It also happens on Android running HWC2 backed wit