Re: [PATCH] drm/fb-helper: Scale back depth to supported maximum

2018-02-19 Thread Daniel Vetter
On Fri, Feb 02, 2018 at 04:03:43PM +0200, Ville Syrjälä wrote: > On Fri, Feb 02, 2018 at 02:56:30PM +0100, Linus Walleij wrote: > > On Thu, Feb 1, 2018 at 2:19 PM, Ville Syrjälä > > wrote: > > > [Me] > > >> + /* > > >> + * If we run into a situation where,

Re: [PATCH] drm/fb-helper: Scale back depth to supported maximum

2018-02-02 Thread Ville Syrjälä
On Fri, Feb 02, 2018 at 02:56:30PM +0100, Linus Walleij wrote: > On Thu, Feb 1, 2018 at 2:19 PM, Ville Syrjälä > wrote: > > [Me] > >> + /* > >> + * If we run into a situation where, for example, the primary plane > >> + * supports RGBA5551 (16 bpp,

Re: [PATCH] drm/fb-helper: Scale back depth to supported maximum

2018-02-02 Thread Linus Walleij
On Thu, Feb 1, 2018 at 2:19 PM, Ville Syrjälä wrote: > [Me] >> + /* >> + * If we run into a situation where, for example, the primary plane >> + * supports RGBA5551 (16 bpp, depth 15) but not RGB565 (16 bpp, depth >> + * 16) we need to scale down

Re: [PATCH] drm/fb-helper: Scale back depth to supported maximum

2018-02-01 Thread Noralf Trønnes
Den 01.02.2018 16.15, skrev Noralf Trønnes: Den 01.02.2018 14.19, skrev Ville Syrjälä: On Thu, Feb 01, 2018 at 02:04:46PM +0100, Linus Walleij wrote: The following happened when migrating an old fbdev driver to DRM: The Integrator/CP PL111 supports 16BPP but only ARGB1555/ABGR1555 or

Re: [PATCH] drm/fb-helper: Scale back depth to supported maximum

2018-02-01 Thread Noralf Trønnes
Den 01.02.2018 14.19, skrev Ville Syrjälä: On Thu, Feb 01, 2018 at 02:04:46PM +0100, Linus Walleij wrote: The following happened when migrating an old fbdev driver to DRM: The Integrator/CP PL111 supports 16BPP but only ARGB1555/ABGR1555 or XRGB1555/XBGR1555 i.e. the maximum depth is 15.

Re: [PATCH] drm/fb-helper: Scale back depth to supported maximum

2018-02-01 Thread Ville Syrjälä
On Thu, Feb 01, 2018 at 02:04:46PM +0100, Linus Walleij wrote: > The following happened when migrating an old fbdev driver to DRM: > > The Integrator/CP PL111 supports 16BPP but only ARGB1555/ABGR1555 > or XRGB1555/XBGR1555 i.e. the maximum depth is 15. > > This makes the initialization of the

[PATCH] drm/fb-helper: Scale back depth to supported maximum

2018-02-01 Thread Linus Walleij
The following happened when migrating an old fbdev driver to DRM: The Integrator/CP PL111 supports 16BPP but only ARGB1555/ABGR1555 or XRGB1555/XBGR1555 i.e. the maximum depth is 15. This makes the initialization of the framebuffer fail since the code in drm_fb_helper_single_fb_probe() assigns