Re: [PATCH] drm/fb-helper: generic: Fix drm_fbdev_client_restore()

2019-01-29 Thread Noralf Trønnes
Den 28.01.2019 12.49, skrev Gerd Hoffmann: > On Mon, Jan 28, 2019 at 11:25:28AM +0100, Noralf Trønnes wrote: >> >> >> Den 28.01.2019 07.48, skrev Gerd Hoffmann: Fix by using drm_fb_helper_lastclose() which checks if fbdev is in use. >>> static int drm_fbdev_client_restore(struct drm_cl

Re: [PATCH] drm/fb-helper: generic: Fix drm_fbdev_client_restore()

2019-01-28 Thread Gerd Hoffmann
On Mon, Jan 28, 2019 at 11:25:28AM +0100, Noralf Trønnes wrote: > > > Den 28.01.2019 07.48, skrev Gerd Hoffmann: > >> Fix by using drm_fb_helper_lastclose() which checks if fbdev is in use. > > > >> static int drm_fbdev_client_restore(struct drm_client_dev *client) > >> { > >> - struct drm_fb

Re: [PATCH] drm/fb-helper: generic: Fix drm_fbdev_client_restore()

2019-01-28 Thread Noralf Trønnes
Den 28.01.2019 07.48, skrev Gerd Hoffmann: >> Fix by using drm_fb_helper_lastclose() which checks if fbdev is in use. > >> static int drm_fbdev_client_restore(struct drm_client_dev *client) >> { >> -struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client); >> - >> -drm_fb_he

Re: [PATCH] drm/fb-helper: generic: Fix drm_fbdev_client_restore()

2019-01-27 Thread Gerd Hoffmann
> Fix by using drm_fb_helper_lastclose() which checks if fbdev is in use. > static int drm_fbdev_client_restore(struct drm_client_dev *client) > { > - struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client); > - > - drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper); > +

[PATCH] drm/fb-helper: generic: Fix drm_fbdev_client_restore()

2019-01-25 Thread Noralf Trønnes
If fbdev setup has failed, lastclose will give a NULL pointer deref: [ 77.794295] [drm:drm_lastclose] [ 77.794414] [drm:drm_lastclose] driver lastclose completed [ 77.794660] Unable to handle kernel NULL pointer dereference at virtual address 0014 [ 77.809460] pgd = b376b71b [ 77.81