Re: [PATCH] drm/msm/dpu: tidy up some error checking

2023-06-08 Thread Dan Carpenter
On Thu, Jun 08, 2023 at 02:26:14AM +0300, Dmitry Baryshkov wrote: > On 07/06/2023 17:42, Dan Carpenter wrote: > > On Tue, Jun 06, 2023 at 10:23:46PM +0200, Marijn Suijten wrote: > > > > @@ -359,8 +359,8 @@ static void dpu_encoder_phys_cmd_tearcheck_config( > > > > * frequency divided by

Re: [PATCH] drm/msm/dpu: tidy up some error checking

2023-06-07 Thread Dmitry Baryshkov
On Tue, 06 Jun 2023 11:33:03 +0300, Dan Carpenter wrote: > The "vsync_hz" variable is unsigned int so it can't be less > than zero. The dpu_kms_get_clk_rate() function used to return a u64 > but I previously changed it to return an unsigned long and zero on > error so it matches clk_get_rate().

Re: [PATCH] drm/msm/dpu: tidy up some error checking

2023-06-07 Thread Dmitry Baryshkov
On 07/06/2023 17:42, Dan Carpenter wrote: On Tue, Jun 06, 2023 at 10:23:46PM +0200, Marijn Suijten wrote: @@ -359,8 +359,8 @@ static void dpu_encoder_phys_cmd_tearcheck_config( * frequency divided by the no. of rows (lines) in the LCDpanel. */ vsync_hz =

Re: [PATCH] drm/msm/dpu: tidy up some error checking

2023-06-07 Thread Dan Carpenter
On Tue, Jun 06, 2023 at 10:23:46PM +0200, Marijn Suijten wrote: > > @@ -359,8 +359,8 @@ static void dpu_encoder_phys_cmd_tearcheck_config( > > * frequency divided by the no. of rows (lines) in the LCDpanel. > > */ > > vsync_hz = dpu_kms_get_clk_rate(dpu_kms, "vsync"); > > - if

Re: [PATCH] drm/msm/dpu: tidy up some error checking

2023-06-06 Thread Marijn Suijten
On 2023-06-06 11:33:03, Dan Carpenter wrote: > The "vsync_hz" variable is unsigned int so it can't be less > than zero. The dpu_kms_get_clk_rate() function used to return a u64 > but I previously changed it to return an unsigned long and zero on > error so it matches clk_get_rate(). > > Change

Re: [PATCH] drm/msm/dpu: tidy up some error checking

2023-06-06 Thread Abhinav Kumar
On 6/6/2023 1:33 AM, Dan Carpenter wrote: The "vsync_hz" variable is unsigned int so it can't be less than zero. The dpu_kms_get_clk_rate() function used to return a u64 but I previously changed it to return an unsigned long and zero on error so it matches clk_get_rate(). Change the

[PATCH] drm/msm/dpu: tidy up some error checking

2023-06-06 Thread Dan Carpenter
The "vsync_hz" variable is unsigned int so it can't be less than zero. The dpu_kms_get_clk_rate() function used to return a u64 but I previously changed it to return an unsigned long and zero on error so it matches clk_get_rate(). Change the "vsync_hz" type to unsigned long as well and change