Re: [PATCH] drm/nouveau/subdev/bus: Ratelimit logging for fault errors

2022-05-04 Thread Lyude Paul
Mhhh - looks like it goes far back enough I probably should just Cc it without a version tag and see how far it applies for greg. Will do that On Wed, 2022-05-04 at 14:49 -0400, Lyude Paul wrote: > On Tue, 2022-05-03 at 21:23 +0200, Karol Herbst wrote: > > not able to hit any error on my

Re: [PATCH] drm/nouveau/subdev/bus: Ratelimit logging for fault errors

2022-05-04 Thread Lyude Paul
On Tue, 2022-05-03 at 21:23 +0200, Karol Herbst wrote: > not able to hit any error on my machine, but regardless: > > Reviewed-by: Karol Herbst > > I suspect there are more places where we could put it, but we can add > those later. > > Anyway, I think it's valuable to push it through fixes,

Re: [PATCH] drm/nouveau/subdev/bus: Ratelimit logging for fault errors

2022-05-03 Thread Karol Herbst
Actually, there is another place we have to put this, we can spam "SCHED_ERROR" things which are triggered within multiple drivers/gpu/drm/nouveau/nvkm/engine/fifo/ files. On Tue, May 3, 2022 at 9:23 PM Karol Herbst wrote: > > not able to hit any error on my machine, but regardless: > >

Re: [PATCH] drm/nouveau/subdev/bus: Ratelimit logging for fault errors

2022-05-03 Thread Karol Herbst
not able to hit any error on my machine, but regardless: Reviewed-by: Karol Herbst I suspect there are more places where we could put it, but we can add those later. Anyway, I think it's valuable to push it through fixes, not sure how far back we want to CC stable though. On Fri, Apr 29, 2022

Re: [PATCH] drm/nouveau/subdev/bus: Ratelimit logging for fault errors

2022-04-30 Thread Karol Herbst
On Sat, Apr 30, 2022 at 1:04 AM Lyude Paul wrote: > > On Sat, 2022-04-30 at 00:56 +0200, Karol Herbst wrote: > > On Fri, Apr 29, 2022 at 9:54 PM Lyude Paul wrote: > > > > > > There's plenty of ways to fudge the GPU when developing on nouveau by > > > mistake, some of which can result in nouveau

Re: [PATCH] drm/nouveau/subdev/bus: Ratelimit logging for fault errors

2022-04-29 Thread Lyude Paul
On Sat, 2022-04-30 at 00:56 +0200, Karol Herbst wrote: > On Fri, Apr 29, 2022 at 9:54 PM Lyude Paul wrote: > > > > There's plenty of ways to fudge the GPU when developing on nouveau by > > mistake, some of which can result in nouveau seriously spamming dmesg with > > fault errors. This can be

Re: [PATCH] drm/nouveau/subdev/bus: Ratelimit logging for fault errors

2022-04-29 Thread Karol Herbst
On Fri, Apr 29, 2022 at 9:54 PM Lyude Paul wrote: > > There's plenty of ways to fudge the GPU when developing on nouveau by > mistake, some of which can result in nouveau seriously spamming dmesg with > fault errors. This can be somewhat annoying, as it can quickly overrun the > message buffer

[PATCH] drm/nouveau/subdev/bus: Ratelimit logging for fault errors

2022-04-29 Thread Lyude Paul
There's plenty of ways to fudge the GPU when developing on nouveau by mistake, some of which can result in nouveau seriously spamming dmesg with fault errors. This can be somewhat annoying, as it can quickly overrun the message buffer (or your terminal emulator's buffer) and get rid of actually