Re: [PATCH] drm/panfrost: Implement per FD address spaces

2019-08-10 Thread Steven Price
On 09/08/2019 04:01, Rob Herring wrote: [...] > I was worried too. It seems to be working pretty well though, but more > testing would be good. I don't think there are a lot of usecases that > use more AS than the h/w has (8 on T860), but I'm not sure. Yeah, 8 is overkill. Some GPUs only have 4

Re: [PATCH] drm/panfrost: Implement per FD address spaces

2019-08-10 Thread Steven Price
On 08/08/2019 23:29, Rob Herring wrote: > Up until now, a single shared GPU address space was used. This is not > ideal as there's no protection between processes and doesn't work for > supporting the same GPU/CPU VA feature. Most importantly, this will > hopefully mitigate Alyssa's fear of WebGL,

Re: [PATCH] drm/panfrost: Implement per FD address spaces

2019-08-09 Thread Rob Herring
On Fri, Aug 9, 2019 at 6:45 AM Steven Price wrote: > > On 09/08/2019 04:01, Rob Herring wrote: > [...] > > I was worried too. It seems to be working pretty well though, but more > > testing would be good. I don't think there are a lot of usecases that > > use more AS than the h/w has (8 on T860),

Re: [PATCH] drm/panfrost: Implement per FD address spaces

2019-08-09 Thread Rob Herring
cOn Fri, Aug 9, 2019 at 6:36 AM Steven Price wrote: > > On 08/08/2019 23:29, Rob Herring wrote: > > Up until now, a single shared GPU address space was used. This is not > > ideal as there's no protection between processes and doesn't work for > > supporting the same GPU/CPU VA feature. Most

Re: [PATCH] drm/panfrost: Implement per FD address spaces

2019-08-09 Thread Alyssa Rosenzweig
> @@ -448,6 +453,7 @@ static irqreturn_t panfrost_job_irq_handler(int irq, void > *data) > } > > if (status & JOB_INT_MASK_DONE(j)) { > + panfrost_mmu_as_put(pfdev, > >jobs[j]->file_priv->mmu); >

Re: [PATCH] drm/panfrost: Implement per FD address spaces

2019-08-09 Thread Tomeu Vizoso
On 8/9/19 5:01 AM, Rob Herring wrote: On Thu, Aug 8, 2019 at 5:11 PM Alyssa Rosenzweig wrote: @@ -448,6 +453,7 @@ static irqreturn_t panfrost_job_irq_handler(int irq, void *data) } if (status & JOB_INT_MASK_DONE(j)) { +

Re: [PATCH] drm/panfrost: Implement per FD address spaces

2019-08-08 Thread Rob Herring
On Thu, Aug 8, 2019 at 5:11 PM Alyssa Rosenzweig wrote: > > > @@ -448,6 +453,7 @@ static irqreturn_t panfrost_job_irq_handler(int irq, > > void *data) > > } > > > > if (status & JOB_INT_MASK_DONE(j)) { > > + panfrost_mmu_as_put(pfdev, > >

Re: [PATCH] drm/panfrost: Implement per FD address spaces

2019-08-08 Thread Rob Herring
On Thu, Aug 8, 2019 at 5:18 PM Matthew Auld wrote: > > On Thu, 8 Aug 2019 at 23:29, Rob Herring wrote: > > > > Up until now, a single shared GPU address space was used. This is not > > ideal as there's no protection between processes and doesn't work for > > supporting the same GPU/CPU VA

Re: [PATCH] drm/panfrost: Implement per FD address spaces

2019-08-08 Thread Matthew Auld
On Thu, 8 Aug 2019 at 23:29, Rob Herring wrote: > > Up until now, a single shared GPU address space was used. This is not > ideal as there's no protection between processes and doesn't work for > supporting the same GPU/CPU VA feature. Most importantly, this will > hopefully mitigate Alyssa's

[PATCH] drm/panfrost: Implement per FD address spaces

2019-08-08 Thread Rob Herring
Up until now, a single shared GPU address space was used. This is not ideal as there's no protection between processes and doesn't work for supporting the same GPU/CPU VA feature. Most importantly, this will hopefully mitigate Alyssa's fear of WebGL, whatever that is. Most of the changes here are