Re: [PATCH] drm/panthor: Add support for performance counters

2024-03-08 Thread Mihail Atanassov
Hi Adrián, Thanks for your patch. Liviu's already raised some concerns in the adjacent thread, so I'll try not to repeat them here. On 05/03/2024 16:58, Adrián Larumbe wrote: This brings in support for Panthor's HW performance counters and querying them from UM through a specific ioctl(). The

Re: [PATCH] drm/panthor: Add support for performance counters

2024-03-08 Thread Boris Brezillon
On Fri, 8 Mar 2024 17:02:15 + Liviu Dudau wrote: > On Fri, Mar 08, 2024 at 04:15:15PM +0100, Boris Brezillon wrote: > > On Fri, 8 Mar 2024 13:52:18 + > > Liviu Dudau wrote: > > > > > Hi Adrián, > > > > > > Thanks for the patch and appologies for taking a bit longer to respond, > > >

Re: [PATCH] drm/panthor: Add support for performance counters

2024-03-08 Thread Liviu Dudau
On Fri, Mar 08, 2024 at 04:15:15PM +0100, Boris Brezillon wrote: > On Fri, 8 Mar 2024 13:52:18 + > Liviu Dudau wrote: > > > Hi Adrián, > > > > Thanks for the patch and appologies for taking a bit longer to respond, > > I was trying to gather some internal Arm feedback before replying. > >

Re: [PATCH] drm/panthor: Add support for performance counters

2024-03-08 Thread Boris Brezillon
On Fri, 8 Mar 2024 13:52:18 + Liviu Dudau wrote: > Hi Adrián, > > Thanks for the patch and appologies for taking a bit longer to respond, > I was trying to gather some internal Arm feedback before replying. > > On Tue, Mar 05, 2024 at 04:58:16PM +, Adrián Larumbe wrote: > > This brings

Re: [PATCH] drm/panthor: Add support for performance counters

2024-03-08 Thread Liviu Dudau
Hi Adrián, Thanks for the patch and appologies for taking a bit longer to respond, I was trying to gather some internal Arm feedback before replying. On Tue, Mar 05, 2024 at 04:58:16PM +, Adrián Larumbe wrote: > This brings in support for Panthor's HW performance counters and querying > them

[PATCH] drm/panthor: Add support for performance counters

2024-03-05 Thread Adrián Larumbe
This brings in support for Panthor's HW performance counters and querying them from UM through a specific ioctl(). The code is inspired by existing functionality for the Panfrost driver, with some noteworthy differences: - Sample size is now reported by the firmware rather than having to reckon