Re: [PATCH] drm/prime: Unbreak virtgpu dma-buf export

2024-03-28 Thread Rob Clark
On Thu, Mar 28, 2024 at 11:54 AM Simon Ser wrote: > > On Thursday, March 28th, 2024 at 19:47, Rob Clark wrote: > > > any chance I could talk you into pushing to drm-misc-fixes? > > Oh sorry, I thought you had access… Pushed with a minor edit to remove > unnecessary parentheses to make checkpatch

Re: [PATCH] drm/prime: Unbreak virtgpu dma-buf export

2024-03-28 Thread Simon Ser
On Thursday, March 28th, 2024 at 19:47, Rob Clark wrote: > any chance I could talk you into pushing to drm-misc-fixes? Oh sorry, I thought you had access… Pushed with a minor edit to remove unnecessary parentheses to make checkpatch happy!

Re: [PATCH] drm/prime: Unbreak virtgpu dma-buf export

2024-03-28 Thread Rob Clark
On Tue, Mar 26, 2024 at 2:15 AM Simon Ser wrote: > > Makes sense to me! > > Reviewed-by: Simon Ser Thanks.. any chance I could talk you into pushing to drm-misc-fixes? BR, -R

Re: [PATCH] drm/prime: Unbreak virtgpu dma-buf export

2024-03-27 Thread Dominik Behr
It is mapped, via iommu interface (vfio-iommu) when map_dma is called. -- Dominik On Mon, Mar 25, 2024 at 7:38 PM Rob Clark wrote: > > This is actually a bit concerning.. importing a host page backed > buffer without guest mapping into a passthru device probably doesn't > work and should be

Re: [PATCH] drm/prime: Unbreak virtgpu dma-buf export

2024-03-26 Thread Simon Ser
Makes sense to me! Reviewed-by: Simon Ser

Re: [PATCH] drm/prime: Unbreak virtgpu dma-buf export

2024-03-25 Thread Rob Clark
This is actually a bit concerning.. importing a host page backed buffer without guest mapping into a passthru device probably doesn't work and should be rejected earlier. I do think we should relax the restriction (either taking my patch or reverting the commit it fixes) until we work this out

Re: [PATCH] drm/prime: Unbreak virtgpu dma-buf export

2024-03-25 Thread Dominik Behr
It also fixes importing virtgpu blobs into real hardware, for instance amdgpu for DRI_PRIME rendering. On Fri, Mar 22, 2024 at 2:48 PM Rob Clark wrote: > > From: Rob Clark > > virtgpu "vram" GEM objects do not implement obj->get_sg_table(). But > they also don't use drm_gem_map_dma_buf(). In

Re: [PATCH] drm/prime: Unbreak virtgpu dma-buf export

2024-03-25 Thread Dominik Behr
It also fixes importing virtgpu blobs into real hardware, for instance amdgpu for DRI_PRIME rendering. On Fri, Mar 22, 2024 at 2:48 PM Rob Clark wrote: > From: Rob Clark > > virtgpu "vram" GEM objects do not implement obj->get_sg_table(). But > they also don't use drm_gem_map_dma_buf(). In

[PATCH] drm/prime: Unbreak virtgpu dma-buf export

2024-03-22 Thread Rob Clark
From: Rob Clark virtgpu "vram" GEM objects do not implement obj->get_sg_table(). But they also don't use drm_gem_map_dma_buf(). In fact they may not even have guest visible pages. But it is perfectly fine to export and share with other virtual devices. Reported-by: Dominik Behr Fixes: