Re: [PATCH] drm/radeon: fix UPLL_REF_DIV_MASK definition
Dear Christian, Am Montag, den 29.04.2013, 10:20 +0200 schrieb Christian König: From: Christian König christian.koe...@amd.com Stupid copy paste error over all generations. does this fix an error or was this found just by reading the code? Could please you add such information to commit message in the future? That would be awesome. […] Thanks, Paul ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm/radeon: fix UPLL_REF_DIV_MASK definition
Dear Christian, Am Montag, den 29.04.2013, 10:20 +0200 schrieb Christian K?nig: > From: Christian K?nig > > Stupid copy & paste error over all generations. does this fix an error or was this found just by reading the code? Could please you add such information to commit message in the future? That would be awesome. [?] Thanks, Paul
[PATCH] drm/radeon: fix UPLL_REF_DIV_MASK definition
On Mon, Apr 29, 2013 at 4:20 AM, Christian K?nig wrote: > From: Christian K?nig > > Stupid copy & paste error over all generations. Applied to my tree. Alex > > Signed-off-by: Christian K?nig > --- > drivers/gpu/drm/radeon/evergreend.h |2 +- > drivers/gpu/drm/radeon/rv770d.h |2 +- > drivers/gpu/drm/radeon/sid.h|2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/evergreend.h > b/drivers/gpu/drm/radeon/evergreend.h > index d9a0054..75c0563 100644 > --- a/drivers/gpu/drm/radeon/evergreend.h > +++ b/drivers/gpu/drm/radeon/evergreend.h > @@ -59,7 +59,7 @@ > # define UPLL_SLEEP_MASK 0x0002 > # define UPLL_BYPASS_EN_MASK 0x0004 > # define UPLL_CTLREQ_MASK 0x0008 > -# define UPLL_REF_DIV_MASK0x001F > +# define UPLL_REF_DIV_MASK0x003F > # define UPLL_VCO_MODE_MASK 0x0200 > # define UPLL_CTLACK_MASK 0x4000 > # define UPLL_CTLACK2_MASK0x8000 > diff --git a/drivers/gpu/drm/radeon/rv770d.h b/drivers/gpu/drm/radeon/rv770d.h > index 6a52b20..85b1626 100644 > --- a/drivers/gpu/drm/radeon/rv770d.h > +++ b/drivers/gpu/drm/radeon/rv770d.h > @@ -45,7 +45,7 @@ > # define UPLL_BYPASS_EN_MASK 0x0004 > # define UPLL_CTLREQ_MASK 0x0008 > # define UPLL_REF_DIV(x) ((x) << 16) > -# define UPLL_REF_DIV_MASK0x001F > +# define UPLL_REF_DIV_MASK0x003F > # define UPLL_CTLACK_MASK 0x4000 > # define UPLL_CTLACK2_MASK0x8000 > #define CG_UPLL_FUNC_CNTL_20x71c > diff --git a/drivers/gpu/drm/radeon/sid.h b/drivers/gpu/drm/radeon/sid.h > index 042b91d..222877b 100644 > --- a/drivers/gpu/drm/radeon/sid.h > +++ b/drivers/gpu/drm/radeon/sid.h > @@ -36,7 +36,7 @@ > # define UPLL_BYPASS_EN_MASK 0x0004 > # define UPLL_CTLREQ_MASK 0x0008 > # define UPLL_VCO_MODE_MASK 0x0600 > -# define UPLL_REF_DIV_MASK0x001F > +# define UPLL_REF_DIV_MASK0x003F > # define UPLL_CTLACK_MASK 0x4000 > # define UPLL_CTLACK2_MASK0x8000 > #defineCG_UPLL_FUNC_CNTL_2 0x638 > -- > 1.7.10.4 >
[PATCH] drm/radeon: fix UPLL_REF_DIV_MASK definition
From: Christian König christian.koe...@amd.com Stupid copy paste error over all generations. Signed-off-by: Christian König christian.koe...@amd.com --- drivers/gpu/drm/radeon/evergreend.h |2 +- drivers/gpu/drm/radeon/rv770d.h |2 +- drivers/gpu/drm/radeon/sid.h|2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/evergreend.h b/drivers/gpu/drm/radeon/evergreend.h index d9a0054..75c0563 100644 --- a/drivers/gpu/drm/radeon/evergreend.h +++ b/drivers/gpu/drm/radeon/evergreend.h @@ -59,7 +59,7 @@ # define UPLL_SLEEP_MASK 0x0002 # define UPLL_BYPASS_EN_MASK 0x0004 # define UPLL_CTLREQ_MASK 0x0008 -# define UPLL_REF_DIV_MASK0x001F +# define UPLL_REF_DIV_MASK0x003F # define UPLL_VCO_MODE_MASK 0x0200 # define UPLL_CTLACK_MASK 0x4000 # define UPLL_CTLACK2_MASK0x8000 diff --git a/drivers/gpu/drm/radeon/rv770d.h b/drivers/gpu/drm/radeon/rv770d.h index 6a52b20..85b1626 100644 --- a/drivers/gpu/drm/radeon/rv770d.h +++ b/drivers/gpu/drm/radeon/rv770d.h @@ -45,7 +45,7 @@ # define UPLL_BYPASS_EN_MASK 0x0004 # define UPLL_CTLREQ_MASK 0x0008 # define UPLL_REF_DIV(x) ((x) 16) -# define UPLL_REF_DIV_MASK0x001F +# define UPLL_REF_DIV_MASK0x003F # define UPLL_CTLACK_MASK 0x4000 # define UPLL_CTLACK2_MASK0x8000 #define CG_UPLL_FUNC_CNTL_20x71c diff --git a/drivers/gpu/drm/radeon/sid.h b/drivers/gpu/drm/radeon/sid.h index 042b91d..222877b 100644 --- a/drivers/gpu/drm/radeon/sid.h +++ b/drivers/gpu/drm/radeon/sid.h @@ -36,7 +36,7 @@ # define UPLL_BYPASS_EN_MASK 0x0004 # define UPLL_CTLREQ_MASK 0x0008 # define UPLL_VCO_MODE_MASK 0x0600 -# define UPLL_REF_DIV_MASK0x001F +# define UPLL_REF_DIV_MASK0x003F # define UPLL_CTLACK_MASK 0x4000 # define UPLL_CTLACK2_MASK0x8000 #defineCG_UPLL_FUNC_CNTL_2 0x638 -- 1.7.10.4 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/radeon: fix UPLL_REF_DIV_MASK definition
On Mon, Apr 29, 2013 at 4:20 AM, Christian König deathsim...@vodafone.de wrote: From: Christian König christian.koe...@amd.com Stupid copy paste error over all generations. Applied to my tree. Alex Signed-off-by: Christian König christian.koe...@amd.com --- drivers/gpu/drm/radeon/evergreend.h |2 +- drivers/gpu/drm/radeon/rv770d.h |2 +- drivers/gpu/drm/radeon/sid.h|2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/evergreend.h b/drivers/gpu/drm/radeon/evergreend.h index d9a0054..75c0563 100644 --- a/drivers/gpu/drm/radeon/evergreend.h +++ b/drivers/gpu/drm/radeon/evergreend.h @@ -59,7 +59,7 @@ # define UPLL_SLEEP_MASK 0x0002 # define UPLL_BYPASS_EN_MASK 0x0004 # define UPLL_CTLREQ_MASK 0x0008 -# define UPLL_REF_DIV_MASK0x001F +# define UPLL_REF_DIV_MASK0x003F # define UPLL_VCO_MODE_MASK 0x0200 # define UPLL_CTLACK_MASK 0x4000 # define UPLL_CTLACK2_MASK0x8000 diff --git a/drivers/gpu/drm/radeon/rv770d.h b/drivers/gpu/drm/radeon/rv770d.h index 6a52b20..85b1626 100644 --- a/drivers/gpu/drm/radeon/rv770d.h +++ b/drivers/gpu/drm/radeon/rv770d.h @@ -45,7 +45,7 @@ # define UPLL_BYPASS_EN_MASK 0x0004 # define UPLL_CTLREQ_MASK 0x0008 # define UPLL_REF_DIV(x) ((x) 16) -# define UPLL_REF_DIV_MASK0x001F +# define UPLL_REF_DIV_MASK0x003F # define UPLL_CTLACK_MASK 0x4000 # define UPLL_CTLACK2_MASK0x8000 #define CG_UPLL_FUNC_CNTL_20x71c diff --git a/drivers/gpu/drm/radeon/sid.h b/drivers/gpu/drm/radeon/sid.h index 042b91d..222877b 100644 --- a/drivers/gpu/drm/radeon/sid.h +++ b/drivers/gpu/drm/radeon/sid.h @@ -36,7 +36,7 @@ # define UPLL_BYPASS_EN_MASK 0x0004 # define UPLL_CTLREQ_MASK 0x0008 # define UPLL_VCO_MODE_MASK 0x0600 -# define UPLL_REF_DIV_MASK0x001F +# define UPLL_REF_DIV_MASK0x003F # define UPLL_CTLACK_MASK 0x4000 # define UPLL_CTLACK2_MASK0x8000 #defineCG_UPLL_FUNC_CNTL_2 0x638 -- 1.7.10.4 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
