Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

2018-02-23 Thread Christian König
Hi Ben, I mentioned the HD 5450 purely as a matter of archeological interest. Ok, in that case looking at the lspci -tv output doesn't tell us anything new. I suspected, but couldn't prove, that the problem might have something to do with the bridge (IBM POWER8 Host Bridge (PHB3)). In that

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

2018-02-23 Thread Ben Crocker
Hi Christian, Michel, Alex, et al., I mentioned the HD 5450 purely as a matter of archeological interest. Back to the FirePro 2270 and Embedded Radeon E6465: I've attached text from both "lspci -tv" and "lspci -v." Actually I'm attaching a couple of different "lspci -v" outputs, one with the Fir

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

2018-02-22 Thread Christian König
Am 22.02.2018 um 18:56 schrieb Michel Dänzer: On 2018-02-22 06:37 PM, Ben Crocker wrote: One of my colleagues did discover a "Radeon HG 5450 PCI" from February 2010 which did, apparently, have a Cedar GPU and very definitely had a (plain old) PCI connector. There must be a PCIe-to-PCI bridge on

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

2018-02-22 Thread Alex Deucher
On Thu, Feb 22, 2018 at 5:52 PM, Ben Crocker wrote: > In radeon_device_init, set the need_dma32 flag for Cedar chips > (e.g. FirePro 2270). This fixes, or at least works around, a bug > on PowerPC exposed by last year's commits > > 8e3f1b1d8255105f31556aacf8aeb6071b00d469 (Russell Currey) > > and

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

2018-02-22 Thread Michel Dänzer
On 2018-02-22 06:37 PM, Ben Crocker wrote: > One of my colleagues did discover a "Radeon HG 5450 PCI" from February > 2010 which did, apparently, have a Cedar GPU and very definitely had a > (plain old) PCI connector. There must be a PCIe-to-PCI bridge on that board. The GPU itself is always PCIe,

[PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

2018-02-22 Thread Ben Crocker
In radeon_device_init, set the need_dma32 flag for Cedar chips (e.g. FirePro 2270). This fixes, or at least works around, a bug on PowerPC exposed by last year's commits 8e3f1b1d8255105f31556aacf8aeb6071b00d469 (Russell Currey) and 253fd51e2f533552ae35a0c661705da6c4842c1b (Alistair Popple) whi

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

2018-02-22 Thread Ben Crocker
One of my colleagues did discover a "Radeon HG 5450 PCI" from February 2010 which did, apparently, have a Cedar GPU and very definitely had a (plain old) PCI connector. But I take your point, and will just drop the PCI/PCIE check. On Thu, Feb 22, 2018 at 12:04 PM, Michel Dänzer wrote: > On 201

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

2018-02-22 Thread Michel Dänzer
On 2018-02-22 10:57 PM, Ben Crocker wrote: > In radeon_device_init, set the need_dma32 flag for Cedar chips > (e.g. FirePro 2270). This fixes, or at least works around, a bug > on PowerPC exposed by last year's commits > > 8e3f1b1d8255105f31556aacf8aeb6071b00d469 (Russell Currey) > > and > > 25

[PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

2018-02-22 Thread Ben Crocker
In radeon_device_init, set the need_dma32 flag for Cedar chips (e.g. FirePro 2270). This fixes, or at least works around, a bug on PowerPC exposed by last year's commits 8e3f1b1d8255105f31556aacf8aeb6071b00d469 (Russell Currey) and 253fd51e2f533552ae35a0c661705da6c4842c1b (Alistair Popple) whi

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

2018-02-22 Thread Alex Deucher
On Thu, Feb 22, 2018 at 4:51 PM, Ben Crocker wrote: > In radeon_device_init, set the need_dma32 flag for Cedar chips > (e.g. FirePro 2270). This fixes, or at least works around, a bug > on PowerPC exposed by last year's commits > > 8e3f1b1d8255105f31556aacf8aeb6071b00d469 (Russell Currey) > > and

[PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE

2018-02-22 Thread Ben Crocker
In radeon_device_init, set the need_dma32 flag for Cedar chips (e.g. FirePro 2270). This fixes, or at least works around, a bug on PowerPC exposed by last year's commits 8e3f1b1d8255105f31556aacf8aeb6071b00d469 (Russell Currey) and 253fd51e2f533552ae35a0c661705da6c4842c1b (Alistair Popple) whi

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar

2018-02-22 Thread Alex Deucher
On Thu, Feb 22, 2018 at 11:45 AM, Ben Crocker wrote: > I considered that, but I'm only equipped to test on a few cards--the ones > IBM is interested in. > So this Cedar-specific change fixes the problem on the FirePro 2270; the > other cards seem > perfectly capable of handling 40+ bit DMA address

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar

2018-02-22 Thread Ben Crocker
I considered that, but I'm only equipped to test on a few cards--the ones IBM is interested in. So this Cedar-specific change fixes the problem on the FirePro 2270; the other cards seem perfectly capable of handling 40+ bit DMA addresses on the Power8 platform. On Thu, Feb 22, 2018 at 11:07 AM, A

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar

2018-02-22 Thread Alex Deucher
On Thu, Feb 22, 2018 at 10:55 AM, Ben Crocker wrote: > Alex, Christian, et al. > > Thanks for your rapid response! > > I can certainly make the change PPC-only (#ifdef CONFIG_PPC64...) and I > think > that's the safest way to go right now. It makes the patch very specific to > Cedar > on PowerPC6

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar

2018-02-22 Thread Ben Crocker
Alex, Christian, et al. Thanks for your rapid response! I can certainly make the change PPC-only (#ifdef CONFIG_PPC64...) and I think that's the safest way to go right now. It makes the patch very specific to Cedar on PowerPC64, so it doesn't break anything that may have come to depend on Russel

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar

2018-02-21 Thread Christian König
Am 22.02.2018 um 03:05 schrieb Alex Deucher: On Wed, Feb 21, 2018 at 6:41 PM, Ben Crocker wrote: In radeon_device_init, set the need_dma32 flag for Cedar chips (e.g. FirePro 2270). This fixes, or at least works around, a bug on PowerPC exposed by last year's commits 8e3f1b1d8255105f31556aacf8

Re: [PATCH] drm/radeon: insist on 32-bit DMA for Cedar

2018-02-21 Thread Alex Deucher
On Wed, Feb 21, 2018 at 6:41 PM, Ben Crocker wrote: > In radeon_device_init, set the need_dma32 flag for Cedar chips > (e.g. FirePro 2270). This fixes, or at least works around, a bug > on PowerPC exposed by last year's commits > > 8e3f1b1d8255105f31556aacf8aeb6071b00d469 (Russell Currey) > > and

[PATCH] drm/radeon: insist on 32-bit DMA for Cedar

2018-02-21 Thread Ben Crocker
In radeon_device_init, set the need_dma32 flag for Cedar chips (e.g. FirePro 2270). This fixes, or at least works around, a bug on PowerPC exposed by last year's commits 8e3f1b1d8255105f31556aacf8aeb6071b00d469 (Russell Currey) and 253fd51e2f533552ae35a0c661705da6c4842c1b (Alistair Popple) whi