Re: [PATCH] drm/vmwgfx: Fix vmw_du_cursor_plane_atomic_check

2018-09-04 Thread Daniel Vetter
On Tue, Mar 27, 2018 at 5:15 PM, Thomas Hellstrom wrote: > On 03/27/2018 05:08 PM, Ville Syrjälä wrote: >> >> On Tue, Mar 27, 2018 at 04:26:17PM +0200, Thomas Hellstrom wrote: >>> >>> Use the correct helper and also return early on helper >>> success rather than on helper failure. >>> >>> Also exp

Re: [PATCH] drm/vmwgfx: Fix vmw_du_cursor_plane_atomic_check

2018-03-27 Thread Thomas Hellstrom
On 03/27/2018 05:08 PM, Ville Syrjälä wrote: On Tue, Mar 27, 2018 at 04:26:17PM +0200, Thomas Hellstrom wrote: Use the correct helper and also return early on helper success rather than on helper failure. Also explicitly return 0 in the case of no fb. Signed-off-by: Thomas Hellstrom Reported-

Re: [PATCH] drm/vmwgfx: Fix vmw_du_cursor_plane_atomic_check

2018-03-27 Thread Ville Syrjälä
On Tue, Mar 27, 2018 at 04:26:17PM +0200, Thomas Hellstrom wrote: > Use the correct helper and also return early on helper > success rather than on helper failure. > > Also explicitly return 0 in the case of no fb. > > Signed-off-by: Thomas Hellstrom > Reported-by: Dan Carpenter > Reported-by:

[PATCH] drm/vmwgfx: Fix vmw_du_cursor_plane_atomic_check

2018-03-27 Thread Thomas Hellstrom
Use the correct helper and also return early on helper success rather than on helper failure. Also explicitly return 0 in the case of no fb. Signed-off-by: Thomas Hellstrom Reported-by: Dan Carpenter Reported-by: Daniel Vetter --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 22 +++--