Re: [PATCH] drm/writeback: Delete drm_writeback_cleanup_job

2019-02-21 Thread Laurent Pinchart
Hi Brian, On Thu, Feb 21, 2019 at 09:34:10AM +, Brian Starkey wrote: > On Thu, Feb 21, 2019 at 10:19:35AM +0200, Laurent Pinchart wrote: > > Hi Daniel, > > > > Thank you for the patch. > > > > On Thu, Feb 21, 2019 at 12:24:01AM +0100, Daniel Vetter wrote: > >> No implementation, no callers.

Re: [PATCH] drm/writeback: Delete drm_writeback_cleanup_job

2019-02-21 Thread Laurent Pinchart
Hi Daniel, On Thu, Feb 21, 2019 at 10:30:24AM +0100, Daniel Vetter wrote: > On Thu, Feb 21, 2019 at 9:19 AM Laurent Pinchart > wrote: > > Hi Daniel, > > > > Thank you for the patch. > > > > On Thu, Feb 21, 2019 at 12:24:01AM +0100, Daniel Vetter wrote: > >> No implementation, no callers. > > > >

Re: [PATCH] drm/writeback: Delete drm_writeback_cleanup_job

2019-02-21 Thread Brian Starkey
On Thu, Feb 21, 2019 at 10:19:35AM +0200, Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > On Thu, Feb 21, 2019 at 12:24:01AM +0100, Daniel Vetter wrote: > > No implementation, no callers. > > The issue here isn't that the function is declared, but that it's not > defined.

Re: [PATCH] drm/writeback: Delete drm_writeback_cleanup_job

2019-02-21 Thread Daniel Vetter
On Thu, Feb 21, 2019 at 9:19 AM Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > On Thu, Feb 21, 2019 at 12:24:01AM +0100, Daniel Vetter wrote: > > No implementation, no callers. > > The issue here isn't that the function is declared, but that it's not > defined. Jobs are

Re: [PATCH] drm/writeback: Delete drm_writeback_cleanup_job

2019-02-21 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Thu, Feb 21, 2019 at 12:24:01AM +0100, Daniel Vetter wrote: > No implementation, no callers. The issue here isn't that the function is declared, but that it's not defined. Jobs are leaked when atomic commit fails (or when using test commits). I'm working

[PATCH] drm/writeback: Delete drm_writeback_cleanup_job

2019-02-20 Thread Daniel Vetter
No implementation, no callers. Cc: Brian Starkey Cc: Liviu Dudau Cc: Eric Anholt Signed-off-by: Daniel Vetter --- include/drm/drm_writeback.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h index 23df9d463003..f34895f7fcb1 100644