Re: [PATCH] drm: Remove unnecessary (void*) conversions

2023-05-28 Thread Su Hui 

On 2023/5/26 15:27, Christian König wrote:

Am 26.05.23 um 05:32 schrieb Su Hui:

Pointer variables of (void*) type do not require type cast.


Please split that up by subsystem/driver. Taking it through the misc 
tree might just cause merge conflicts.



Sorry for that, I will split it and send again.
Thanks for your reply!

Su Hui


Christian.



Signed-off-by: Su Hui 
---
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +-
  drivers/gpu/drm/amd/pm/amdgpu_pm.c    | 2 +-
  drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 ++--
  drivers/gpu/drm/nouveau/nouveau_debugfs.c | 2 +-
  drivers/gpu/drm/omapdrm/omap_debugfs.c    | 6 +++---
  drivers/gpu/drm/pl111/pl111_debugfs.c | 2 +-
  drivers/gpu/drm/qxl/qxl_debugfs.c | 4 ++--
  drivers/gpu/drm/tiny/arcpgu.c | 2 +-
  drivers/gpu/drm/ttm/ttm_resource.c    | 3 +--
  drivers/gpu/drm/virtio/virtgpu_debugfs.c  | 6 +++---
  drivers/gpu/drm/vmwgfx/ttm_object.c   | 5 ++---
  drivers/gpu/drm/vmwgfx/vmwgfx_gem.c   | 2 +-
  12 files changed, 19 insertions(+), 21 deletions(-)

diff --git 
a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c

index 827fcb4fb3b3..8a2c39927167 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
@@ -3312,7 +3312,7 @@ static ssize_t dtn_log_write(
    static int mst_topo_show(struct seq_file *m, void *unused)
  {
-    struct amdgpu_device *adev = (struct amdgpu_device *)m->private;
+    struct amdgpu_device *adev = m->private;
  struct drm_device *dev = adev_to_drm(adev);
  struct drm_connector *connector;
  struct drm_connector_list_iter conn_iter;
diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c 
b/drivers/gpu/drm/amd/pm/amdgpu_pm.c

index 58c2246918fd..e6c870bd307b 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -3671,7 +3671,7 @@ static void amdgpu_parse_cg_state(struct 
seq_file *m, u64 flags)
    static int amdgpu_debugfs_pm_info_show(struct seq_file *m, void 
*unused)

  {
-    struct amdgpu_device *adev = (struct amdgpu_device *)m->private;
+    struct amdgpu_device *adev = m->private;
  struct drm_device *dev = adev_to_drm(adev);
  u64 flags = 0;
  int r;
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c 
b/drivers/gpu/drm/etnaviv/etnaviv_drv.c

index 31a7f59ccb49..dd57f7164e9a 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -198,7 +198,7 @@ static int etnaviv_ring_show(struct etnaviv_gpu 
*gpu, struct seq_file *m)

    static int show_unlocked(struct seq_file *m, void *arg)
  {
-    struct drm_info_node *node = (struct drm_info_node *) m->private;
+    struct drm_info_node *node = m->private;
  struct drm_device *dev = node->minor->dev;
  int (*show)(struct drm_device *dev, struct seq_file *m) =
  node->info_ent->data;
@@ -208,7 +208,7 @@ static int show_unlocked(struct seq_file *m, void 
*arg)

    static int show_each_gpu(struct seq_file *m, void *arg)
  {
-    struct drm_info_node *node = (struct drm_info_node *) m->private;
+    struct drm_info_node *node = m->private;
  struct drm_device *dev = node->minor->dev;
  struct etnaviv_drm_private *priv = dev->dev_private;
  struct etnaviv_gpu *gpu;
diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c 
b/drivers/gpu/drm/nouveau/nouveau_debugfs.c

index 2a36d1ca8fda..96b59d5d68ed 100644
--- a/drivers/gpu/drm/nouveau/nouveau_debugfs.c
+++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
@@ -37,7 +37,7 @@
  static int
  nouveau_debugfs_vbios_image(struct seq_file *m, void *data)
  {
-    struct drm_info_node *node = (struct drm_info_node *) m->private;
+    struct drm_info_node *node = m->private;
  struct nouveau_drm *drm = nouveau_drm(node->minor->dev);
  int i;
  diff --git a/drivers/gpu/drm/omapdrm/omap_debugfs.c 
b/drivers/gpu/drm/omapdrm/omap_debugfs.c

index a3d470468e5b..a94ce502e152 100644
--- a/drivers/gpu/drm/omapdrm/omap_debugfs.c
+++ b/drivers/gpu/drm/omapdrm/omap_debugfs.c
@@ -19,7 +19,7 @@
    static int gem_show(struct seq_file *m, void *arg)
  {
-    struct drm_info_node *node = (struct drm_info_node *) m->private;
+    struct drm_info_node *node = m->private;
  struct drm_device *dev = node->minor->dev;
  struct omap_drm_private *priv = dev->dev_private;
  @@ -33,7 +33,7 @@ static int gem_show(struct seq_file *m, void *arg)
    static int mm_show(struct seq_file *m, void *arg)
  {
-    struct drm_info_node *node = (struct drm_info_node *) m->private;
+    struct drm_info_node *node = m->private;
  struct drm_device *dev = node->minor->dev;
  struct drm_printer p = drm_seq_file_printer(m);
  @@ -45,7 +45,7 @@ static int

[PATCH] drm: Remove unnecessary (void*) conversions

2023-05-26 Thread Su Hui 
Pointer variables of (void*) type do not require type cast.

Signed-off-by: Su Hui 
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +-
 drivers/gpu/drm/amd/pm/amdgpu_pm.c| 2 +-
 drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 ++--
 drivers/gpu/drm/nouveau/nouveau_debugfs.c | 2 +-
 drivers/gpu/drm/omapdrm/omap_debugfs.c| 6 +++---
 drivers/gpu/drm/pl111/pl111_debugfs.c | 2 +-
 drivers/gpu/drm/qxl/qxl_debugfs.c | 4 ++--
 drivers/gpu/drm/tiny/arcpgu.c | 2 +-
 drivers/gpu/drm/ttm/ttm_resource.c| 3 +--
 drivers/gpu/drm/virtio/virtgpu_debugfs.c  | 6 +++---
 drivers/gpu/drm/vmwgfx/ttm_object.c   | 5 ++---
 drivers/gpu/drm/vmwgfx/vmwgfx_gem.c   | 2 +-
 12 files changed, 19 insertions(+), 21 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
index 827fcb4fb3b3..8a2c39927167 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
@@ -3312,7 +3312,7 @@ static ssize_t dtn_log_write(
 
 static int mst_topo_show(struct seq_file *m, void *unused)
 {
-   struct amdgpu_device *adev = (struct amdgpu_device *)m->private;
+   struct amdgpu_device *adev = m->private;
struct drm_device *dev = adev_to_drm(adev);
struct drm_connector *connector;
struct drm_connector_list_iter conn_iter;
diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c 
b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index 58c2246918fd..e6c870bd307b 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -3671,7 +3671,7 @@ static void amdgpu_parse_cg_state(struct seq_file *m, u64 
flags)
 
 static int amdgpu_debugfs_pm_info_show(struct seq_file *m, void *unused)
 {
-   struct amdgpu_device *adev = (struct amdgpu_device *)m->private;
+   struct amdgpu_device *adev = m->private;
struct drm_device *dev = adev_to_drm(adev);
u64 flags = 0;
int r;
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c 
b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index 31a7f59ccb49..dd57f7164e9a 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -198,7 +198,7 @@ static int etnaviv_ring_show(struct etnaviv_gpu *gpu, 
struct seq_file *m)
 
 static int show_unlocked(struct seq_file *m, void *arg)
 {
-   struct drm_info_node *node = (struct drm_info_node *) m->private;
+   struct drm_info_node *node = m->private;
struct drm_device *dev = node->minor->dev;
int (*show)(struct drm_device *dev, struct seq_file *m) =
node->info_ent->data;
@@ -208,7 +208,7 @@ static int show_unlocked(struct seq_file *m, void *arg)
 
 static int show_each_gpu(struct seq_file *m, void *arg)
 {
-   struct drm_info_node *node = (struct drm_info_node *) m->private;
+   struct drm_info_node *node = m->private;
struct drm_device *dev = node->minor->dev;
struct etnaviv_drm_private *priv = dev->dev_private;
struct etnaviv_gpu *gpu;
diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c 
b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
index 2a36d1ca8fda..96b59d5d68ed 100644
--- a/drivers/gpu/drm/nouveau/nouveau_debugfs.c
+++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
@@ -37,7 +37,7 @@
 static int
 nouveau_debugfs_vbios_image(struct seq_file *m, void *data)
 {
-   struct drm_info_node *node = (struct drm_info_node *) m->private;
+   struct drm_info_node *node = m->private;
struct nouveau_drm *drm = nouveau_drm(node->minor->dev);
int i;
 
diff --git a/drivers/gpu/drm/omapdrm/omap_debugfs.c 
b/drivers/gpu/drm/omapdrm/omap_debugfs.c
index a3d470468e5b..a94ce502e152 100644
--- a/drivers/gpu/drm/omapdrm/omap_debugfs.c
+++ b/drivers/gpu/drm/omapdrm/omap_debugfs.c
@@ -19,7 +19,7 @@
 
 static int gem_show(struct seq_file *m, void *arg)
 {
-   struct drm_info_node *node = (struct drm_info_node *) m->private;
+   struct drm_info_node *node = m->private;
struct drm_device *dev = node->minor->dev;
struct omap_drm_private *priv = dev->dev_private;
 
@@ -33,7 +33,7 @@ static int gem_show(struct seq_file *m, void *arg)
 
 static int mm_show(struct seq_file *m, void *arg)
 {
-   struct drm_info_node *node = (struct drm_info_node *) m->private;
+   struct drm_info_node *node = m->private;
struct drm_device *dev = node->minor->dev;
struct drm_printer p = drm_seq_file_printer(m);
 
@@ -45,7 +45,7 @@ static int mm_show(struct seq_file *m, void *arg)
 #ifdef CONFIG_DRM_FBDEV_EMULATION
 static int fb_show(struct seq_file *m, void *arg)
 {
-   struct drm_info_node *node = (struct drm_info_node *) m->private;
+   struct drm_info_node *node = m->private;

Re: [PATCH] drm: Remove unnecessary (void*) conversions

2023-05-26 Thread Christian König 

Am 26.05.23 um 05:32 schrieb Su Hui:

Pointer variables of (void*) type do not require type cast.


Please split that up by subsystem/driver. Taking it through the misc 
tree might just cause merge conflicts.


Christian.



Signed-off-by: Su Hui 
---
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +-
  drivers/gpu/drm/amd/pm/amdgpu_pm.c| 2 +-
  drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 ++--
  drivers/gpu/drm/nouveau/nouveau_debugfs.c | 2 +-
  drivers/gpu/drm/omapdrm/omap_debugfs.c| 6 +++---
  drivers/gpu/drm/pl111/pl111_debugfs.c | 2 +-
  drivers/gpu/drm/qxl/qxl_debugfs.c | 4 ++--
  drivers/gpu/drm/tiny/arcpgu.c | 2 +-
  drivers/gpu/drm/ttm/ttm_resource.c| 3 +--
  drivers/gpu/drm/virtio/virtgpu_debugfs.c  | 6 +++---
  drivers/gpu/drm/vmwgfx/ttm_object.c   | 5 ++---
  drivers/gpu/drm/vmwgfx/vmwgfx_gem.c   | 2 +-
  12 files changed, 19 insertions(+), 21 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
index 827fcb4fb3b3..8a2c39927167 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
@@ -3312,7 +3312,7 @@ static ssize_t dtn_log_write(
  
  static int mst_topo_show(struct seq_file *m, void *unused)

  {
-   struct amdgpu_device *adev = (struct amdgpu_device *)m->private;
+   struct amdgpu_device *adev = m->private;
struct drm_device *dev = adev_to_drm(adev);
struct drm_connector *connector;
struct drm_connector_list_iter conn_iter;
diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c 
b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index 58c2246918fd..e6c870bd307b 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -3671,7 +3671,7 @@ static void amdgpu_parse_cg_state(struct seq_file *m, u64 
flags)
  
  static int amdgpu_debugfs_pm_info_show(struct seq_file *m, void *unused)

  {
-   struct amdgpu_device *adev = (struct amdgpu_device *)m->private;
+   struct amdgpu_device *adev = m->private;
struct drm_device *dev = adev_to_drm(adev);
u64 flags = 0;
int r;
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c 
b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index 31a7f59ccb49..dd57f7164e9a 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -198,7 +198,7 @@ static int etnaviv_ring_show(struct etnaviv_gpu *gpu, 
struct seq_file *m)
  
  static int show_unlocked(struct seq_file *m, void *arg)

  {
-   struct drm_info_node *node = (struct drm_info_node *) m->private;
+   struct drm_info_node *node = m->private;
struct drm_device *dev = node->minor->dev;
int (*show)(struct drm_device *dev, struct seq_file *m) =
node->info_ent->data;
@@ -208,7 +208,7 @@ static int show_unlocked(struct seq_file *m, void *arg)
  
  static int show_each_gpu(struct seq_file *m, void *arg)

  {
-   struct drm_info_node *node = (struct drm_info_node *) m->private;
+   struct drm_info_node *node = m->private;
struct drm_device *dev = node->minor->dev;
struct etnaviv_drm_private *priv = dev->dev_private;
struct etnaviv_gpu *gpu;
diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c 
b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
index 2a36d1ca8fda..96b59d5d68ed 100644
--- a/drivers/gpu/drm/nouveau/nouveau_debugfs.c
+++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.c
@@ -37,7 +37,7 @@
  static int
  nouveau_debugfs_vbios_image(struct seq_file *m, void *data)
  {
-   struct drm_info_node *node = (struct drm_info_node *) m->private;
+   struct drm_info_node *node = m->private;
struct nouveau_drm *drm = nouveau_drm(node->minor->dev);
int i;
  
diff --git a/drivers/gpu/drm/omapdrm/omap_debugfs.c b/drivers/gpu/drm/omapdrm/omap_debugfs.c

index a3d470468e5b..a94ce502e152 100644
--- a/drivers/gpu/drm/omapdrm/omap_debugfs.c
+++ b/drivers/gpu/drm/omapdrm/omap_debugfs.c
@@ -19,7 +19,7 @@
  
  static int gem_show(struct seq_file *m, void *arg)

  {
-   struct drm_info_node *node = (struct drm_info_node *) m->private;
+   struct drm_info_node *node = m->private;
struct drm_device *dev = node->minor->dev;
struct omap_drm_private *priv = dev->dev_private;
  
@@ -33,7 +33,7 @@ static int gem_show(struct seq_file *m, void *arg)
  
  static int mm_show(struct seq_file *m, void *arg)

  {
-   struct drm_info_node *node = (struct drm_info_node *) m->private;
+   struct drm_info_node *node = m->private;
struct drm_device *dev = node->minor->dev;
struct drm_printer p = drm_seq_file_printer(m);
  
@@ -45,7 +45,7 @@ static int mm_show(struct seq_file *m, void *arg)

  #ifdef