[PATCH] drm: always provide debugfs function prototypes

2013-06-22 Thread Thierry Reding
On Sat, Jun 22, 2013 at 12:38:16AM +0200, Arnd Bergmann wrote: > It is generally considered bad style to enclose function prototypes > in header files in #ifdef. This case illustrates why that is: > The tegra host1x driver calls into the debugfs functions if > CONFIG_DEBUG_FS is enabled, but that

[PATCH] drm: always provide debugfs function prototypes

2013-06-22 Thread Arnd Bergmann
It is generally considered bad style to enclose function prototypes in header files in #ifdef. This case illustrates why that is: The tegra host1x driver calls into the debugfs functions if CONFIG_DEBUG_FS is enabled, but that code is otherwise already discarded by the compiler, so leaving the

Re: [PATCH] drm: always provide debugfs function prototypes

2013-06-22 Thread Thierry Reding
On Sat, Jun 22, 2013 at 12:38:16AM +0200, Arnd Bergmann wrote: It is generally considered bad style to enclose function prototypes in header files in #ifdef. This case illustrates why that is: The tegra host1x driver calls into the debugfs functions if CONFIG_DEBUG_FS is enabled, but that code

[PATCH] drm: always provide debugfs function prototypes

2013-06-21 Thread Arnd Bergmann
It is generally considered bad style to enclose function prototypes in header files in #ifdef. This case illustrates why that is: The tegra host1x driver calls into the debugfs functions if CONFIG_DEBUG_FS is enabled, but that code is otherwise already discarded by the compiler, so leaving the