Re: [PATCH] drm: fix use of freed memory in drm_mode_setcrtc

2018-09-26 Thread Tomi Valkeinen
On 21/09/18 11:55, Daniel Vetter wrote: > On Mon, Sep 17, 2018 at 02:00:54PM +0300, Tomi Valkeinen wrote: >> drm_mode_setcrtc() retries modesetting in case one of the functions it >> calls returns -EDEADLK. connector_set, mode and fb are freed before >> retrying, but they are not set to NULL. This

Re: [PATCH] drm: fix use of freed memory in drm_mode_setcrtc

2018-09-21 Thread Daniel Vetter
On Mon, Sep 17, 2018 at 02:00:54PM +0300, Tomi Valkeinen wrote: > drm_mode_setcrtc() retries modesetting in case one of the functions it > calls returns -EDEADLK. connector_set, mode and fb are freed before > retrying, but they are not set to NULL. This can cause > drm_mode_setcrtc() to use those

Re: [PATCH] drm: fix use of freed memory in drm_mode_setcrtc

2018-09-17 Thread Tomi Valkeinen
On 17/09/18 17:41, Ville Syrjälä wrote: > On Mon, Sep 17, 2018 at 02:00:54PM +0300, Tomi Valkeinen wrote: >> drm_mode_setcrtc() retries modesetting in case one of the functions it >> calls returns -EDEADLK. connector_set, mode and fb are freed before >> retrying, but they are not set to NULL. This

Re: [PATCH] drm: fix use of freed memory in drm_mode_setcrtc

2018-09-17 Thread Ville Syrjälä
On Mon, Sep 17, 2018 at 02:00:54PM +0300, Tomi Valkeinen wrote: > drm_mode_setcrtc() retries modesetting in case one of the functions it > calls returns -EDEADLK. connector_set, mode and fb are freed before > retrying, but they are not set to NULL. This can cause > drm_mode_setcrtc() to use those

[PATCH] drm: fix use of freed memory in drm_mode_setcrtc

2018-09-17 Thread Tomi Valkeinen
drm_mode_setcrtc() retries modesetting in case one of the functions it calls returns -EDEADLK. connector_set, mode and fb are freed before retrying, but they are not set to NULL. This can cause drm_mode_setcrtc() to use those variables. For example: On the first try