Re: [PATCH] drm: hdlcd: Stop failing atomic disable check

2019-04-03 Thread Liviu Dudau
On Tue, Apr 02, 2019 at 06:40:56PM +0100, Robin Murphy wrote: > On 01/04/2019 17:06, Liviu Dudau wrote: > > On Fri, Mar 29, 2019 at 06:46:21PM +, Robin Murphy wrote: > > > On 19/03/2019 14:49, Liviu Dudau wrote: > > > > On Tue, Mar 19, 2019 at 01:14:54PM +, Robin Murphy wrote: > > > > > [

Re: [PATCH] drm: hdlcd: Stop failing atomic disable check

2019-04-02 Thread Robin Murphy
On 01/04/2019 17:06, Liviu Dudau wrote: On Fri, Mar 29, 2019 at 06:46:21PM +, Robin Murphy wrote: On 19/03/2019 14:49, Liviu Dudau wrote: On Tue, Mar 19, 2019 at 01:14:54PM +, Robin Murphy wrote: [ +Sudeep - just FYI ] Hi Liviu, On 27/02/2019 09:40, Liviu Dudau wrote: Hi Robin,

Re: [PATCH] drm: hdlcd: Stop failing atomic disable check

2019-04-01 Thread Liviu Dudau
On Fri, Mar 29, 2019 at 06:46:21PM +, Robin Murphy wrote: > On 19/03/2019 14:49, Liviu Dudau wrote: > > On Tue, Mar 19, 2019 at 01:14:54PM +, Robin Murphy wrote: > > > [ +Sudeep - just FYI ] > > > > > > Hi Liviu, > > > > > > On 27/02/2019 09:40, Liviu Dudau wrote: > > > > Hi Robin, > > >

Re: [PATCH] drm: hdlcd: Stop failing atomic disable check

2019-03-29 Thread Robin Murphy
On 19/03/2019 14:49, Liviu Dudau wrote: On Tue, Mar 19, 2019 at 01:14:54PM +, Robin Murphy wrote: [ +Sudeep - just FYI ] Hi Liviu, On 27/02/2019 09:40, Liviu Dudau wrote: Hi Robin, Sorry for the delay in reviewing this patch, I am drowning a bit this week in meetings :) On Mon, Feb 25,

Re: [PATCH] drm: hdlcd: Stop failing atomic disable check

2019-03-19 Thread Liviu Dudau
On Tue, Mar 19, 2019 at 01:14:54PM +, Robin Murphy wrote: > [ +Sudeep - just FYI ] > > Hi Liviu, > > On 27/02/2019 09:40, Liviu Dudau wrote: > > Hi Robin, > > > > Sorry for the delay in reviewing this patch, I am drowning a bit this > > week in meetings :) > > > > On Mon, Feb 25, 2019 at

Re: [PATCH] drm: hdlcd: Stop failing atomic disable check

2019-03-19 Thread Robin Murphy
[ +Sudeep - just FYI ] Hi Liviu, On 27/02/2019 09:40, Liviu Dudau wrote: Hi Robin, Sorry for the delay in reviewing this patch, I am drowning a bit this week in meetings :) On Mon, Feb 25, 2019 at 02:39:13PM +, Robin Murphy wrote: When __drm_atomic_helper_disable_all() tries to commit

Re: [PATCH] drm: hdlcd: Stop failing atomic disable check

2019-02-27 Thread Liviu Dudau
Hi Robin, Sorry for the delay in reviewing this patch, I am drowning a bit this week in meetings :) On Mon, Feb 25, 2019 at 02:39:13PM +, Robin Murphy wrote: > When __drm_atomic_helper_disable_all() tries to commit the disabled > state, we end up in hdlcd_crtc_atomic_check() with a mode

[PATCH] drm: hdlcd: Stop failing atomic disable check

2019-02-25 Thread Robin Murphy
When __drm_atomic_helper_disable_all() tries to commit the disabled state, we end up in hdlcd_crtc_atomic_check() with a mode clock rate of 0. If the input clock has a nonzero minimum rate, this fails the clk_round_rate() check and prevents the CRTC being torn down cleanly. If we're disabling the