Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-08 Thread Ville Syrjälä
On Tue, Sep 08, 2020 at 03:33:04PM +0300, Laurent Pinchart wrote: > On Tue, Sep 08, 2020 at 02:29:02PM +0200, Daniel Vetter wrote: > > On Tue, Sep 8, 2020 at 2:07 PM Stefan Agner wrote: > > > On 2020-09-08 10:48, Daniel Vetter wrote: > > >> On Tue, Sep 08, 2020 at 11:18:25AM +0300, Tomi Valkeinen

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-08 Thread Stefan Agner
On 2020-09-08 14:33, Laurent Pinchart wrote: > On Tue, Sep 08, 2020 at 02:29:02PM +0200, Daniel Vetter wrote: >> On Tue, Sep 8, 2020 at 2:07 PM Stefan Agner wrote: >> > On 2020-09-08 10:48, Daniel Vetter wrote: >> >> On Tue, Sep 08, 2020 at 11:18:25AM +0300, Tomi Valkeinen wrote: >> >>> On

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-08 Thread Laurent Pinchart
On Tue, Sep 08, 2020 at 02:29:02PM +0200, Daniel Vetter wrote: > On Tue, Sep 8, 2020 at 2:07 PM Stefan Agner wrote: > > On 2020-09-08 10:48, Daniel Vetter wrote: > >> On Tue, Sep 08, 2020 at 11:18:25AM +0300, Tomi Valkeinen wrote: > >>> On 08/09/2020 10:55, Stefan Agner wrote: > On

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-08 Thread Daniel Vetter
On Tue, Sep 8, 2020 at 2:07 PM Stefan Agner wrote: > > On 2020-09-08 10:48, Daniel Vetter wrote: > > On Tue, Sep 08, 2020 at 11:18:25AM +0300, Tomi Valkeinen wrote: > >> Hi, > >> > >> On 08/09/2020 10:55, Stefan Agner wrote: > >> > On 2020-09-07 20:18, Daniel Vetter wrote: > >> >> On Mon, Sep 07,

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-08 Thread Tomi Valkeinen
Hi, On 08/09/2020 10:55, Stefan Agner wrote: > On 2020-09-07 20:18, Daniel Vetter wrote: >> On Mon, Sep 07, 2020 at 07:17:12PM +0300, Laurent Pinchart wrote: >>> Hi Stefan, >>> >>> Thank you for the patch. >>> >>> On Mon, Sep 07, 2020 at 06:03:43PM +0200, Stefan Agner wrote: The lcdif IP

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-08 Thread Laurent Pinchart
On Tue, Sep 08, 2020 at 10:48:55AM +0200, Daniel Vetter wrote: > On Tue, Sep 08, 2020 at 11:18:25AM +0300, Tomi Valkeinen wrote: > > On 08/09/2020 10:55, Stefan Agner wrote: > > > On 2020-09-07 20:18, Daniel Vetter wrote: > > >> On Mon, Sep 07, 2020 at 07:17:12PM +0300, Laurent Pinchart wrote: > >

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-08 Thread Stefan Agner
On 2020-09-08 10:48, Daniel Vetter wrote: > On Tue, Sep 08, 2020 at 11:18:25AM +0300, Tomi Valkeinen wrote: >> Hi, >> >> On 08/09/2020 10:55, Stefan Agner wrote: >> > On 2020-09-07 20:18, Daniel Vetter wrote: >> >> On Mon, Sep 07, 2020 at 07:17:12PM +0300, Laurent Pinchart wrote: >> >>> Hi Stefan,

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-08 Thread Daniel Vetter
On Tue, Sep 08, 2020 at 11:18:25AM +0300, Tomi Valkeinen wrote: > Hi, > > On 08/09/2020 10:55, Stefan Agner wrote: > > On 2020-09-07 20:18, Daniel Vetter wrote: > >> On Mon, Sep 07, 2020 at 07:17:12PM +0300, Laurent Pinchart wrote: > >>> Hi Stefan, > >>> > >>> Thank you for the patch. > >>> > >>>

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-08 Thread Stefan Agner
On 2020-09-07 20:18, Daniel Vetter wrote: > On Mon, Sep 07, 2020 at 07:17:12PM +0300, Laurent Pinchart wrote: >> Hi Stefan, >> >> Thank you for the patch. >> >> On Mon, Sep 07, 2020 at 06:03:43PM +0200, Stefan Agner wrote: >> > The lcdif IP does not support a framebuffer pitch (stride) other than

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-07 Thread Daniel Abrecht
Am 2020-09-07 16:03, schrieb Stefan Agner: The lcdif IP does not support a framebuffer pitch (stride) other than the CRTC width. This may be true for some SOCs, but not for all of them. I used to have this working flawlessly on the imx8mq like so:

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-07 Thread Daniel Vetter
On Mon, Sep 07, 2020 at 07:17:12PM +0300, Laurent Pinchart wrote: > Hi Stefan, > > Thank you for the patch. > > On Mon, Sep 07, 2020 at 06:03:43PM +0200, Stefan Agner wrote: > > The lcdif IP does not support a framebuffer pitch (stride) other than > > the CRTC width. Check for equality and

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-07 Thread Laurent Pinchart
Hi Stefan, Thank you for the patch. On Mon, Sep 07, 2020 at 06:03:43PM +0200, Stefan Agner wrote: > The lcdif IP does not support a framebuffer pitch (stride) other than > the CRTC width. Check for equality and reject the state otherwise. > > This prevents a distorted picture when using 640x800

[PATCH] drm: mxsfb: check framebuffer pitch

2020-09-07 Thread Stefan Agner
The lcdif IP does not support a framebuffer pitch (stride) other than the CRTC width. Check for equality and reject the state otherwise. This prevents a distorted picture when using 640x800 and running the Mesa graphics stack. Mesa tires to use a cache aligned stride, which leads at that