Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

Hi Maxime, On 17/07/17 07:32, Maxime Ripard wrote: > On Thu, Jul 13, 2017 at 05:25:08PM +0100, Kieran Bingham wrote: > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > index 82b978a5dae6..c2f382feca07 100644 > ---

Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

On Thu, Jul 13, 2017 at 05:25:08PM +0100, Kieran Bingham wrote: > >>> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > >>> b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > >>> index 82b978a5dae6..c2f382feca07 100644 > >>> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > >>> +++

Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

On 13/07/17 16:51, Kieran Bingham wrote: > Hi Laurent, > > I've just seen Maxime's latest series "[PATCH 0/4] drm/sun4i: Fix a register > access bug" and it relates directly to a comment I had in this patch: > > On 12/07/17 17:35, Kieran Bingham wrote: >> Hi Laurent, >> >> On 28/06/17 19:50,

Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

Hi Laurent, I've just seen Maxime's latest series "[PATCH 0/4] drm/sun4i: Fix a register access bug" and it relates directly to a comment I had in this patch: On 12/07/17 17:35, Kieran Bingham wrote: > Hi Laurent, > > On 28/06/17 19:50, Laurent Pinchart wrote: >> Commit 52055bafa1ff ("drm:

Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

Hi Kieran, On Wednesday 12 Jul 2017 17:35:53 Kieran Bingham wrote: > On 28/06/17 19:50, Laurent Pinchart wrote: > > Commit 52055bafa1ff ("drm: rcar-du: Move plane commit code from CRTC > > start to CRTC resume") changed the order of the plane commit and CRTC > > enable operations to accommodate

Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

Hi Kieran, On Thursday 13 Jul 2017 16:51:18 Kieran Bingham wrote: > Hi Laurent, > > I've just seen Maxime's latest series "[PATCH 0/4] drm/sun4i: Fix a register > access bug" and it relates directly to a comment I had in this patch: > On 12/07/17 17:35, Kieran Bingham wrote: > > > On 28/06/17

Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

Hi Laurent, On 28/06/17 19:50, Laurent Pinchart wrote: > Commit 52055bafa1ff ("drm: rcar-du: Move plane commit code from CRTC > start to CRTC resume") changed the order of the plane commit and CRTC > enable operations to accommodate the runtime PM requirements. However, > this introduced

Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

Hi Geert, On Wednesday 28 Jun 2017 20:52:53 Geert Uytterhoeven wrote: > On Wed, Jun 28, 2017 at 8:50 PM, Laurent Pinchart wrote: > > Commit 52055bafa1ff ("drm: rcar-du: Move plane commit code from CRTC > > start to CRTC resume") changed the order of the plane commit and CRTC > > enable operations

Re: [PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

On Wed, Jun 28, 2017 at 8:50 PM, Laurent Pinchart wrote: > Commit 52055bafa1ff ("drm: rcar-du: Move plane commit code from CRTC > start to CRTC resume") changed the order of the plane commit and CRTC > enable operations to accommodate the runtime PM

[PATCH] drm: rcar-du: Setup planes before enabling CRTC to avoid flicker

Commit 52055bafa1ff ("drm: rcar-du: Move plane commit code from CRTC start to CRTC resume") changed the order of the plane commit and CRTC enable operations to accommodate the runtime PM requirements. However, this introduced corruption in the first displayed frame, as the CRTC is now enabled