Re: [PATCH] drm: re-enable error handling

2018-07-16 Thread Sean Paul
On Sat, Jul 14, 2018 at 02:32:12PM +0200, Nicholas Mc Guire wrote: > drm_legacy_ctxbitmap_next() returns idr_alloc() which can return > -ENOMEM, -EINVAL or -ENOSPC none of which are -1 . but the call sites > of drm_legacy_ctxbitmap_next() seem to be assuming that the error case > would be -1

[PATCH] drm: re-enable error handling

2018-07-14 Thread Nicholas Mc Guire
drm_legacy_ctxbitmap_next() returns idr_alloc() which can return -ENOMEM, -EINVAL or -ENOSPC none of which are -1 . but the call sites of drm_legacy_ctxbitmap_next() seem to be assuming that the error case would be -1 (original return of drm_ctxbitmap_next() prior to 2.6.23 was actually -1). Thus