[PATCH] gpu: drm: use struct_size() in kmalloc()

2019-05-22 Thread xiaolinkui
Use struct_size() helper to keep code simple. Signed-off-by: xiaolinkui --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index 22bd21e..4717a64 1006

Re: [PATCH] gpu: drm: use struct_size() in kmalloc()

2019-05-21 Thread Gustavo A. R. Silva
On 5/21/19 3:59 AM, Christian König wrote: > BTW: Is there actually good documentation how to correctly do the variable > length array at end of structure thing in the kernel? > > I do know that I've seen a lot of different variants like array[] array[0] or > array[1] and I have also seen a b

Re: [PATCH] gpu: drm: use struct_size() in kmalloc()

2019-05-21 Thread Christian König
...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-ker...@vger.kernel.org 主题: Re: [PATCH] gpu: drm: use struct_size() in kmalloc() [CAUTION: External Email] On Fri, May 17, 2019 at 04:44:30PM +, Pan, Xinhui wrote: I am going to put more members which are also array after this struc

Re: [PATCH] gpu: drm: use struct_size() in kmalloc()

2019-05-21 Thread Daniel Vetter
; dan...@ffwll.ch; Quan, Evan; xiaolinkui; > > amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > > linux-ker...@vger.kernel.org > > 主题: Re: [PATCH] gpu: drm: use struct_size() in kmalloc() > > > > [CAUTION: External Email] > > > > On Fri,

Re: [PATCH] gpu: drm: use struct_size() in kmalloc()

2019-05-20 Thread Alex Deucher
ng); > airl...@linux.ie; dan...@ffwll.ch; Quan, Evan; xiaolinkui; > amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > linux-ker...@vger.kernel.org > 主题: Re: [PATCH] gpu: drm: use struct_size() in kmalloc() > > [CAUTION: External Email] > > On Fri, May 17, 2

回复: [PATCH] gpu: drm: use struct_size() in kmalloc()

2019-05-20 Thread Pan, Xinhui
nder; Koenig, Christian; Zhou, David(ChunMing); > airl...@linux.ie; dan...@ffwll.ch; Pan, Xinhui; Quan, Evan > Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > linux-ker...@vger.kernel.org; xiaolin...@kylinos.cn > Subject: [PATCH] gpu: drm: use struct_size() in kma

Re: [PATCH] gpu: drm: use struct_size() in kmalloc()

2019-05-20 Thread Pan, Xinhui
; Koenig, Christian; Zhou, David(ChunMing); airl...@linux.ie; dan...@ffwll.ch; Quan, Evan; xiaolinkui; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-ker...@vger.kernel.org Subject: Re: [PATCH] gpu: drm: use struct_size() in kmalloc() [CAUTION: External Email] On Fri, May 17

Re: [PATCH] gpu: drm: use struct_size() in kmalloc()

2019-05-20 Thread Gustavo A. R. Silva
On 5/20/19 12:41 PM, Alex Deucher wrote: > On Fri, May 17, 2019 at 8:43 AM xiaolinkui wrote: >> >> Use struct_size() helper to keep code simple. >> Again, this is not the reason why this helper was created. >> Signed-off-by: xiaolinkui >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 +-

Re: [PATCH] gpu: drm: use struct_size() in kmalloc()

2019-05-20 Thread Alex Deucher
On Fri, May 17, 2019 at 8:43 AM xiaolinkui wrote: > > Use struct_size() helper to keep code simple. > > Signed-off-by: xiaolinkui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) This patch results in the following build error: DESCEND

Re: [PATCH] gpu: drm: use struct_size() in kmalloc()

2019-05-20 Thread Daniel Vetter
airl...@linux.ie; dan...@ffwll.ch; Pan, Xinhui; Quan, Evan > Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > linux-ker...@vger.kernel.org; xiaolin...@kylinos.cn > Subject: [PATCH] gpu: drm: use struct_size() in kmalloc() > > [CAUTION: External Email] >

Re: [PATCH] gpu: drm: use struct_size() in kmalloc()

2019-05-17 Thread Pan, Xinhui
, Christian; Zhou, David(ChunMing); airl...@linux.ie; dan...@ffwll.ch; Pan, Xinhui; Quan, Evan Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-ker...@vger.kernel.org; xiaolin...@kylinos.cn Subject: [PATCH] gpu: drm: use struct_size() in kmalloc() [CAUTION: External Email] Use