Re: [PATCH] i2c: replace i2c_new_secondary_device with an ERR_PTR variant

2019-08-09 Thread Wolfram Sang
Hi Laurent, > > > > + if (IS_ERR(state->i2c_clients[i])) { > > > > + err = PTR_ERR(state->i2c_clients[i]); > > > > v4l2_err(sd, "failed to create i2c client > > > > %u\n", i); > > > > goto err_i2c; > > This will

Re: [PATCH] i2c: replace i2c_new_secondary_device with an ERR_PTR variant

2019-08-08 Thread Laurent Pinchart
On Thu, Aug 08, 2019 at 05:57:09PM +0200, Wolfram Sang wrote: > On Tue, Jul 23, 2019 at 04:47:09PM +0100, Kieran Bingham wrote: > > On 22/07/2019 18:26, Wolfram Sang wrote: > > > In the general move to have i2c_new_*_device functions which return > > > ERR_PTR instead of NULL, this patch converts

Re: [PATCH] i2c: replace i2c_new_secondary_device with an ERR_PTR variant

2019-08-08 Thread Wolfram Sang
On Tue, Jul 23, 2019 at 04:47:09PM +0100, Kieran Bingham wrote: > Hi Wolfram, > > On 22/07/2019 18:26, Wolfram Sang wrote: > > In the general move to have i2c_new_*_device functions which return > > ERR_PTR instead of NULL, this patch converts i2c_new_secondary_device(). > > > > There are only

Re: [PATCH] i2c: replace i2c_new_secondary_device with an ERR_PTR variant

2019-07-23 Thread Kieran Bingham
Hi Wolfram, On 22/07/2019 18:26, Wolfram Sang wrote: > In the general move to have i2c_new_*_device functions which return > ERR_PTR instead of NULL, this patch converts i2c_new_secondary_device(). > > There are only few users, so this patch converts the I2C core and all > users in one go. The

[PATCH] i2c: replace i2c_new_secondary_device with an ERR_PTR variant

2019-07-22 Thread Wolfram Sang
In the general move to have i2c_new_*_device functions which return ERR_PTR instead of NULL, this patch converts i2c_new_secondary_device(). There are only few users, so this patch converts the I2C core and all users in one go. The function gets renamed to i2c_new_ancillary_device() so