Re: [PATCH] nouveau: fix reclocking on nv40

2013-09-09 Thread Pali Rohár 
On Wednesday 21 August 2013 02:24:01 Ben Skeggs wrote:
 On Mon, Aug 19, 2013 at 4:59 PM, Pali Rohár 
pali.ro...@gmail.com wrote:
  On Friday 16 August 2013 14:57:07 Pali Rohár wrote:
  In commit 77145f1cbdf8d28b46ff8070ca749bad821e0774 was
  introduced error which cause that reclocking on nv40 not
  working anymore. There is missing assigment of return value
  from pll_calc to ret.
  
  Signed-off-by: Pali Rohár pali.ro...@gmail.com
  Signed-off-by: Martin Peres martin.pe...@labri.fr
  ---
  
   drivers/gpu/drm/nouveau/nv40_pm.c |2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
  
  diff --git a/drivers/gpu/drm/nouveau/nv40_pm.c
  b/drivers/gpu/drm/nouveau/nv40_pm.c index 3af5bcd..625f80d
  100644
  --- a/drivers/gpu/drm/nouveau/nv40_pm.c
  +++ b/drivers/gpu/drm/nouveau/nv40_pm.c
  @@ -131,7 +131,7 @@ nv40_calc_pll(struct drm_device *dev,
  u32 reg, struct nvbios_pll *pll, if (clk 
  pll-vco1.max_freq)
  
pll-vco2.max_freq = 0;
  
  - pclk-pll_calc(pclk, pll, clk, coef);
  + ret = pclk-pll_calc(pclk, pll, clk, coef);
  
if (ret == 0)

return -ERANGE;
  
  Hello, it is possible to include this patch in 3.11?
  Or it is too late now and need to wait for 3.12?
 
 I've picked up the patch and will submit it in my next
 3.11-fixes pull request.
 
 Thanks,
 Ben.
 

Hello, now I see that patch is in 3.11, thanks! Ben, what do you 
think, can be this patch backported to older kernels?

-- 
Pali Rohár
pali.ro...@gmail.com


signature.asc
Description: This is a digitally signed message part.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] nouveau: fix reclocking on nv40

2013-09-08 Thread Ben Skeggs 
On Sun, Sep 8, 2013 at 9:25 PM, Pali Rohár pali.ro...@gmail.com wrote:
 On Wednesday 21 August 2013 02:24:01 Ben Skeggs wrote:
 On Mon, Aug 19, 2013 at 4:59 PM, Pali Rohár
 pali.ro...@gmail.com wrote:
  On Friday 16 August 2013 14:57:07 Pali Rohár wrote:
  In commit 77145f1cbdf8d28b46ff8070ca749bad821e0774 was
  introduced error which cause that reclocking on nv40 not
  working anymore. There is missing assigment of return value
  from pll_calc to ret.
 
  Signed-off-by: Pali Rohár pali.ro...@gmail.com
  Signed-off-by: Martin Peres martin.pe...@labri.fr
  ---
 
   drivers/gpu/drm/nouveau/nv40_pm.c |2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
 
  diff --git a/drivers/gpu/drm/nouveau/nv40_pm.c
  b/drivers/gpu/drm/nouveau/nv40_pm.c index 3af5bcd..625f80d
  100644
  --- a/drivers/gpu/drm/nouveau/nv40_pm.c
  +++ b/drivers/gpu/drm/nouveau/nv40_pm.c
  @@ -131,7 +131,7 @@ nv40_calc_pll(struct drm_device *dev,
  u32 reg, struct nvbios_pll *pll, if (clk 
  pll-vco1.max_freq)
 
pll-vco2.max_freq = 0;
 
  - pclk-pll_calc(pclk, pll, clk, coef);
  + ret = pclk-pll_calc(pclk, pll, clk, coef);
 
if (ret == 0)
 
return -ERANGE;
 
  Hello, it is possible to include this patch in 3.11?
  Or it is too late now and need to wait for 3.12?

 I've picked up the patch and will submit it in my next
 3.11-fixes pull request.

 Thanks,
 Ben.


 Hello, now I see that patch is in 3.11, thanks! Ben, what do you
 think, can be this patch backported to older kernels?
Personally, I don't care at all.  The current PM code is a dead end,
and completely not supported (hence why it's hidden behind a magic
parameter).  If I had my way it'd have been completely ripped out
already.

If someone wants to backport and test it on earlier kernels though, by
all means, go ahead :)

Thanks,
Ben.


 --
 Pali Rohár
 pali.ro...@gmail.com
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] nouveau: fix reclocking on nv40

2013-08-21 Thread Ben Skeggs 
On Mon, Aug 19, 2013 at 4:59 PM, Pali Roh?r  wrote:
> On Friday 16 August 2013 14:57:07 Pali Roh?r wrote:
>> In commit 77145f1cbdf8d28b46ff8070ca749bad821e0774 was
>> introduced error which cause that reclocking on nv40 not
>> working anymore. There is missing assigment of return value
>> from pll_calc to ret.
>>
>> Signed-off-by: Pali Roh?r 
>> Signed-off-by: Martin Peres 
>> ---
>>  drivers/gpu/drm/nouveau/nv40_pm.c |2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/nouveau/nv40_pm.c
>> b/drivers/gpu/drm/nouveau/nv40_pm.c index 3af5bcd..625f80d
>> 100644
>> --- a/drivers/gpu/drm/nouveau/nv40_pm.c
>> +++ b/drivers/gpu/drm/nouveau/nv40_pm.c
>> @@ -131,7 +131,7 @@ nv40_calc_pll(struct drm_device *dev, u32
>> reg, struct nvbios_pll *pll, if (clk < pll->vco1.max_freq)
>>   pll->vco2.max_freq = 0;
>>
>> - pclk->pll_calc(pclk, pll, clk, );
>> + ret = pclk->pll_calc(pclk, pll, clk, );
>>   if (ret == 0)
>>   return -ERANGE;
>
> Hello, it is possible to include this patch in 3.11?
> Or it is too late now and need to wait for 3.12?
I've picked up the patch and will submit it in my next 3.11-fixes pull request.

Thanks,
Ben.

>
> --
> Pali Roh?r
> pali.rohar at gmail.com
>
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>

Re: [PATCH] nouveau: fix reclocking on nv40

2013-08-20 Thread Pali Rohár 
On Friday 16 August 2013 14:57:07 Pali Rohár wrote:
 In commit 77145f1cbdf8d28b46ff8070ca749bad821e0774 was
 introduced error which cause that reclocking on nv40 not
 working anymore. There is missing assigment of return value
 from pll_calc to ret.
 
 Signed-off-by: Pali Rohár pali.ro...@gmail.com
 Signed-off-by: Martin Peres martin.pe...@labri.fr
 ---
  drivers/gpu/drm/nouveau/nv40_pm.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/gpu/drm/nouveau/nv40_pm.c
 b/drivers/gpu/drm/nouveau/nv40_pm.c index 3af5bcd..625f80d
 100644
 --- a/drivers/gpu/drm/nouveau/nv40_pm.c
 +++ b/drivers/gpu/drm/nouveau/nv40_pm.c
 @@ -131,7 +131,7 @@ nv40_calc_pll(struct drm_device *dev, u32
 reg, struct nvbios_pll *pll, if (clk  pll-vco1.max_freq)
   pll-vco2.max_freq = 0;
 
 - pclk-pll_calc(pclk, pll, clk, coef);
 + ret = pclk-pll_calc(pclk, pll, clk, coef);
   if (ret == 0)
   return -ERANGE;

Hello, it is possible to include this patch in 3.11?
Or it is too late now and need to wait for 3.12?

-- 
Pali Rohár
pali.ro...@gmail.com


signature.asc
Description: This is a digitally signed message part.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] nouveau: fix reclocking on nv40

2013-08-20 Thread Ben Skeggs 
On Mon, Aug 19, 2013 at 4:59 PM, Pali Rohár pali.ro...@gmail.com wrote:
 On Friday 16 August 2013 14:57:07 Pali Rohár wrote:
 In commit 77145f1cbdf8d28b46ff8070ca749bad821e0774 was
 introduced error which cause that reclocking on nv40 not
 working anymore. There is missing assigment of return value
 from pll_calc to ret.

 Signed-off-by: Pali Rohár pali.ro...@gmail.com
 Signed-off-by: Martin Peres martin.pe...@labri.fr
 ---
  drivers/gpu/drm/nouveau/nv40_pm.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/drivers/gpu/drm/nouveau/nv40_pm.c
 b/drivers/gpu/drm/nouveau/nv40_pm.c index 3af5bcd..625f80d
 100644
 --- a/drivers/gpu/drm/nouveau/nv40_pm.c
 +++ b/drivers/gpu/drm/nouveau/nv40_pm.c
 @@ -131,7 +131,7 @@ nv40_calc_pll(struct drm_device *dev, u32
 reg, struct nvbios_pll *pll, if (clk  pll-vco1.max_freq)
   pll-vco2.max_freq = 0;

 - pclk-pll_calc(pclk, pll, clk, coef);
 + ret = pclk-pll_calc(pclk, pll, clk, coef);
   if (ret == 0)
   return -ERANGE;

 Hello, it is possible to include this patch in 3.11?
 Or it is too late now and need to wait for 3.12?
I've picked up the patch and will submit it in my next 3.11-fixes pull request.

Thanks,
Ben.


 --
 Pali Rohár
 pali.ro...@gmail.com

 ___
 dri-devel mailing list
 dri-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/dri-devel

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] nouveau: fix reclocking on nv40

2013-08-19 Thread Pali Rohár 
On Friday 16 August 2013 14:57:07 Pali Roh?r wrote:
> In commit 77145f1cbdf8d28b46ff8070ca749bad821e0774 was
> introduced error which cause that reclocking on nv40 not
> working anymore. There is missing assigment of return value
> from pll_calc to ret.
> 
> Signed-off-by: Pali Roh?r 
> Signed-off-by: Martin Peres 
> ---
>  drivers/gpu/drm/nouveau/nv40_pm.c |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nv40_pm.c
> b/drivers/gpu/drm/nouveau/nv40_pm.c index 3af5bcd..625f80d
> 100644
> --- a/drivers/gpu/drm/nouveau/nv40_pm.c
> +++ b/drivers/gpu/drm/nouveau/nv40_pm.c
> @@ -131,7 +131,7 @@ nv40_calc_pll(struct drm_device *dev, u32
> reg, struct nvbios_pll *pll, if (clk < pll->vco1.max_freq)
>   pll->vco2.max_freq = 0;
> 
> - pclk->pll_calc(pclk, pll, clk, );
> + ret = pclk->pll_calc(pclk, pll, clk, );
>   if (ret == 0)
>   return -ERANGE;

Hello, it is possible to include this patch in 3.11?
Or it is too late now and need to wait for 3.12?

-- 
Pali Roh?r
pali.rohar at gmail.com
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL:

[PATCH] nouveau: fix reclocking on nv40

2013-08-18 Thread Pali Rohár 
In commit 77145f1cbdf8d28b46ff8070ca749bad821e0774 was introduced
error which cause that reclocking on nv40 not working anymore.
There is missing assigment of return value from pll_calc to ret.

Signed-off-by: Pali Rohár pali.ro...@gmail.com
Signed-off-by: Martin Peres martin.pe...@labri.fr
---
 drivers/gpu/drm/nouveau/nv40_pm.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nv40_pm.c 
b/drivers/gpu/drm/nouveau/nv40_pm.c
index 3af5bcd..625f80d 100644
--- a/drivers/gpu/drm/nouveau/nv40_pm.c
+++ b/drivers/gpu/drm/nouveau/nv40_pm.c
@@ -131,7 +131,7 @@ nv40_calc_pll(struct drm_device *dev, u32 reg, struct 
nvbios_pll *pll,
if (clk  pll-vco1.max_freq)
pll-vco2.max_freq = 0;
 
-   pclk-pll_calc(pclk, pll, clk, coef);
+   ret = pclk-pll_calc(pclk, pll, clk, coef);
if (ret == 0)
return -ERANGE;
 
-- 
1.7.10.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] nouveau: fix reclocking on nv40

2013-08-16 Thread Pali Rohár 
In commit 77145f1cbdf8d28b46ff8070ca749bad821e0774 was introduced
error which cause that reclocking on nv40 not working anymore.
There is missing assigment of return value from pll_calc to ret.

Signed-off-by: Pali Roh?r 
Signed-off-by: Martin Peres 
---
 drivers/gpu/drm/nouveau/nv40_pm.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nv40_pm.c 
b/drivers/gpu/drm/nouveau/nv40_pm.c
index 3af5bcd..625f80d 100644
--- a/drivers/gpu/drm/nouveau/nv40_pm.c
+++ b/drivers/gpu/drm/nouveau/nv40_pm.c
@@ -131,7 +131,7 @@ nv40_calc_pll(struct drm_device *dev, u32 reg, struct 
nvbios_pll *pll,
if (clk < pll->vco1.max_freq)
pll->vco2.max_freq = 0;

-   pclk->pll_calc(pclk, pll, clk, );
+   ret = pclk->pll_calc(pclk, pll, clk, );
if (ret == 0)
return -ERANGE;

-- 
1.7.10.4