Re: [PATCH] qxl: refactor to use drm_fb_helper_fbdev_setup

2018-09-12 Thread Gerd Hoffmann
On Mon, Sep 10, 2018 at 03:21:56PM +0200, Peter Wu wrote: > Lots of code can be removed by relying on fb-helper: > - "struct drm_framebuffer" moves to fb_helper.fb. > - "struct drm_gem_object" moves to fb_helper.obj[0]. > - "struct qxl_device" can be inferred as drm_fb_helper is embedded. > -

Re: [PATCH] qxl: refactor to use drm_fb_helper_fbdev_setup

2018-09-10 Thread kbuild test robot
Hi Peter, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.19-rc3 next-20180910] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH] qxl: refactor to use drm_fb_helper_fbdev_setup

2018-09-10 Thread Peter Wu
Lots of code can be removed by relying on fb-helper: - "struct drm_framebuffer" moves to fb_helper.fb. - "struct drm_gem_object" moves to fb_helper.obj[0]. - "struct qxl_device" can be inferred as drm_fb_helper is embedded. - qxl_user_framebuffer_create -> drm_gem_fb_create. -