[PATCH] radeon/kms: fix dp displayport mode validation

[Alex Deucher]

On Wed, Jan 26, 2011 at 5:51 PM,   wrote:
> From: Jerome Glisse 
>
> Check if there is a big enough dp clock & enough dp lane to
> drive the video mode provided.
>
> Signed-off-by: Jerome Glisse 
> Cc: 

Looks like a copy paste error, probably from me :)

Reviewed-By: Alex Deucher 

> ---
> ?drivers/gpu/drm/radeon/atombios_dp.c | ? ?4 ++--
> ?1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/atombios_dp.c 
> b/drivers/gpu/drm/radeon/atombios_dp.c
> index 4e7778d..695de9a 100644
> --- a/drivers/gpu/drm/radeon/atombios_dp.c
> +++ b/drivers/gpu/drm/radeon/atombios_dp.c
> @@ -187,9 +187,9 @@ static int dp_link_clock_for_mode_clock(u8 
> dpcd[DP_DPCD_SIZE], int mode_clock)
> ?int dp_mode_valid(u8 dpcd[DP_DPCD_SIZE], int mode_clock)
> ?{
> ? ? ? ?int lanes = dp_lanes_for_mode_clock(dpcd, mode_clock);
> - ? ? ? int bw = dp_lanes_for_mode_clock(dpcd, mode_clock);
> + ? ? ? int dp_clock = dp_link_clock_for_mode_clock(dpcd, mode_clock);
>
> - ? ? ? if ((lanes == 0) || (bw == 0))
> + ? ? ? if ((lanes == 0) || (dp_clock == 0))
> ? ? ? ? ? ? ? ?return MODE_CLOCK_HIGH;
>
> ? ? ? ?return MODE_OK;
> --
> 1.7.3.2
>
> ___
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>

[PATCH] radeon/kms: fix dp displayport mode validation

[jgli...@redhat.com]

From: Jerome Glisse 

Check if there is a big enough dp clock & enough dp lane to
drive the video mode provided.

Signed-off-by: Jerome Glisse 
Cc: 
---
 drivers/gpu/drm/radeon/atombios_dp.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/atombios_dp.c 
b/drivers/gpu/drm/radeon/atombios_dp.c
index 4e7778d..695de9a 100644
--- a/drivers/gpu/drm/radeon/atombios_dp.c
+++ b/drivers/gpu/drm/radeon/atombios_dp.c
@@ -187,9 +187,9 @@ static int dp_link_clock_for_mode_clock(u8 
dpcd[DP_DPCD_SIZE], int mode_clock)
 int dp_mode_valid(u8 dpcd[DP_DPCD_SIZE], int mode_clock)
 {
int lanes = dp_lanes_for_mode_clock(dpcd, mode_clock);
-   int bw = dp_lanes_for_mode_clock(dpcd, mode_clock);
+   int dp_clock = dp_link_clock_for_mode_clock(dpcd, mode_clock);

-   if ((lanes == 0) || (bw == 0))
+   if ((lanes == 0) || (dp_clock == 0))
return MODE_CLOCK_HIGH;

return MODE_OK;
-- 
1.7.3.2

[PATCH] radeon/kms: fix dp displayport mode validation

[jglisse]

From: Jerome Glisse jgli...@redhat.com

Check if there is a big enough dp clock  enough dp lane to
drive the video mode provided.

Signed-off-by: Jerome Glisse jgli...@redhat.com
Cc: sta...@kernel.org
---
 drivers/gpu/drm/radeon/atombios_dp.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/atombios_dp.c 
b/drivers/gpu/drm/radeon/atombios_dp.c
index 4e7778d..695de9a 100644
--- a/drivers/gpu/drm/radeon/atombios_dp.c
+++ b/drivers/gpu/drm/radeon/atombios_dp.c
@@ -187,9 +187,9 @@ static int dp_link_clock_for_mode_clock(u8 
dpcd[DP_DPCD_SIZE], int mode_clock)
 int dp_mode_valid(u8 dpcd[DP_DPCD_SIZE], int mode_clock)
 {
int lanes = dp_lanes_for_mode_clock(dpcd, mode_clock);
-   int bw = dp_lanes_for_mode_clock(dpcd, mode_clock);
+   int dp_clock = dp_link_clock_for_mode_clock(dpcd, mode_clock);
 
-   if ((lanes == 0) || (bw == 0))
+   if ((lanes == 0) || (dp_clock == 0))
return MODE_CLOCK_HIGH;
 
return MODE_OK;
-- 
1.7.3.2

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] radeon/kms: fix dp displayport mode validation

[Alex Deucher]

On Wed, Jan 26, 2011 at 5:51 PM,  jgli...@redhat.com wrote:
 From: Jerome Glisse jgli...@redhat.com

 Check if there is a big enough dp clock  enough dp lane to
 drive the video mode provided.

 Signed-off-by: Jerome Glisse jgli...@redhat.com
 Cc: sta...@kernel.org

Looks like a copy paste error, probably from me :)

Reviewed-By: Alex Deucher alexdeuc...@gmail.com

 ---
  drivers/gpu/drm/radeon/atombios_dp.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

 diff --git a/drivers/gpu/drm/radeon/atombios_dp.c 
 b/drivers/gpu/drm/radeon/atombios_dp.c
 index 4e7778d..695de9a 100644
 --- a/drivers/gpu/drm/radeon/atombios_dp.c
 +++ b/drivers/gpu/drm/radeon/atombios_dp.c
 @@ -187,9 +187,9 @@ static int dp_link_clock_for_mode_clock(u8 
 dpcd[DP_DPCD_SIZE], int mode_clock)
  int dp_mode_valid(u8 dpcd[DP_DPCD_SIZE], int mode_clock)
  {
        int lanes = dp_lanes_for_mode_clock(dpcd, mode_clock);
 -       int bw = dp_lanes_for_mode_clock(dpcd, mode_clock);
 +       int dp_clock = dp_link_clock_for_mode_clock(dpcd, mode_clock);

 -       if ((lanes == 0) || (bw == 0))
 +       if ((lanes == 0) || (dp_clock == 0))
                return MODE_CLOCK_HIGH;

        return MODE_OK;
 --
 1.7.3.2

 ___
 dri-devel mailing list
 dri-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/dri-devel

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel