[PATCH] radeon: fix tile_split of 128-bit surface formats with 8x MSAA

2012-10-16 Thread Marek Olšák
In this specific case, the eg_surface_sanity function (or something like that, I don't remember its name) returns an error. Then the cascade of perfectly working fail codepaths propagate the error to the OpenGL user as an unsupported framebuffer object setup. Marek On Tue, Oct 16, 2012 at 8:50 AM

[PATCH] radeon: fix tile_split of 128-bit surface formats with 8x MSAA

2012-10-16 Thread Paul Menzel
Dear Marek, Am Dienstag, den 16.10.2012, 02:21 +0200 schrieb Marek Ol??k: > The calculation led to the number 8192, which is too high. what is the reason it is limited to 4096? Hardware limitation? What are the ramifications? GPU hangs, rendering errors? > --- > radeon/radeon_surface.c |2

[PATCH] radeon: fix tile_split of 128-bit surface formats with 8x MSAA

2012-10-16 Thread Alex Deucher
On Mon, Oct 15, 2012 at 8:21 PM, Marek Ol??k wrote: > The calculation led to the number 8192, which is too high. Looks good. Reviewed-by: Alex Deucher > --- > radeon/radeon_surface.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/radeon/radeon_surface.c b/radeon/radeon_surface.

[PATCH] radeon: fix tile_split of 128-bit surface formats with 8x MSAA

2012-10-16 Thread Alex Deucher
On Tue, Oct 16, 2012 at 2:50 AM, Paul Menzel wrote: > Dear Marek, > > > Am Dienstag, den 16.10.2012, 02:21 +0200 schrieb Marek Ol??k: >> The calculation led to the number 8192, which is too high. > > what is the reason it is limited to 4096? Hardware limitation? hw limit. > > What are the ramifi

Re: [PATCH] radeon: fix tile_split of 128-bit surface formats with 8x MSAA

2012-10-16 Thread Marek Olšák
In this specific case, the eg_surface_sanity function (or something like that, I don't remember its name) returns an error. Then the cascade of perfectly working fail codepaths propagate the error to the OpenGL user as an unsupported framebuffer object setup. Marek On Tue, Oct 16, 2012 at 8:50 AM

Re: [PATCH] radeon: fix tile_split of 128-bit surface formats with 8x MSAA

2012-10-16 Thread Alex Deucher
On Mon, Oct 15, 2012 at 8:21 PM, Marek Olšák wrote: > The calculation led to the number 8192, which is too high. Looks good. Reviewed-by: Alex Deucher > --- > radeon/radeon_surface.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/radeon/radeon_surface.c b/radeon/radeon_surface.

Re: [PATCH] radeon: fix tile_split of 128-bit surface formats with 8x MSAA

2012-10-16 Thread Alex Deucher
On Tue, Oct 16, 2012 at 2:50 AM, Paul Menzel wrote: > Dear Marek, > > > Am Dienstag, den 16.10.2012, 02:21 +0200 schrieb Marek Olšák: >> The calculation led to the number 8192, which is too high. > > what is the reason it is limited to 4096? Hardware limitation? hw limit. > > What are the ramifi

[PATCH] radeon: fix tile_split of 128-bit surface formats with 8x MSAA

2012-10-16 Thread Marek Olšák
The calculation led to the number 8192, which is too high. --- radeon/radeon_surface.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/radeon/radeon_surface.c b/radeon/radeon_surface.c index 66c2444..eb587d2 100644 --- a/radeon/radeon_surface.c +++ b/radeon/radeon_surface.c @@ -939,6 +939

Re: [PATCH] radeon: fix tile_split of 128-bit surface formats with 8x MSAA

2012-10-15 Thread Paul Menzel
Dear Marek, Am Dienstag, den 16.10.2012, 02:21 +0200 schrieb Marek Olšák: > The calculation led to the number 8192, which is too high. what is the reason it is limited to 4096? Hardware limitation? What are the ramifications? GPU hangs, rendering errors? > --- > radeon/radeon_surface.c |2

[PATCH] radeon: fix tile_split of 128-bit surface formats with 8x MSAA

2012-10-15 Thread Marek Olšák
The calculation led to the number 8192, which is too high. --- radeon/radeon_surface.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/radeon/radeon_surface.c b/radeon/radeon_surface.c index 66c2444..eb587d2 100644 --- a/radeon/radeon_surface.c +++ b/radeon/radeon_surface.c @@ -939,6 +939