Re: [PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

2022-11-09 Thread Greg Kroah-Hartman
On Wed, Nov 09, 2022 at 08:30:52PM +0530, Deepak R Varma wrote: > On Fri, Nov 04, 2022 at 08:12:11PM +0530, Deepak R Varma wrote: > > On Fri, Nov 04, 2022 at 05:31:24PM +0530, Deepak R Varma wrote: > > > On Mon, Oct 31, 2022 at 01:05:32PM +0100, Julia Lawall wrote: > > > > > > > > > > > > I took a

Re: [PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

2022-11-09 Thread Deepak R Varma
On Fri, Nov 04, 2022 at 08:12:11PM +0530, Deepak R Varma wrote: > On Fri, Nov 04, 2022 at 05:31:24PM +0530, Deepak R Varma wrote: > > On Mon, Oct 31, 2022 at 01:05:32PM +0100, Julia Lawall wrote: > > > > > > > > > I took a look, but it's pretty complex. You could take the code and > > >

Re: [PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

2022-11-04 Thread Deepak R Varma
On Fri, Nov 04, 2022 at 05:31:24PM +0530, Deepak R Varma wrote: > On Mon, Oct 31, 2022 at 01:05:32PM +0100, Julia Lawall wrote: > > > > > > I took a look, but it's pretty complex. You could take the code and > > reorganize it so that it is more readable, and then take the definition of > > the

Re: [PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

2022-11-04 Thread Deepak R Varma
On Mon, Oct 31, 2022 at 01:05:32PM +0100, Julia Lawall wrote: > > > I took a look, but it's pretty complex. You could take the code and > reorganize it so that it is more readable, and then take the definition of > the ARRAY_SIZE macro, to better see what is going on. > > julia > Hello Greg,

Re: [PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

2022-10-31 Thread Julia Lawall
On Mon, 31 Oct 2022, Deepak R Varma wrote: > On Mon, Oct 31, 2022 at 12:41:40PM +0530, Deepak Varma wrote: > > On Sat, Oct 29, 2022 at 07:34:26PM +0200, Julia Lawall wrote: > > > > > > > > > On Sat, 29 Oct 2022, Deepak R Varma wrote: > > > > > > > On Sat, Oct 29, 2022 at 09:32:50AM +0200, Greg

Re: [PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

2022-10-31 Thread Deepak R Varma
On Mon, Oct 31, 2022 at 03:10:27PM +0530, Deepak Varma wrote: > On Mon, Oct 31, 2022 at 12:41:40PM +0530, Deepak Varma wrote: > > On Sat, Oct 29, 2022 at 07:34:26PM +0200, Julia Lawall wrote: > > > > > > > > > On Sat, 29 Oct 2022, Deepak R Varma wrote: > > > > > > > On Sat, Oct 29, 2022 at

Re: [PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

2022-10-31 Thread Deepak R Varma
On Mon, Oct 31, 2022 at 12:41:40PM +0530, Deepak Varma wrote: > On Sat, Oct 29, 2022 at 07:34:26PM +0200, Julia Lawall wrote: > > > > > > On Sat, 29 Oct 2022, Deepak R Varma wrote: > > > > > On Sat, Oct 29, 2022 at 09:32:50AM +0200, Greg Kroah-Hartman wrote: > > > > On Fri, Oct 28, 2022 at

Re: [PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

2022-10-31 Thread Deepak R Varma
On Sat, Oct 29, 2022 at 07:34:26PM +0200, Julia Lawall wrote: > > > On Sat, 29 Oct 2022, Deepak R Varma wrote: > > > On Sat, Oct 29, 2022 at 09:32:50AM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Oct 28, 2022 at 07:00:05PM +0530, Deepak R Varma wrote: > > > > The ARRAY_SIZE(foo) macro should be

Re: [PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

2022-10-29 Thread Julia Lawall
On Sat, 29 Oct 2022, Deepak R Varma wrote: > On Sat, Oct 29, 2022 at 09:32:50AM +0200, Greg Kroah-Hartman wrote: > > On Fri, Oct 28, 2022 at 07:00:05PM +0530, Deepak R Varma wrote: > > > The ARRAY_SIZE(foo) macro should be preferred over sizeof operator > > > based computation such as

Re: [PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

2022-10-29 Thread Deepak R Varma
On Sat, Oct 29, 2022 at 09:32:50AM +0200, Greg Kroah-Hartman wrote: > On Fri, Oct 28, 2022 at 07:00:05PM +0530, Deepak R Varma wrote: > > The ARRAY_SIZE(foo) macro should be preferred over sizeof operator > > based computation such as sizeof(foo)/sizeof(foo[0]) for finding > > number of elements

Re: [PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

2022-10-29 Thread Greg Kroah-Hartman
On Fri, Oct 28, 2022 at 07:00:05PM +0530, Deepak R Varma wrote: > The ARRAY_SIZE(foo) macro should be preferred over sizeof operator > based computation such as sizeof(foo)/sizeof(foo[0]) for finding > number of elements in an array. Issue identified using coccicheck. > > Signed-off-by: Deepak R

[PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

2022-10-28 Thread Deepak R Varma
The ARRAY_SIZE(foo) macro should be preferred over sizeof operator based computation such as sizeof(foo)/sizeof(foo[0]) for finding number of elements in an array. Issue identified using coccicheck. Signed-off-by: Deepak R Varma --- drivers/staging/fbtft/fbtft.h | 2 +- 1 file changed, 1