Re: [PATCH] staging: fbtft: fb_st7789v: support setting offset

2024-04-09 Thread Yuguo Pei
On Tue, 9 Apr 2024 17:49:25 +0200, Greg KH wrote: > So you are now hard-coding the size? Yes, the change just helps developers who want to adapt to different screen sizes. > Is this always going to be 0, if so, why need it at all? Not sure. For example, when HEIGHT and WIDTH are 240 and 280,

Re: [PATCH] staging: fbtft: fb_st7789v: support setting offset

2024-04-09 Thread purofle

Re: [PATCH] staging: fbtft: fb_st7789v: support setting offset

2024-04-09 Thread Greg KH
On Wed, Apr 10, 2024 at 01:28:06AM +0800, Yuguo Pei wrote: > On Tue, 9 Apr 2024 17:49:25 +0200, Greg KH wrote: > > So you are now hard-coding the size? > > Yes, the change just helps developers who want to adapt to different screen > sizes. So there is no change? I don't understand. > > Is

Re: [PATCH] staging: fbtft: fb_st7789v: support setting offset

2024-04-09 Thread Greg KH
On Sat, Apr 06, 2024 at 12:57:47AM +0800, purofle wrote: > Some screen sizes using st7789v chips are different from 240x320, > and offsets need to be set to display all images properly. > > Signed-off-by: purofle We need a semi-real name here please. > --- > drivers/staging/fbtft/fb_st7789v.c

[PATCH] staging: fbtft: fb_st7789v: support setting offset

2024-04-06 Thread purofle
Some screen sizes using st7789v chips are different from 240x320, and offsets need to be set to display all images properly. Signed-off-by: purofle --- drivers/staging/fbtft/fb_st7789v.c | 22 ++ 1 file changed, 22 insertions(+) diff --git